[TASK] Install Tool: Remove authentication from backend context 60/53860/7
authorBenni Mack <benni@typo3.org>
Fri, 1 Sep 2017 07:00:10 +0000 (09:00 +0200)
committerAndreas Fernandez <typo3@scripting-base.de>
Thu, 7 Sep 2017 14:40:17 +0000 (16:40 +0200)
commite3a0b0eb0ba3932d9f7fa642ec3f5107d18e0019
tree079f044decb3314fc21a4a09cc75214f8e23ea4e
parent5709b55f7850b3b334694f38cc0cf6184a78dc61
[TASK] Install Tool: Remove authentication from backend context

Currently calling the install tool modules from within the Backend does a
simple redirect with adding GET variables.

That's the reason why you need to re-authenticate again, and the context
is handed over as a query parameter, which is simply not needed at all.

Now, the redirect is removed, as the Backend entrypoint / request handler
handles the authentication of the backend user, and the standalone entry
point deals with the install tool password etc.

The context parameter is now detected by the entry point (!) as well,
allowing to get rid of quite some code.

There are some more consequences:
- Calling the install tool from the backend does not validate if you configuration
is set up (= recovery necessary) -> since you're already in the backend we guess
you're fine anyway.
- Redirect functionality is almost not needed anymore in the regular request handler
- routeParameters concept was removed again (which was introduced a couple of weeks ago)

Additionally, the contextService could be replaced at a later stage with just
a string.

Resolves: #82306
Releases: master
Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c
Reviewed-on: https://review.typo3.org/53860
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
typo3/sysext/backend/Classes/Http/BackendModuleRequestHandler.php
typo3/sysext/core/Tests/Acceptance/Backend/Install/InstallModuleCest.php [deleted file]
typo3/sysext/install/Classes/Controller/AbstractController.php
typo3/sysext/install/Classes/Controller/Action/AbstractAction.php
typo3/sysext/install/Classes/Controller/Action/ActionInterface.php
typo3/sysext/install/Classes/Controller/AjaxController.php
typo3/sysext/install/Classes/Controller/BackendModuleController.php
typo3/sysext/install/Classes/Controller/StepController.php
typo3/sysext/install/Classes/Controller/ToolController.php
typo3/sysext/install/Classes/Service/ContextService.php
typo3/sysext/install/ext_tables.php