[TASK] Use native idn functionality 34/60234/7
authorBenni Mack <benni@typo3.org>
Wed, 13 Mar 2019 08:13:20 +0000 (09:13 +0100)
committerGeorg Ringer <georg.ringer@gmail.com>
Sat, 16 Mar 2019 06:30:34 +0000 (07:30 +0100)
commitd5dd9421e5a13f62e90d2d191334fab44a02fbf4
treed83901ccf1f4754203a1f33303c235cdb9c38e40
parent2cb70093ba134171ab180d400451c8566b030eb4
[TASK] Use native idn functionality

It is safe to use idn_to_ascii() these days
due to symfony's polyfill functionality.

This allows us to remove the dependency
"algo26-matthias/idna-convert".

Also, all other places now use the native
idn_to_ascii() call, which could speed up
performance.

The wrapper call GeneralUtility::idnaEncode()
can then safely be deprecated.

used composer command:
  composer remove algo26-matthias/idna-convert

Resolves: #87894
Releases: master
Change-Id: I85aa6f39b8ff5ac171cd73218ed1144a56d9f724
Reviewed-on: https://review.typo3.org/c/60234
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Stephan GroƟberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 files changed:
composer.json
composer.lock
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/core/Classes/Mail/MailMessage.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-87894-GeneralUtilityidnaEncode.rst [new file with mode: 0644]
typo3/sysext/core/Documentation/Changelog/master/Important-87894-RemovedPHPDependencyAlgo26-matthiasidna-convert.rst [new file with mode: 0644]
typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.php [new file with mode: 0644]
typo3/sysext/core/composer.json
typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php
typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php