From: Georg Ringer <georg.ringer@gmail.com>
Date: Wed, 1 Feb 2017 11:11:49 +0000 (+0100)
Subject: [BUGFIX] Hide password hash for RsaInputField
X-Git-Tag: TYPO3_8-6-0~112
X-Git-Url: http://git.typo3.org/Packages/TYPO3.CMS.git/commitdiff_plain/d47c3327a4d3373ca2c00891570363e18234d16c

[BUGFIX] Hide password hash for RsaInputField

If rsauth is used, the eval configuration does not
contain the setting 'password' and the password can always
be hidden.

Resolves: #79576
Releases: master
Change-Id: Idcc8df67400be1d3f54e948681104ff9ad2d009e
Reviewed-on: https://review.typo3.org/51495
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
---

diff --git a/typo3/sysext/rsaauth/Classes/Form/Element/RsaInputElement.php b/typo3/sysext/rsaauth/Classes/Form/Element/RsaInputElement.php
index 8f939e7d3796..a6a0503e1386 100644
--- a/typo3/sysext/rsaauth/Classes/Form/Element/RsaInputElement.php
+++ b/typo3/sysext/rsaauth/Classes/Form/Element/RsaInputElement.php
@@ -53,17 +53,13 @@ class RsaInputElement extends AbstractFormElement
         $resultArray = $this->initializeResultArray();
         $resultArray['requireJsModules'] = ['TYPO3/CMS/Rsaauth/RsaEncryptionModule'];
 
-        $itemValue = $parameterArray['itemFormElValue'];
+        $itemValue = $parameterArray['itemFormElValue'] ? '*********' : '';
         $config = $parameterArray['fieldConf']['config'];
         $size = MathUtility::forceIntegerInRange($config['size'] ?: $this->defaultInputWidth, $this->minimumInputWidth, $this->maxInputWidth);
         $evalList = GeneralUtility::trimExplode(',', $config['eval'], true);
         $width = (int)$this->formMaxWidth($size);
 
         if ($config['readOnly']) {
-            // Early return for read only fields
-            if (in_array('password', $evalList, true)) {
-                $itemValue = $itemValue ? '*********' : '';
-            }
             $html = [];
             $html[] = '<div class="t3js-formengine-field-item">';
             $html[] =   '<div class="form-wizards-wrap">';