From: Andreas Fernandez <a.fernandez@scripting-base.de>
Date: Thu, 27 Jul 2017 05:40:05 +0000 (+0200)
Subject: [BUGFIX] Always hide the loading spinner of System Information
X-Git-Tag: v9.0.0~738
X-Git-Url: http://git.typo3.org/Packages/TYPO3.CMS.git/commitdiff_plain/c45b6064aaae6c08ed9eeb567da21553bfc8fe05

[BUGFIX] Always hide the loading spinner of System Information

If the AJAX request that fetches information for the System Information
toolbar item fails for whatever reason, the spinner is now removed.

This may happen when the session times out and the re-login modal is shown
for a longer period.

Resolves: #81984
Releases: master, 8.7
Change-Id: Ibe9566d29d403e64d55fd0f462d452413d863f0a
Reviewed-on: https://review.typo3.org/53604
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---

diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js b/typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js
index 6befb1200783..8098c9fe45e8 100644
--- a/typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js
+++ b/typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js
@@ -74,9 +74,11 @@ define([
 			success: function(data) {
 				$menuContainer.html(data);
 				SystemInformationMenu.updateCounter();
-				$(SystemInformationMenu.identifier.toolbarIconSelector, SystemInformationMenu.identifier.containerSelector).replaceWith($existingIcon);
 
 				SystemInformationMenu.initialize();
+			},
+			complete: function() {
+				$(SystemInformationMenu.identifier.toolbarIconSelector, SystemInformationMenu.identifier.containerSelector).replaceWith($existingIcon);
 			}
 		}).done(function(){
 			// reload error data every five minutes