From: Christian Kuhn <lolli@schwarzbu.ch>
Date: Thu, 10 Jan 2019 11:27:55 +0000 (+0100)
Subject: [TASK] Remove unit tests that do not test the subject
X-Git-Tag: v10.0.0~717
X-Git-Url: http://git.typo3.org/Packages/TYPO3.CMS.git/commitdiff_plain/82d2a234889a68ba3b6eb5290defe3ebb447a012?hp=2258d11b7f3f4fa2e9937c24ad3a295eefd3db07

[TASK] Remove unit tests that do not test the subject

Some tests in FrontendLoginControllerTest test only
GeneralUtility::getIndpEnv(), but not the system under
test FrontendLoginController. Remove those.

Resolves: #87389
Releases: master
Change-Id: I3ea71c15ad8eda16750bfec1367ee4cc439dee2f
Reviewed-on: https://review.typo3.org/59397
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
---

diff --git a/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php b/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php
index a9e6c4bc0f60..728bcee90256 100644
--- a/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php
+++ b/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php
@@ -75,44 +75,6 @@ class FrontendLoginControllerTest extends UnitTestCase
         $_SERVER['HTTP_HOST'] = $this->testHostName;
     }
 
-    /**
-     * @test
-     */
-    public function typo3SitePathEqualsStubSitePath()
-    {
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_PATH'), $this->testSitePath);
-    }
-
-    /**
-     * @test
-     */
-    public function typo3SiteUrlEqualsStubSiteUrl()
-    {
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_URL'), ('http://' . $this->testHostName) . $this->testSitePath);
-    }
-
-    /**
-     * @test
-     */
-    public function typo3SitePathEqualsStubSitePathAfterChangingInTest()
-    {
-        $this->testHostName = 'somenewhostname.com';
-        $this->testSitePath = '/somenewpath/';
-        $this->setUpFakeSitePathAndHost();
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_PATH'), $this->testSitePath);
-    }
-
-    /**
-     * @test
-     */
-    public function typo3SiteUrlEqualsStubSiteUrlAfterChangingInTest()
-    {
-        $this->testHostName = 'somenewhostname.com';
-        $this->testSitePath = '/somenewpath/';
-        $this->setUpFakeSitePathAndHost();
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_URL'), ('http://' . $this->testHostName) . $this->testSitePath);
-    }
-
     /**
      * Data provider for validateRedirectUrlClearsUrl
      *