From: Sascha Egerer Date: Fri, 4 Jul 2014 12:40:31 +0000 (+0200) Subject: [CLEANUP] Stupid array assignment X-Git-Tag: 7.0.0~878 X-Git-Url: http://git.typo3.org/Packages/TYPO3.CMS.git/commitdiff_plain/69be7404e0fe665087e8aba039f62c4c83d769dd?hp=10d5deb5c14d50664161dec3b6d5a942d9c58bc1 [CLEANUP] Stupid array assignment There are two places where a new item is assigned to an array with `$myArray[] .= ''`. This would do the same as `$myArray[] = ''` because it always adds a new item to the array. Resolves: #60101 Releases: 6.3 Change-Id: I122b0fe80b1ac026c0c9f353446bb48834eba74e Reviewed-on: https://review.typo3.org/31321 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes --- diff --git a/typo3/sysext/backend/Classes/Form/FormEngine.php b/typo3/sysext/backend/Classes/Form/FormEngine.php index cc324c66ca9b..5b49837176b9 100644 --- a/typo3/sysext/backend/Classes/Form/FormEngine.php +++ b/typo3/sysext/backend/Classes/Form/FormEngine.php @@ -2245,9 +2245,9 @@ TBE_EDITOR.customEvalFunctions[\'' . $evalData . '\'] = function(value) { $onClickCell = $this->elName(($PA['itemFormElName'] . '[' . $c . ']')) . '.checked=!' . $this->elName(($PA['itemFormElName'] . '[' . $c . ']')) . '.checked;'; $onClick = 'this.attributes.getNamedItem("class").nodeValue = ' . $this->elName(($PA['itemFormElName'] . '[' . $c . ']')) . '.checked ? "c-selectedItem" : "c-unselectedItem";'; $setAll[] = $this->elName(($PA['itemFormElName'] . '[' . $c . ']')) . '.checked=1;'; - $setAll[] .= '$(\'' . $rowId . '\').removeClassName(\'c-unselectedItem\');$(\'' . $rowId . '\').addClassName(\'c-selectedItem\');'; + $setAll[] = '$(\'' . $rowId . '\').removeClassName(\'c-unselectedItem\');$(\'' . $rowId . '\').addClassName(\'c-selectedItem\');'; $unSetAll[] = $this->elName(($PA['itemFormElName'] . '[' . $c . ']')) . '.checked=0;'; - $unSetAll[] .= '$(\'' . $rowId . '\').removeClassName(\'c-selectedItem\');$(\'' . $rowId . '\').addClassName(\'c-unselectedItem\');'; + $unSetAll[] = '$(\'' . $rowId . '\').removeClassName(\'c-selectedItem\');$(\'' . $rowId . '\').addClassName(\'c-unselectedItem\');'; $restoreCmd[] = $this->elName(($PA['itemFormElName'] . '[' . $c . ']')) . '.checked=' . ($sM ? 1 : 0) . ';' . '$(\'' . $rowId . '\').removeClassName(\'c-selectedItem\');$(\'' . $rowId . '\').removeClassName(\'c-unselectedItem\');' . '$(\'' . $rowId . '\').addClassName(\'c-' . ($sM ? '' : 'un') . 'selectedItem\');'; // Check if some help text is available // Since TYPO3 4.5 help text is expected to be an associative array