[BUGFIX] Fix broken shortcut menu and icon padding 92/34792/2
authorFrank Nägler <typo3@naegler.net>
Sat, 29 Nov 2014 23:58:16 +0000 (00:58 +0100)
committerBenjamin Mack <benni@typo3.org>
Sun, 30 Nov 2014 00:19:04 +0000 (01:19 +0100)
Fix the broken shortcut menu, a closing '>' is missing.
Fix padding of some icons on the right side.

Resolves: #63438
Releases: master
Change-Id: Id7f77ec722fa39494d79efc9b24a0e732ff6ee20
Reviewed-on: http://review.typo3.org/34792
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php
typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_topbar.less
typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css

index 16b08e3..6dac09a 100644 (file)
@@ -139,7 +139,7 @@ class ShortcutToolbarItem implements ToolbarItemInterface {
                                                '</a>
                                        </td>
                                        <td class="shortcut-edit">' . $editIcon . '</td>
-                                       <td class="shortcut-delete"' . $deleteIcon . '</td>
+                                       <td class="shortcut-delete">' . $deleteIcon . '</td>
                                </tr>';
                }
                // Now render groups and the contained shortcuts
index 137f045..be7d5a1 100644 (file)
@@ -89,6 +89,9 @@ Topbar
                                                        font-weight: normal;
                                                        line-height: @line-height-base;
                                                        white-space: nowrap;
+                                                       > .t3-icon {
+                                                               margin-right: 5px;
+                                                       }
                                                }
 
                                                &.active {
@@ -146,6 +149,10 @@ Topbar
                                                        }
                                                }
                                        }
+                                       > tbody > tr > td.shortcut-edit > a,
+                                       > tbody > tr > td.shortcut-delete > a {
+                                               padding: 3px 5px;
+                                       }
                                }
 
                                li,
index 4ab0c9a..68c35ce 100644 (file)
@@ -11478,6 +11478,9 @@ Topbar
   line-height: 1.5;
   white-space: nowrap;
 }
+#typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu > ul > li > a > .t3-icon {
+  margin-right: 5px;
+}
 #typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu > ul > li.active > a {
   background-color: #282828;
 }
@@ -11525,6 +11528,10 @@ Topbar
 #typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu > table > tbody > tr > td > a.active > a {
   background-color: #282828;
 }
+#typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu > table > tbody > tr > td.shortcut-edit > a,
+#typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu > table > tbody > tr > td.shortcut-delete > a {
+  padding: 3px 5px;
+}
 #typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu li a,
 #typo3-topbar #typo3-top-container #typo3-toolbar .dropdown-menu td a {
   color: #ffffff;