[TASK] Remove skipped test in DisjunctionValidatorTest 64/57664/3
authorAnja Leichsenring <anja.leichsenring@typo3.com>
Mon, 23 Jul 2018 19:05:21 +0000 (21:05 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Mon, 23 Jul 2018 21:44:44 +0000 (23:44 +0200)
The functionality guarded by the test does not apply anymore.
After the test has been skipped since a long time already,
it is safe to just remove it.

Change-Id: I7757b57e7f7424d2631f67b736d927f525e01f0b
Resolves: #85625
Releases: master
Reviewed-on: https://review.typo3.org/57664
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php

index 6b7926a..12459b4 100644 (file)
@@ -26,27 +26,6 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class DisjunctionValidatorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
 {
-    /**
-     * @test
-     */
-    public function allValidatorsInTheDisjunctionAreCalledEvenIfOneReturnsNoError()
-    {
-        $this->markTestSkipped('Needs a bugfix of Flow first.');
-        $validatorDisjunction = new \TYPO3\CMS\Extbase\Validation\Validator\DisjunctionValidator([]);
-        $validatorObject = $this->getMockBuilder(\TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface::class)
-            ->setMethods(['validate', 'getOptions'])
-            ->getMock();
-        $validatorObject->expects($this->once())->method('validate')->will($this->returnValue(new \TYPO3\CMS\Extbase\Error\Result()));
-        $errors = new \TYPO3\CMS\Extbase\Error\Result();
-        $errors->addError(new \TYPO3\CMS\Extbase\Error\Error('Error', 123));
-        $secondValidatorObject = $this->getMockBuilder(\TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface::class)
-            ->setMethods(['validate', 'getOptions'])
-            ->getMock();
-        $secondValidatorObject->expects($this->exactly(1))->method('validate')->will($this->returnValue($errors));
-        $validatorDisjunction->addValidator($validatorObject);
-        $validatorDisjunction->addValidator($secondValidatorObject);
-        $validatorDisjunction->validate('some subject');
-    }
 
     /**
      * @test