[!!!][TASK] Remove obsolete page tree and click menu settings 94/49694/3
authorTymoteusz Motylewski <t.motylewski@gmail.com>
Wed, 31 Aug 2016 19:00:04 +0000 (21:00 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Thu, 1 Sep 2016 20:04:57 +0000 (22:04 +0200)
Following settings are removed:
options.pageTree.disableTitleHighlight
options.contextMenu.options.leftIcons

Removed also obsolete settings from TS reserved keywords.

Resolves: #77728
Releases: master
Change-Id: I8711b6c13bad772df3af4538fe93cbc3605c2299
Reviewed-on: https://review.typo3.org/49694
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php
typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-77728-RemoveObsoletePropertiesRelatedToPageTreeView.rst [new file with mode: 0644]
typo3/sysext/t3editor/Resources/Public/JavaScript/parse_typoscript/tokenizetyposcript.js

index e130fc3..b93ac5a 100644 (file)
@@ -80,13 +80,6 @@ class ClickMenu
     public $disabledItems = [];
 
     /**
-     * If TRUE, Show icons on the left.
-     *
-     * @var bool
-     */
-    public $leftIcons = false;
-
-    /**
      * Array of classes to be used for user processing of the menu content.
      * This is for the API of adding items to the menu from outside.
      *
@@ -187,7 +180,6 @@ class ClickMenu
         }
         $TSkey = ($this->isDBmenu ? 'page' : 'folder') . ($this->listFrame ? 'List' : 'Tree');
         $this->disabledItems = GeneralUtility::trimExplode(',', $this->backendUser->getTSConfigVal('options.contextMenu.' . $TSkey . '.disableItems'), true);
-        $this->leftIcons = (bool)$this->backendUser->getTSConfigVal('options.contextMenu.options.leftIcons');
         // &cmLevel flag detected (2nd level menu)
         if (!$this->cmLevel) {
             // Make 1st level clickmenu:
index 7cd9dba..2cedcb4 100644 (file)
@@ -59,11 +59,6 @@ class FileSystemNavigationFrameController
     protected $scopeData;
 
     /**
-     * @var bool
-     */
-    public $doHighlight;
-
-    /**
      * ModuleTemplate Container
      *
      * @var ModuleTemplate
@@ -146,20 +141,14 @@ class FileSystemNavigationFrameController
      */
     public function initPage()
     {
-        // Setting highlight mode:
-        $this->doHighlight = !$this->getBackendUser()->getTSConfigVal('options.pageTree.disableTitleHighlight');
-
         $this->moduleTemplate->setBodyTag('<body id="ext-backend-Modules-FileSystemNavigationFrame-index-php">');
 
-        // Adding javascript code for drag&drop and the filetree as well as the click menu code
-        $dragDropCode = '';
-        if ($this->doHighlight) {
-            $hlClass = $this->getBackendUser()->workspace === 0 ? 'active' : 'active active-ws wsver' . $GLOBALS['BE_USER']->workspace;
-            $dragDropCode = '
-                       Tree.highlightClass = "' . $hlClass . '";
-                       Tree.highlightActiveItem("", top.fsMod.navFrameHighlightedID["file"]);
-                       ';
-        }
+        // Adding javascript code for drag&drop and the file tree as well as the click menu code
+        $hlClass = $this->getBackendUser()->workspace === 0 ? 'active' : 'active active-ws wsver' . $GLOBALS['BE_USER']->workspace;
+        $dragDropCode = '
+               Tree.highlightClass = "' . $hlClass . '";
+               Tree.highlightActiveItem("", top.fsMod.navFrameHighlightedID["file"]);
+               ';
 
         // Adding javascript for drag & drop activation and highlighting
         $pageRenderer = $this->moduleTemplate->getPageRenderer();
@@ -183,7 +172,7 @@ class FileSystemNavigationFrameController
                        top.fsMod.currentBank = bank;
                        top.TYPO3.Backend.ContentContainer.setUrl(theUrl);
 
-                       ' . ($this->doHighlight ? 'Tree.highlightActiveItem("file", highlightID + "_" + bank);' : '') . '
+                       Tree.highlightActiveItem("file", highlightID + "_" + bank);
                        if (linkObj) { linkObj.blur(); }
                        return false;
                }
index c195a03..c28252d 100644 (file)
@@ -770,7 +770,6 @@ return [
                                doktypesToShowInNewPageDragArea = 1,6,4,7,3,254,255,199
                        }
 
-                       options.contextMenu.options.leftIcons = 1
                        options.contextMenu {
                                table {
                                        virtual_root {
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-77728-RemoveObsoletePropertiesRelatedToPageTreeView.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-77728-RemoveObsoletePropertiesRelatedToPageTreeView.rst
new file mode 100644 (file)
index 0000000..e806a93
--- /dev/null
@@ -0,0 +1,38 @@
+====================================================================
+Breaking: #77728 - Remove obsolete page tree and click menu settings
+====================================================================
+
+Description
+===========
+
+The following obsolete properties have been removed:
+
+- :php:``FileSystemNavigationFrameController->doHighlight``
+
+- :php:``ClickMenu->leftIcons``
+
+The following user TS settings have been removed:
+
+- :typoscript:``options.pageTree.disableTitleHighlight``
+
+- :typoscript:``options.contextMenu.options.leftIcons``
+
+
+Impact
+======
+
+Extensions which use one of the public properties above will throw a fatal error.
+Setting above options in UserTSconfig will not impact the tree behaviour.
+
+
+Affected Installations
+======================
+
+All installations with a 3rd party extension using one of the classes above.
+All installations using one of the UserTSconfig settings above.
+
+
+Migration
+=========
+
+No migration available.
\ No newline at end of file
index 091c151..3c69e6a 100644 (file)
@@ -166,7 +166,6 @@ var typoscriptWords = {
        'clearCacheCmd': 'reserved',
        'clearCacheLevels': 'reserved',
        'clearCacheOfPages': 'reserved',
-       'clickMenuTimeOut': 'reserved',
        'clickTitleMode': 'reserved',
        'clipboardNumberPads': 'reserved',
        'cMargins': 'reserved',
@@ -532,7 +531,6 @@ var typoscriptWords = {
        'languageField': 'reserved',
        'layout': 'keyword2',
        'left': 'reserved',
-       'leftIcons': 'reserved',
        'leftjoin': 'reserved',
        'levels': 'reserved',
        'leveltitle': 'keyword3',