[CLEANUP] Initialize variables in EXT:version 22/51722/2
authorSascha Egerer <sascha@sascha-egerer.de>
Thu, 16 Feb 2017 21:06:43 +0000 (22:06 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 16 Feb 2017 22:44:22 +0000 (23:44 +0100)
Add some missing variable initialization in EXT:version

Resolves: #79862
Releases: master
Change-Id: I97d8326675d9d90404b99e501e8756ec045c0d90
Reviewed-on: https://review.typo3.org/51722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/version/Classes/Controller/VersionModuleController.php
typo3/sysext/version/Classes/Dependency/ElementEntity.php
typo3/sysext/version/Classes/Hook/DataHandlerHook.php

index fa402cc..c0edb8f 100644 (file)
@@ -65,6 +65,36 @@ class VersionModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClass
     public $content;
 
     /**
+     * @var string
+     */
+    public $table;
+
+    /**
+     * @var string
+     */
+    public $details;
+
+    /**
+     * @var string
+     */
+    public $diffOnly;
+
+    /**
+     * @var int
+     */
+    public $uid;
+
+    /**
+     * @var array|bool
+     */
+    public $pageinfo;
+
+    /**
+     * @var bool
+     */
+    public $recordFound;
+
+    /**
      * Accumulated content
      *
      * @var int
@@ -111,6 +141,11 @@ class VersionModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClass
     public $recIndex = [];
 
     /**
+     * @var string
+     */
+    public $REQUEST_URI = '';
+
+    /**
      * The name of the module
      *
      * @var string
@@ -278,8 +313,8 @@ class VersionModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClass
         // Diffing:
         $diff_1 = GeneralUtility::_POST('diff_1');
         $diff_2 = GeneralUtility::_POST('diff_2');
+        $content = '';
         if (GeneralUtility::_POST('do_diff')) {
-            $content = '';
             $content .= '<div class="panel panel-space panel-default">';
             $content .= '<div class="panel-heading">' . $lang->getLL('diffing') . '</div>';
             if ($diff_1 && $diff_2) {
index 9f08ebd..80778aa 100644 (file)
@@ -352,7 +352,7 @@ class ElementEntity
     /**
      * Gets the outermost parent element.
      *
-     * @return ElementEntity
+     * @return ElementEntity|bool
      */
     public function getOuterMostParent()
     {
index 9d2110a..2aabae3 100644 (file)
@@ -48,6 +48,11 @@ class DataHandlerHook
      */
     protected $remappedIds = [];
 
+    /**
+     * @var \TYPO3\CMS\Workspaces\Service\WorkspaceService
+     */
+    protected $workspaceService;
+
     /****************************
      *****  Cmdmap  Hooks  ******
      ****************************/