[BUGFIX] Remove dangling handling of children without localization parent 63/44363/2
authorSebastian Fischer <typo3@evoweb.de>
Thu, 29 Oct 2015 16:03:46 +0000 (17:03 +0100)
committerMorton Jonuschat <m.jonuschat@mojocode.de>
Thu, 29 Oct 2015 17:08:52 +0000 (18:08 +0100)
This patch removes all code from inline record related classes that
covered the handling of dangling children.

Resolves: #71131
Releases: master
Change-Id: Ic98e201e63f6703d23c395a3e9c48ccc003d1490
Reviewed-on: https://review.typo3.org/44363
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php
typo3/sysext/backend/Classes/Form/FormDataCompiler.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php

index c925a36..1badb23 100644 (file)
@@ -469,10 +469,6 @@ class InlineRecordContainer extends AbstractContainer
             $cells['localize.isLocalizable'] = '<span title="' . $languageService->sL('LLL:EXT:lang/locallang_misc.xlf:localize.isLocalizable', true) . '">'
                 . $this->iconFactory->getIcon('actions-edit-localize-status-low', Icon::SIZE_SMALL)->render()
                 . '</span>';
-        } elseif ($data['inlineIsDanglingLocalization']) {
-            $cells['localize.wasRemovedInOriginal'] = '<span title="' . $languageService->sL('LLL:EXT:lang/locallang_misc.xlf:localize.wasRemovedInOriginal', true) . '">'
-                . $this->iconFactory->getIcon('actions-edit-localize-status-high', Icon::SIZE_SMALL)->render()
-                . '</span>';
         }
         // "Info": (All records)
         if ($enabledControls['info'] && !$isNewItem) {
index 1454350..7167c93 100644 (file)
@@ -212,10 +212,6 @@ class FormDataCompiler
             // will then use this relation to resolve for instance input placeholder relation values.
             'inlineChildChildUid' => null,
             // Inline scenario: A localized parent record is handled and localizationMode is set to "select", so inline
-            // parents can have localized children. This value is set to TRUE if this array represents a localized child
-            // overlay record that has no default language record.
-            'inlineIsDanglingLocalization' => false,
-            // Inline scenario: A localized parent record is handled and localizationMode is set to "select", so inline
             // parents can have localized childen. This value is set to TRUE if this array represents a default language
             // child record that was not yet localized.
             'inlineIsDefaultLanguage' => false,
index 7d5cac9..5e2839f 100644 (file)
@@ -176,14 +176,8 @@ class TcaInline extends AbstractDatabaseRecordProvider implements FormDataProvid
                         $connectedUidsOfDefaultLanguageRecord = array_diff($connectedUidsOfDefaultLanguageRecord, array($uidOfDefaultLanguageRecord));
                         // Compile localized record
                         $compiledChild = $this->compileChild($result, $fieldName, $localizedUid);
-                        $compiledChild['inlineIsTranslationWithDefaultLanguage'] = true;
                         $result['processedTca']['columns'][$fieldName]['children'][] = $compiledChild;
-                    } elseif ($showRemoved) {
-                        // This localized child has no default language record. Compile child and mark it as such
-                        $compiledChild = $this->compileChild($result, $fieldName, $localizedUid);
-                        $compiledChild['inlineIsDanglingLocalization'] = true;
-                        $result['processedTca']['columns'][$fieldName]['children'][] = $compiledChild;
-                    } // Discard child if default language is missing and no showRemoved is set
+                    }
                 }
                 if ($showPossible) {
                     foreach ($connectedUidsOfDefaultLanguageRecord as $defaultLanguageUid) {