[BUGFIX] Use Sprite Icons for ShortcutMenu 53/34553/2
authorBenjamin Mack <benni@typo3.org>
Mon, 24 Nov 2014 15:07:23 +0000 (16:07 +0100)
committerStefan Neufeind <typo3.neufeind@speedpartner.de>
Mon, 24 Nov 2014 16:31:20 +0000 (17:31 +0100)
The shortcut menu still uses
hardcoded img tags to typo3/gfx/.

Resolves: #63301
Releases: master
Change-Id: I3d37008b5723644a236af20a9a59abb239ad3684
Reviewed-on: http://review.typo3.org/34553
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php

index 93ceab6..4fbf6f6 100644 (file)
@@ -121,9 +121,9 @@ class ShortcutToolbarItem implements ToolbarItemInterface {
                $shortcutGroup = $languageService->sL('LLL:EXT:lang/locallang_core.xlf:toolbarItems.bookmarksGroup', TRUE);
                $shortcutEdit = $languageService->sL('LLL:EXT:lang/locallang_core.xlf:toolbarItems.bookmarksEdit', TRUE);
                $shortcutDelete = $languageService->sL('LLL:EXT:lang/locallang_core.xlf:toolbarItems.bookmarksDelete', TRUE);
-               $groupIcon = '<img' . IconUtility::skinImg('', 'gfx/i/sysf.gif', 'width="18" height="16"') . ' title="' . $shortcutGroup . '" alt="' . $shortcutGroup . '" />';
-               $editIcon = '<img' . IconUtility::skinImg('', 'gfx/edit2.gif', 'width="11" height="12"') . ' title="' . $shortcutEdit . '" alt="' . $shortcutEdit . '"';
-               $deleteIcon = '<img' . IconUtility::skinImg('', 'gfx/garbage.gif', 'width="11" height="12"') . ' title="' . $shortcutDelete . '" alt="' . $shortcutDelete . '" />';
+               $groupIcon = IconUtility::getSpriteIcon('apps-pagetree-folder-default', array('title' => $shortcutGroup));
+               $editIcon = IconUtility::getSpriteIcon('actions-document-open', array('title' => $shortcutEdit));
+               $deleteIcon = IconUtility::getSpriteIcon('actions-edit-delete', array('title' => $shortcutEdit));
                $shortcutMenu[] = '<table border="0" class="shortcut-list">';
                // Render shortcuts with no group (group id = 0) first
                $noGroupShortcuts = $this->getShortcutsByGroup(0);
@@ -134,7 +134,7 @@ class ShortcutToolbarItem implements ToolbarItemInterface {
                                <td class="shortcut-label">
                                        <a href="#" onclick="' . $shortcut['action'] . '; return false;">' . htmlspecialchars($shortcut['label']) . '</a>
                                </td>
-                               <td class="shortcut-edit">' . $editIcon . ' /></td>
+                               <td class="shortcut-edit">' . $editIcon . '</td>
                                <td class="shortcut-delete">' . $deleteIcon . '</td>
                        </tr>';
                }
@@ -163,7 +163,7 @@ class ShortcutToolbarItem implements ToolbarItemInterface {
                                                <td class="shortcut-label">
                                                        <a href="#" onclick="' . $shortcut['action'] . '; return false;">' . htmlspecialchars($shortcut['label']) . '</a>
                                                </td>
-                                               <td class="shortcut-edit">' . $editIcon . ' /></td>
+                                               <td class="shortcut-edit">' . $editIcon . '</td>
                                                <td class="shortcut-delete">' . $deleteIcon . '</td>
                                        </tr>';
                                }