[TASK] Remove empty table at end of list output 03/21803/2
authorGeorg Ringer <georg.ringer@gmail.com>
Tue, 2 Jul 2013 14:30:39 +0000 (16:30 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Tue, 2 Jul 2013 15:00:26 +0000 (17:00 +0200)
Page module, filelist module and element browser are calling
writeBottom() which just adds an empty table which is not needed.

As the function could be used by 3rd party, the function is
deprecated

Releases: 6.2
Resolves: #49593
Change-Id: Iab6af693eda0bec54e3645ec784d2010e751117a
Reviewed-on: https://review.typo3.org/21803
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php
typo3/sysext/filelist/Classes/Controller/FileListController.php
typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php
typo3/sysext/recordlist/Classes/RecordList.php

index d154b15..ad189be 100644 (file)
@@ -270,18 +270,10 @@ abstract class AbstractRecordList {
         *
         * @return void
         * @todo Define visibility
+        * @deprecated will be removed 2 versions from 6.2
         */
        public function writeBottom() {
-               $this->HTMLcode .= '
-
-               <!--
-                       End of list table:
-               -->
-               <table border="0" cellpadding="0" cellspacing="0">';
-               $theIcon = '<img' . IconUtility::skinImg($this->backPath, 'gfx/ol/stopper.gif', 'width="18" height="16"') . ' alt="" />';
-               $this->HTMLcode .= $this->addElement(1, '', array(), '', $this->leftMargin, $theIcon);
-               $this->HTMLcode .= '
-               </table>';
+               GeneralUtility::deprecationLog('Function writeBottom is not needed anymore');
        }
 
        /**
index ad633c9..1fcb053 100644 (file)
@@ -288,8 +288,6 @@ class FileListController {
                        $this->filelist->start($this->folderObject, $this->pointer, $this->MOD_SETTINGS['sort'], $this->MOD_SETTINGS['reverse'], $this->MOD_SETTINGS['clipBoard'], $this->MOD_SETTINGS['bigControlPanel']);
                        // Generate the list
                        $this->filelist->generateList();
-                       // Write the footer
-                       $this->filelist->writeBottom();
                        // Set top JavaScript:
                        $this->doc->JScode = $this->doc->wrapScriptTags('
 
index 261bff3..c2309df 100644 (file)
@@ -1465,7 +1465,6 @@ class ElementBrowser {
                        $dblist->start($id, \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('table'), $pointer, \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('search_field'), \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('search_levels'), \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('showLimit'));
                        $dblist->setDispFields();
                        $dblist->generateList();
-                       $dblist->writeBottom();
                        //      Add the HTML for the record list to output variable:
                        $out .= $dblist->HTMLcode;
                        // Add support for fieldselectbox in singleTableMode
index d763f75..27e2290 100644 (file)
@@ -346,8 +346,6 @@ class RecordList {
                        }
                        // Render the list of tables:
                        $dblist->generateList();
-                       // Write the bottom of the page:
-                       $dblist->writeBottom();
                        $listUrl = substr($dblist->listURL(), strlen($GLOBALS['BACK_PATH']));
                        // Add JavaScript functions to the page:
                        $this->doc->JScode = $this->doc->wrapScriptTags('