[TASK] Make SilentConfigurationUpgradeServiceTest notice free 82/56182/2
authorJan Helke <typo3@helke.de>
Thu, 15 Mar 2018 17:37:09 +0000 (18:37 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 15 Mar 2018 17:44:54 +0000 (18:44 +0100)
Resolves: #84310
Releases: master
Change-Id: I6a3418fe449badd8beb1ec04f3d522c05696ce94
Reviewed-on: https://review.typo3.org/56182
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php

index 18769c0..482d990 100644 (file)
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 namespace TYPO3\CMS\Install\Tests\Unit\Service;
 
 /*
@@ -22,18 +23,14 @@ use TYPO3\CMS\Core\Utility\Exception\MissingArrayPathException;
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Install\Service\Exception\ConfigurationChangedException;
 use TYPO3\CMS\Install\Service\SilentConfigurationUpgradeService;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
  * Test case
  */
-class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
+class SilentConfigurationUpgradeServiceTest extends UnitTestCase
 {
     /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
-    /**
      * @var ConfigurationManager|\PHPUnit_Framework_MockObject_MockObject
      */
     protected $configurationManager;
@@ -75,7 +72,7 @@ class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core
      *
      * @return array
      */
-    public function configureBackendLoginSecurityLocalconfiguration()
+    public function configureBackendLoginSecurityLocalconfiguration(): array
     {
         return [
             ['', 'rsa', true, false],
@@ -295,7 +292,7 @@ class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core
      *
      * @return array
      */
-    public function httpSettingsMappingDataProvider()
+    public function httpSettingsMappingDataProvider(): array
     {
         return [
             'No changes overridden in Local Configuration' => [