[TASK] Call getDomainStartPage without third parameter 01/55901/2
authorBenni Mack <benni@typo3.org>
Mon, 26 Feb 2018 08:39:55 +0000 (09:39 +0100)
committerFrank Naegler <frank.naegler@typo3.org>
Mon, 26 Feb 2018 11:58:00 +0000 (12:58 +0100)
The third parameter in PageRepository->getDomainStartPage
is not used anymore. Saving an extra call to GeneralUtility
to not hand this parameter over to the method in TSFE should be helpful.

However, in the future, this method will probably be changed,
the third parameter is not deprecated for now.

Resolves: #84043
Releases: master
Change-Id: I397dd86d703f4fa5778794209e90ffaa82baf872
Reviewed-on: https://review.typo3.org/55901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

index 7c920aa..635cc84 100644 (file)
@@ -1851,7 +1851,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
             $pageUid = 0;
             $host = explode('.', GeneralUtility::getIndpEnv('HTTP_HOST'));
             while (count($host)) {
-                $pageUid = $this->sys_page->getDomainStartPage(implode('.', $host), GeneralUtility::getIndpEnv('SCRIPT_NAME'), GeneralUtility::getIndpEnv('REQUEST_URI'));
+                $pageUid = $this->sys_page->getDomainStartPage(implode('.', $host), GeneralUtility::getIndpEnv('SCRIPT_NAME'));
                 if ($pageUid) {
                     return $pageUid;
                 }
@@ -1859,7 +1859,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
             }
             return $pageUid;
         }
-        return $this->sys_page->getDomainStartPage(GeneralUtility::getIndpEnv('HTTP_HOST'), GeneralUtility::getIndpEnv('SCRIPT_NAME'), GeneralUtility::getIndpEnv('REQUEST_URI'));
+        return $this->sys_page->getDomainStartPage(GeneralUtility::getIndpEnv('HTTP_HOST'), GeneralUtility::getIndpEnv('SCRIPT_NAME'));
     }
 
     /**