[!!!][TASK] Removed deprecated code from EXT:rtehtmlarea 08/45408/2
authorJigal van Hemert <jigal.van.hemert@typo3.org>
Tue, 22 Dec 2015 13:52:59 +0000 (14:52 +0100)
committerBenni Mack <benni@typo3.org>
Wed, 23 Dec 2015 19:08:14 +0000 (20:08 +0100)
Releases: master
Resolves: #72390
Change-Id: I6979f4289ebcb5a1027dbc5996e53ad3f70669c8
Reviewed-on: https://review.typo3.org/45408
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/core/Documentation/Changelog/master/Breaking-72390-RemovedDeprecatedCodeFromEXTrtehtmlarea.rst [new file with mode: 0644]
typo3/sysext/rtehtmlarea/Classes/Controller/ParseHtmlController.php
typo3/sysext/rtehtmlarea/Classes/Controller/UserElementsController.php
typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Modules/SelectImage.js

diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-72390-RemovedDeprecatedCodeFromEXTrtehtmlarea.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-72390-RemovedDeprecatedCodeFromEXTrtehtmlarea.rst
new file mode 100644 (file)
index 0000000..b75f639
--- /dev/null
@@ -0,0 +1,39 @@
+===============================================================
+Breaking: #72390 - Removed deprecated code from EXT:rtehtmlarea
+===============================================================
+
+Description
+===========
+
+The following methods have been removed:
+
+* ``UserElementsController::main``
+* ``UserElementsController::printContent``
+* ``ParseHtmlController::main``
+* ``ParseHtmlController::printContent``
+
+Furthermore a JavaScript function has been removed:
+
+* ``initEventListeners``
+
+
+Impact
+======
+
+Using the methods above directly in any third party extension will result in a fatal error.
+
+
+Affected Installations
+======================
+
+Instances which use custom calls to UserElementsController, ParseHtmlController via the methods above, or rely on the JavaScript function mentioned above being executed.
+
+
+Migration
+=========
+
+``initEventListener`` no replacement for this
+``UserElementsController::main`` call ``UserElementsController::main_user`` instead
+``UserElementsController::printContent`` call ``UserElementsController::mainAction`` instead
+``ParseHtmlController::main`` call ``ParseHtmlController::main_parse_html`` instead
+``ParseHtmlController::printContent`` call ``ParseHtmlController::mainAction`` instead
\ No newline at end of file
index 42ec08a..00414fd 100644 (file)
@@ -98,31 +98,6 @@ class ParseHtmlController
     }
 
     /**
-     * Main function
-     *
-     * @return void
-     * @deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8, use main_parse_html() instead
-     */
-    public function main()
-    {
-        GeneralUtility::logDeprecatedFunction();
-        $this->content .= $this->main_parse_html($this->modData['openKeys']);
-        header('Content-Type: text/plain; charset=utf-8');
-    }
-
-    /**
-     * Print content
-     *
-     * @return void
-     * @deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8, use mainAction() instead
-     */
-    public function printContent()
-    {
-        GeneralUtility::logDeprecatedFunction();
-        echo $this->content;
-    }
-
-    /**
      * Rich Text Editor (RTE) html parser
      *
      * @param array $openKeys Unused
index 9a8863f..efad84d 100644 (file)
@@ -136,31 +136,6 @@ class UserElementsController
         return $response;
     }
 
-    /**
-     * Main function
-     *
-     * @return void
-     * @deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8, use main_user() instead
-     */
-    public function main()
-    {
-        GeneralUtility::logDeprecatedFunction();
-        $this->content = '';
-        $this->content .= $this->main_user($this->modData['openKeys']);
-    }
-
-    /**
-     * Print content
-     *
-     * @return void
-     * @deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8, use mainAction() instead
-     */
-    public function printContent()
-    {
-        GeneralUtility::logDeprecatedFunction();
-        echo $this->content;
-    }
-
     /********************************
      *
      * Other functions
index 640bd1a..aa1d0c2 100644 (file)
@@ -40,26 +40,6 @@ define(function () {
                labels: {},
 
                /**
-                * Initialize an event handler for dropping an image in WebKit browsers
-                *
-                * @return void
-         * @deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8
-                */
-               initEventListeners: function() {
-                       if (typeof console !== 'undefined') {
-                               console.log('SelectImage.initEventListeners() is deprecated since TYPO3 CMS 7, will be removed in TYPO3 CMS 8');
-                       }
-                       require(
-                               ['TYPO3/CMS/Rtehtmlarea/HTMLArea/UserAgent/UserAgent', 'TYPO3/CMS/Rtehtmlarea/HTMLArea/Event/Event'],
-                               function (UserAgent, Event) {
-                                       if (UserAgent.isWebKit) {
-                                               Event.one(window.document.body, 'dragend.TYPO3Image', function (event) { SelectImage.Plugin.get().onDrop(event); });
-                                       }
-                               }
-                       );
-               },
-
-               /**
                 * Jump to the specified url after adding some parameters specific to the RTE context
                 *
                 * @return bool