[!!!][TASK] Remove database fields related to CSS Styled Content 86/61286/3
authorBenni Mack <benni@typo3.org>
Sat, 13 Jul 2019 16:29:51 +0000 (18:29 +0200)
committerFrank Naegler <frank.naegler@typo3.org>
Mon, 15 Jul 2019 09:50:55 +0000 (11:50 +0200)
The following database fields from "tt_content" have been removed:

* tt_content.spaceBefore (now used via space_before_class)
* tt_content.spaceAfter (now used via space_after_class)

Resolves: #88744
Releases: master
Change-Id: I2da1645b94b68fadb2945c2f1708809e2e9cbab4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61286
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
typo3/sysext/core/Classes/Database/QueryGenerator.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-88744-DatabaseFieldsRelatedToCSSStyledContentRemoved.rst [new file with mode: 0644]
typo3/sysext/frontend/Resources/Private/Language/locallang_csh_ttcontent.xlf
typo3/sysext/frontend/Resources/Private/Language/locallang_ttc.xlf
typo3/sysext/frontend/ext_tables.sql
typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js

index 78742c2..de967a1 100644 (file)
@@ -372,7 +372,7 @@ class QueryGenerator
         $this->queryConfig = array(
         array(
         'operator' => 'AND',
-        'type' => 'FIELD_spaceBefore',
+        'type' => 'FIELD_space_before_class',
         ),
         array(
         'operator' => 'AND',
@@ -385,7 +385,7 @@ class QueryGenerator
         'nl' => array(
         array(
         'operator' => 'AND',
-        'type' => 'FIELD_spaceBefore',
+        'type' => 'FIELD_space_before_class',
         'negate' => 1,
         'inputValue' => 'foo foo'
         ),
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-88744-DatabaseFieldsRelatedToCSSStyledContentRemoved.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-88744-DatabaseFieldsRelatedToCSSStyledContentRemoved.rst
new file mode 100644 (file)
index 0000000..3b94db1
--- /dev/null
@@ -0,0 +1,47 @@
+.. include:: ../../Includes.txt
+
+========================================================================
+Breaking: #88744 - Database fields related to CSS Styled Content removed
+========================================================================
+
+See :issue:`88744`
+
+Description
+===========
+
+CSS Styled Content was superseded with Fluid Styled Content in TYPO3 v7, and support was dropped
+with TYPO3 v9. However, TYPO3 Core still shipped with some database fields that were kept to easy
+manual migration for specific values in these fields.
+
+These database fields within the database table `tt_content` have been removed.
+
+* tt_content.spaceBefore (now used via space_before_class)
+* tt_content.spaceAfter (now used via space_after_class)
+
+
+Impact
+======
+
+Accessing the database fields with a custom SQL query will result in SQL errors, or empty values.
+
+
+Affected Installations
+======================
+
+TYPO3 installations from earlier TYPO3 versions (prior to v8) that still have CSS Styled Content
+in use or adopted to migrate the fields to still render via CSS Styled Content.
+
+Additionally, TYPO3 installations that mis-used the database fields for other purposes but
+still rely on the presence of the database fields.
+
+
+Migration
+=========
+
+If the database fields still contain value that hasn't been migrated, it is possible to re-add
+these database fields in a custom extension.
+
+It is recommended to switch to Fluid Styled Content rendering or custom content types with
+custom additional fields.
+
+.. index:: Database, Frontend, NotScanned, ext:frontend
\ No newline at end of file
index 30de204..f44d692 100644 (file)
@@ -473,20 +473,6 @@ tt_content:sectionIndex</source>
                        <trans-unit id="records.description">
                                <source>Insert records to be displayed on this page.</source>
                        </trans-unit>
-                       <trans-unit id="spaceBefore.description">
-                               <source>Top Margin (in pixels) inserts whitespace &lt;em&gt;before&lt;/em&gt; this Content Element.</source>
-                       </trans-unit>
-                       <trans-unit id="_spaceBefore.seeAlso" xml:space="preserve">
-                               <source>tt_content:spaceAfter</source>
-                               <note from="developer">This string contains an internal text, which must not be changed. Just copy the original text into the translation field. For more information have a look at the Tutorial.</note>
-                       </trans-unit>
-                       <trans-unit id="spaceAfter.description">
-                               <source>Bottom Margin (in pixels) inserts whitespace &lt;em&gt;after&lt;/em&gt; this Content Element.</source>
-                       </trans-unit>
-                       <trans-unit id="_spaceAfter.seeAlso" xml:space="preserve">
-                               <source>tt_content:spaceBefore</source>
-                               <note from="developer">This string contains an internal text, which must not be changed. Just copy the original text into the translation field. For more information have a look at the Tutorial.</note>
-                       </trans-unit>
                        <trans-unit id="sectionIndex.description">
                                <source>If set, the Content Element will appear in Section Menus.</source>
                        </trans-unit>
index 04e7519..671b1b2 100644 (file)
                        <trans-unit id="records_formlabel">
                                <source>Records</source>
                        </trans-unit>
-                       <trans-unit id="spaceBefore">
-                               <source>Before</source>
-                       </trans-unit>
-                       <trans-unit id="spaceBefore_formlabel">
-                               <source>Top Margin</source>
-                       </trans-unit>
-                       <trans-unit id="spaceAfter">
-                               <source>After</source>
-                       </trans-unit>
-                       <trans-unit id="spaceAfter_formlabel">
-                               <source>Bottom Margin</source>
-                       </trans-unit>
                        <trans-unit id="space_before_class">
                                <source>Space Before</source>
                        </trans-unit>
index c9e6cc7..1838773 100644 (file)
@@ -111,8 +111,6 @@ CREATE TABLE tt_content (
        layout int(11) unsigned DEFAULT '0' NOT NULL,
        frame_class varchar(60) DEFAULT 'default' NOT NULL,
        cols int(11) unsigned DEFAULT '0' NOT NULL,
-       spaceBefore smallint(5) unsigned DEFAULT '0' NOT NULL,
-       spaceAfter smallint(5) unsigned DEFAULT '0' NOT NULL,
        space_before_class varchar(60) DEFAULT '' NOT NULL,
        space_after_class varchar(60) DEFAULT '' NOT NULL,
        records text,
index e974cf0..3e447d2 100644 (file)
         'sorting': kw('sorting'),
         'source': kw('source'),
         'space': kw('space'),
-        'spaceAfter': kw('spaceAfter'),
-        'spaceBefore': kw('spaceBefore'),
         'spaceBelowAbove': kw('spaceBelowAbove'),
         'spaceLeft': kw('spaceLeft'),
         'spaceRight': kw('spaceRight'),