[BUGFIX] Fix assertion in Local Driver Test 41/51741/2
authorSascha Egerer <sascha@sascha-egerer.de>
Sat, 18 Feb 2017 14:44:25 +0000 (15:44 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 18 Feb 2017 18:41:24 +0000 (19:41 +0100)
There are 2 places in the local driver test where a
true assertion is expected. But instead of the correct usage
of `assertTrue()` the method `isTrue()` is being used which
does no assertion.

Resolves: #79891
Releases: master
Change-Id: I68f5e43cb1011dd7aadd2c67479d64810ef88bf3
Reviewed-on: https://review.typo3.org/51741
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php

index c9cc274..24481d5 100644 (file)
@@ -1277,7 +1277,7 @@ class LocalDriverTest extends \TYPO3\CMS\Core\Tests\Unit\Resource\BaseTestCase
         ]);
         $subject = $this->createDriver();
         $mappingInformation = $subject->renameFolder('/sourceFolder/', 'newFolder');
-        $this->isTrue(is_array($mappingInformation));
+        $this->assertTrue(is_array($mappingInformation));
         $this->assertEquals('/newFolder/', $mappingInformation['/sourceFolder/']);
         $this->assertEquals('/newFolder/file2', $mappingInformation['/sourceFolder/file2']);
         $this->assertEquals('/newFolder/subFolder/file', $mappingInformation['/sourceFolder/subFolder/file']);
@@ -1433,7 +1433,7 @@ class LocalDriverTest extends \TYPO3\CMS\Core\Tests\Unit\Resource\BaseTestCase
         GeneralUtility::mkdir_deep($basePath, '/targetFolder');
 
         $subject->copyFolderWithinStorage('/sourceFolder/', '/targetFolder/', 'newFolderName');
-        $this->isTrue(is_dir($basePath . '/targetFolder/newFolderName/subFolder'));
+        $this->assertTrue(is_dir($basePath . '/targetFolder/newFolderName/subFolder'));
     }
 
     /**