[CLEANUP] Minor argument and comment cleanup 24/54524/2
authorBenni Mack <benni@typo3.org>
Thu, 2 Nov 2017 06:16:55 +0000 (07:16 +0100)
committerSusanne Moog <susanne.moog@typo3.org>
Thu, 2 Nov 2017 09:46:21 +0000 (10:46 +0100)
Some methods are called with default arguments, which can be omitted
when calling the methods.

Additionally, some PHPdoc comments was wrongly defined, which were
modified.

No change of behaviour.

Resolves: #82897
Releases: master
Change-Id: I1a22e7e3c4aff74f32c67bacb406a6a97d96b0d0
Reviewed-on: https://review.typo3.org/54524
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageContent.php
typo3/sysext/backend/Classes/Template/Components/MetaInformation.php
typo3/sysext/backend/Classes/Template/DocumentTemplate.php
typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php
typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
typo3/sysext/indexed_search/Classes/Controller/SearchController.php

index ae8c471..a3126d6 100644 (file)
@@ -141,7 +141,7 @@ class OtherLanguageContent extends AbstractNode
                         0,
                         ' align="middle"'
                     ) .
-                    ($absFilePath ? BackendUtility::wrapClickMenuOnIcon($fileIcon, $absFilePath, 0) : $fileIcon) .
+                    ($absFilePath ? BackendUtility::wrapClickMenuOnIcon($fileIcon, $absFilePath) : $fileIcon) .
                     $imgPath .
                     '</span>';
             }
index 3159046..7158849 100644 (file)
@@ -213,7 +213,7 @@ class MetaInformation
                 '">' .
                 $iconFactory->getIcon('apps-pagetree-root', Icon::SIZE_SMALL)->render() . '</span>';
             if ($this->getBackendUser()->isAdmin()) {
-                $theIcon = BackendUtility::wrapClickMenuOnIcon($iconImg, 'pages', 0);
+                $theIcon = BackendUtility::wrapClickMenuOnIcon($iconImg, 'pages');
             } else {
                 $theIcon = $iconImg;
             }
index d07753a..39b7b36 100644 (file)
@@ -937,7 +937,7 @@ function jumpToUrl(URL) {
             // Make Icon
             $iconImg = '<span title="' . htmlspecialchars($GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename']) . '">' . $this->iconFactory->getIcon('apps-pagetree-root', Icon::SIZE_SMALL)->render() . '</span>';
             if ($GLOBALS['BE_USER']->isAdmin()) {
-                $theIcon = BackendUtility::wrapClickMenuOnIcon($iconImg, 'pages', 0);
+                $theIcon = BackendUtility::wrapClickMenuOnIcon($iconImg, 'pages');
             } else {
                 $theIcon = $iconImg;
             }
index 3aaa007..16941ea 100644 (file)
@@ -86,7 +86,7 @@ class PageInfoViewHelper extends AbstractBackendViewHelper
             // Make Icon
             $theIcon = '<span title="' . htmlspecialchars($GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename']) . '">' . $iconFactory->getIcon('apps-pagetree-page-domain', Icon::SIZE_SMALL)->render() . '</span>';
             if ($GLOBALS['BE_USER']->isAdmin()) {
-                $theIcon = BackendUtility::wrapClickMenuOnIcon($theIcon, 'pages', 0);
+                $theIcon = BackendUtility::wrapClickMenuOnIcon($theIcon, 'pages');
             }
         }
         return $theIcon;
index d1256cf..5a00f88 100644 (file)
@@ -5745,7 +5745,7 @@ class ContentObjectRenderer
      * Gets the query arguments and assembles them for URLs.
      * Arguments may be removed or set, depending on configuration.
      *
-     * @param string $conf Configuration
+     * @param array $conf Configuration
      * @param array $overruleQueryArguments Multidimensional key/value pairs that overrule incoming query arguments
      * @param bool $forceOverruleArguments If set, key/value pairs not in the query but the overrule array will be set
      * @return string The URL query part (starting with a &)
index 04952bd..3630154 100644 (file)
@@ -353,7 +353,7 @@ class SearchController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionControlle
      *
      * @param array $resultRows Result rows
      * @param int $freeIndexUid Pointing to which indexing configuration you want to search in. -1 means no filtering. 0 means only regular indexed content.
-     * @return string HTML
+     * @return array the result rows with additional information
      */
     protected function compileResultRows($resultRows, $freeIndexUid = -1)
     {
@@ -438,7 +438,7 @@ class SearchController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionControlle
      *
      * @param array $row Search result row
      * @param int $headerOnly 1=Display only header (for sub-rows!), 2=nothing at all
-     * @return string HTML code
+     * @return array the result row with additional information
      */
     protected function compileSingleResultRow($row, $headerOnly = 0)
     {
@@ -798,7 +798,7 @@ class SearchController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionControlle
      * @param array $searchParams search params
      * @param array $searchWords Search Word array
      * @param int $count Number of hits
-     * @param int $pt Milliseconds the search took
+     * @param array $pt Milliseconds the search took (start time DB query + end time DB query + end time to compile results)
      */
     protected function writeSearchStat($searchParams, $searchWords, $count, $pt)
     {