[BUGFIX] RTE: Enable dialogue window resizing in IE
authorStanislas Rolland <typo3@sjbr.ca>
Wed, 4 Jul 2012 02:06:48 +0000 (22:06 -0400)
committerStanislas Rolland <typo3@sjbr.ca>
Wed, 4 Jul 2012 02:11:29 +0000 (04:11 +0200)
Problem: There was a bug in ExtJS 3.1 that produced a JavaScript
error when a window object was configured as resizable.
Solution: Apparently, this is fixed in ExtJS 3.4, at least in IE and
compatibility modes IE8/IE7.

Change-Id: Icdf93aa61c8b53f4a2a3d4c00db1969cedf2194e
Releases: 4.7, 6.0
Resolves: #38617
Reviewed-on: http://review.typo3.org/12562
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
14 files changed:
typo3/sysext/rtehtmlarea/htmlarea/htmlarea.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/AboutEditor/about-editor.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/Acronym/acronym.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/CharacterMap/character-map.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/DefaultImage/default-image.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/DefaultLink/default-link.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/EditElement/edit-element.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/FindReplace/find-replace.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/InsertSmiley/insert-smiley.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/PlainText/plain-text.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/RemoveFormat/remove-format.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/SpellChecker/spell-checker.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/TYPO3Color/typo3color.js
typo3/sysext/rtehtmlarea/htmlarea/plugins/TableOperations/table-operations.js

index 7e8e6aa..fcd7d27 100644 (file)
@@ -6283,7 +6283,6 @@ HTMLArea.Plugin = Ext.extend(HTMLArea.Plugin, {
                        cls: 'htmlarea-window',
                        width: dimensions.width,
                        border: false,
-                       resizable: true,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                afterrender: {
index e45b28c..610fe6c 100644 (file)
@@ -110,8 +110,6 @@ HTMLArea.AboutEditor = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index cf98b3a..87320bb 100644 (file)
@@ -128,8 +128,6 @@ HTMLArea.Acronym = Ext.extend(HTMLArea.Plugin, {
                this.dialog = new Ext.Window({
                        title: this.getHelpTip('', title),
                        cls: 'htmlarea-window',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
index 141eb0e..6d6473b 100644 (file)
@@ -387,8 +387,6 @@ HTMLArea.CharacterMap = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index 068de83..3a65dc2 100644 (file)
@@ -179,8 +179,6 @@ HTMLArea.DefaultImage = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index c3c6d75..a5a702a 100644 (file)
@@ -175,8 +175,6 @@ HTMLArea.DefaultLink = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                afterrender: {
index efd6767..a999803 100644 (file)
@@ -129,8 +129,6 @@ HTMLArea.EditElement = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index 0055d93..508bae9 100644 (file)
@@ -122,8 +122,6 @@ HTMLArea.FindReplace = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index 91cb6cf..f046e0d 100644 (file)
@@ -102,8 +102,6 @@ HTMLArea.InsertSmiley = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index 02408c1..bec8a32 100644 (file)
@@ -389,8 +389,6 @@ HTMLArea.PlainText = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                afterrender: {
index 7c443cd..2726843 100644 (file)
@@ -102,8 +102,6 @@ HTMLArea.RemoveFormat = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                close: {
index 3db138d..3c22a8e 100644 (file)
@@ -129,8 +129,6 @@ HTMLArea.SpellChecker = Ext.extend(HTMLArea.Plugin, {
                        border: false,
                        width: dimensions.width,
                        height: Ext.isIE ? dimensions.height - 50 : 'auto',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(buttonId).iconCls,
                        listeners: {
                                afterrender: {
index e167871..a16018c 100644 (file)
@@ -314,8 +314,6 @@ HTMLArea.TYPO3Color = Ext.extend(HTMLArea.Plugin, {
                        width: dimensions.width,
                        height: dimensions.height,
                        autoScroll: true,
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        iconCls: this.getButton(arguments.buttonId).iconCls,
                        listeners: {
                                close: {
index c4d0265..37935e7 100644 (file)
@@ -314,8 +314,6 @@ HTMLArea.TableOperations = Ext.extend(HTMLArea.Plugin, {
                        title: this.getHelpTip(arguments.buttonId, title),
                        arguments: arguments,
                        cls: 'htmlarea-window',
-                               // As of ExtJS 3.1, JS error with IE when the window is resizable
-                       resizable: !Ext.isIE,
                        border: false,
                        width: dimensions.width,
                        height: 'auto',