[BUGFIX] Disable autocompletion in installation options 51/61451/2
authorAndreas Fernandez <a.fernandez@scripting-base.de>
Wed, 7 Aug 2019 09:25:00 +0000 (11:25 +0200)
committerFrank Naegler <frank.naegler@typo3.org>
Thu, 8 Aug 2019 07:46:08 +0000 (09:46 +0200)
Since Chrome is really picky about having autocomplete disabled, this
patch sets the autocomplete configuration for password fields to
`new-password` used in "Configure Installation-Wide Options". This is a
proposed workaround mentioned at MDN:

  https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#Preventing_autofilling_with_autocompletenew-password

Resolves: #88832
Resolves: #88851
Releases: master, 9.5
Change-Id: Iddabbb16e91b7ef66f97be1d63e15e96d971441b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61451
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html

index d94ed89..6659710 100644 (file)
@@ -86,7 +86,7 @@
                                         value="{item.value}"
                                         data-path="{sectionName}/{item.key}"
                                         class="t3-install-form-input-text form-control t3js-localConfiguration-pathValue"
-                                        autocomplete="off"
+                                        autocomplete="new-password"
                                     />
                                 </div>
                             </f:if>