[TASK] Use labels and modal in Site module 21/58121/4
authorGeorg Ringer <georg.ringer@gmail.com>
Sun, 2 Sep 2018 10:20:21 +0000 (12:20 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Sun, 2 Sep 2018 10:57:01 +0000 (12:57 +0200)
Use labels instead of hardcoded text and a modal
asking users if a site configuration should be really deleted.

Resolves: #86078
Releases: master
Change-Id: I49de820ef5e48f88c6449872cfee2eca617c46eb
Reviewed-on: https://review.typo3.org/58121
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf
typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html

index e3b79b8..6e1a23a 100644 (file)
@@ -27,6 +27,9 @@
                        <trans-unit id="overview.deleteSiteConfiguration">
                                <source>Delete site configuration</source>
                        </trans-unit>
+                       <trans-unit id="overview.fullUrlPrefix">
+                               <source>Full URL prefix</source>
+                       </trans-unit>
                        <trans-unit id="overview.baseUrl">
                                <source>Base URLs</source>
                        </trans-unit>
index 4145c41..1e2338c 100644 (file)
@@ -28,7 +28,7 @@
                                                                                <a href="#" class="t3js-contextmenutrigger" data-table="pages" data-uid="{rootLinePage.uid}">
                                                                                        <core:iconForRecord table="pages" row="{rootLinePage}" />
                                                                                </a>
-                                                                               <f:be.link route="site_configuration" parameters="{action: 'edit', site: page.siteIdentifier}" title="Edit">
+                                                                               <f:be.link route="site_configuration" parameters="{action: 'edit', site: page.siteIdentifier}" title="{f:translate(key:'LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:edit')}">
                                                                                        {rootLinePage.title} [ID: {page.uid}]
                                                                                </f:be.link>
                                                                        </f:then>
@@ -57,8 +57,8 @@
                                                        <f:if condition="{page.siteConfiguration}">
                                                                <table class="table table-striped table-no-borders">
                                                                        <tr>
-                                                                               <th>Language</th>
-                                                                               <th>Full URL Prefix</th>
+                                                                               <th>{f:translate(key:'LLL:EXT:backend/Resources/Private/Language/locallang_siteconfiguration_tca.xlf:site_language.language')}</th>
+                                                                               <th>{f:translate(key:'LLL:EXT:backend/Resources/Private/Language/locallang_siteconfiguration.xlf:overview.fullUrlPrefix')}</th>
                                                                        </tr>
                                                                <f:for each="{page.siteConfiguration.allLanguages}" as="siteLanguage">
                                                                        <tr>
                                                <td>
                                                        <div class="btn-group">
                                                                <f:if condition="{page.siteIdentifier}">
-                                                                       <f:be.link route="site_configuration" parameters="{action: 'edit', site: page.siteIdentifier}" title="Edit" class="btn btn-default">
+                                                                       <f:be.link route="site_configuration" parameters="{action: 'edit', site: page.siteIdentifier}" title="{f:translate(key:'LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:edit')}" class="btn btn-default">
                                                                                <core:icon identifier="actions-open" />
                                                                        </f:be.link>
-                                                                       <f:be.link route="site_configuration" parameters="{action: 'delete', site:page.siteIdentifier}" title="Delete configuration" class="btn btn-default">
+                                                                       <f:be.link
+                                                                               route="site_configuration"
+                                                                               parameters="{action: 'delete', site:page.siteIdentifier}"
+                                                                               class="btn btn-default t3js-modal-trigger"
+                                                                               title="{f:translate(key:'LLL:EXT:backend/Resources/Private/Language/locallang_siteconfiguration.xlf:overview.deleteSiteConfiguration')}"
+                                                                               data="{
+                                                                                       severity: 'error',
+                                                                                       title: '{f:translate(key:\'LLL:EXT:backend/Resources/Private/Language/locallang_siteconfiguration.xlf:overview.deleteSiteConfiguration\')}',
+                                                                                       button-ok-text: '{f:translate(key:\'LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:delete\')}'
+                                                                               }"
+                                                                       >
                                                                                <core:icon identifier="actions-delete" />
                                                                        </f:be.link>
                                                                </f:if>