[TASK] ext:adodb Remove obsolete diffs from doc/ 58/25758/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Fri, 29 Nov 2013 12:53:58 +0000 (13:53 +0100)
committerHelmut Hummel <helmut.hummel@typo3.org>
Fri, 29 Nov 2013 13:10:36 +0000 (14:10 +0100)
Remove some ancient and obsolete patch files from ext:adodb/doc.

Change-Id: Ib2183abb3358de8b4d7e1dad71731b1df96a9a80
Fixes: #54078
Releases: 6.2
Reviewed-on: https://review.typo3.org/25758
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Franz G. Jahn
Tested-by: Franz G. Jahn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
typo3/sysext/adodb/doc/510.DBAL.patch [deleted file]
typo3/sysext/adodb/doc/README [deleted file]
typo3/sysext/adodb/doc/mssql-error-fix.patch [deleted file]

diff --git a/typo3/sysext/adodb/doc/510.DBAL.patch b/typo3/sysext/adodb/doc/510.DBAL.patch
deleted file mode 100644 (file)
index 5a3bb24..0000000
+++ /dev/null
@@ -1,87 +0,0 @@
-diff -urN adodb508a/adodb-lib.inc.php adodb/adodb-lib.inc.php
---- adodb510/adodb-lib.inc.php 2009-05-16 00:45:10.000000000 +0200
-+++ adodb/adodb-lib.inc.php    2009-05-16 00:45:17.000000000 +0200
-@@ -886,7 +886,7 @@
-       $values = substr($values, 0, -2);
-       // Append the fields and their values to the insert query.
--      return 'INSERT INTO '.$tableName.' ( '.$fields.' ) VALUES ( '.$values.' )';
-+      return 'INSERT INTO '.$zthis->nameQuote.$tableName.$zthis->nameQuote.' ( '.$fields.' ) VALUES ( '.$values.' )';
- }
-diff -urN adodb510/datadict/datadict-oci8.inc.php adodb/datadict/datadict-oci8.inc.php
---- adodb510/datadict/datadict-oci8.inc.php    2009-05-16 00:45:10.000000000 +0200
-+++ adodb/datadict/datadict-oci8.inc.php       2009-05-16 00:45:17.000000000 +0200
-@@ -110,6 +110,7 @@
-       
-       function AddColumnSQL($tabname, $flds)
-       {
-+              $tabname = $this->TableName ($tabname);
-               $f = array();
-               list($lines,$pkey) = $this->_GenFields($flds);
-               $s = "ALTER TABLE $tabname ADD (";
-@@ -124,6 +125,7 @@
-       
-       function AlterColumnSQL($tabname, $flds)
-       {
-+              $tabname = $this->TableName ($tabname);
-               $f = array();
-               list($lines,$pkey) = $this->_GenFields($flds);
-               $s = "ALTER TABLE $tabname MODIFY(";
-@@ -137,6 +139,7 @@
-       
-       function DropColumnSQL($tabname, $flds)
-       {
-+              $tabname = $this->TableName ($tabname);
-               if (!is_array($flds)) $flds = explode(',',$flds);
-               foreach ($flds as $k => $v) $flds[$k] = $this->NameQuote($v);
-               
-@@ -260,9 +263,9 @@
-               }
-               
-               if ( is_array($flds) )
--                      $flds = implode(', ',$flds);
--              $s = 'CREATE' . $unique . ' INDEX ' . $idxname . ' ON ' . $tabname . ' (' . $flds . ')';
--              
-+                      $flds = implode('", "',$flds);
-+              $s = 'CREATE' . $unique . ' INDEX "' . $idxname . '" ON "' .$tabname . '" ("' . $flds . '")';
-+
-               if ( isset($idxoptions[$this->upperName]) )
-                       $s .= $idxoptions[$this->upperName];
-               
-diff -urN adodb510/datadict/datadict-postgres.inc.php adodb/datadict/datadict-postgres.inc.php
---- adodb510/datadict/datadict-postgres.inc.php        2009-05-16 00:45:10.000000000 +0200
-+++ adodb/datadict/datadict-postgres.inc.php   2009-05-16 00:45:17.000000000 +0200
-@@ -418,7 +418,7 @@
-               
-               $unique = isset($idxoptions['UNIQUE']) ? ' UNIQUE' : '';
-               
--              $s = 'CREATE' . $unique . ' INDEX ' . $idxname . ' ON ' . $tabname . ' ';
-+              $s = 'CREATE' . $unique . ' INDEX "' . $idxname . '" ON "' . $tabname . '" ';
-               
-               if (isset($idxoptions['HASH']))
-                       $s .= 'USING HASH ';
-@@ -427,8 +427,8 @@
-                       $s .= $idxoptions[$this->upperName];
-               
-               if ( is_array($flds) )
--                      $flds = implode(', ',$flds);
--              $s .= '(' . $flds . ')';
-+                      $flds = implode('", "',$flds);
-+              $s .= '("' . $flds . '")';
-               $sql[] = $s;
-               
-               return $sql;
-diff -urN adodb510/drivers/adodb-oci8.inc.php adodb/drivers/adodb-oci8.inc.php
---- adodb510/drivers/adodb-oci8.inc.php        2009-05-16 00:45:11.000000000 +0200
-+++ adodb/drivers/adodb-oci8.inc.php   2009-05-16 00:45:17.000000000 +0200
-@@ -106,7 +106,7 @@
-               $ADODB_FETCH_MODE = ADODB_FETCH_NUM;
-               if ($this->fetchMode !== false) $savem = $this->SetFetchMode(false);
-               
--              $rs = $this->Execute(sprintf($this->metaColumnsSQL,strtoupper($table)));
-+              $rs = $this->Execute(sprintf($this->metaColumnsSQL,$table));
-               
-               if (isset($savem)) $this->SetFetchMode($savem);
-               $ADODB_FETCH_MODE = $save;
diff --git a/typo3/sysext/adodb/doc/README b/typo3/sysext/adodb/doc/README
deleted file mode 100644 (file)
index 695e90d..0000000
+++ /dev/null
@@ -1,13 +0,0 @@
-This folder contains the patches that have been applied to the vanilla
-release of ADOdb before it has been packaged in this extension.
-
-The changes aren't as clean as they should be, but are needed for the
-DBAL extension that relies on this extension to be present. Most
-other code using this ADOdb library won't notice the changes done.
-
-There is a specific patch for use with DBAL on MS SQL Server here,
-why is it listed separately? This is due to the fact, that we do not fully
-know whether the fixed behaviour is caused by the DB itself or maybe
-the connection method used when testing.
-
-Karsten Dambekalns
diff --git a/typo3/sysext/adodb/doc/mssql-error-fix.patch b/typo3/sysext/adodb/doc/mssql-error-fix.patch
deleted file mode 100644 (file)
index 3d4bd88..0000000
+++ /dev/null
@@ -1,27 +0,0 @@
-diff -urw adodb5/drivers/adodb-odbc.inc.php adodb/drivers/adodb-odbc.inc.php
---- adodb5/drivers/adodb-odbc.inc.php  2006-05-03 09:42:44.000000000 +0200
-+++ adodb/drivers/adodb-odbc.inc.php   2006-05-15 13:52:08.000000000 +0200
-@@ -513,6 +513,11 @@
-                                       $this->_errorMsg = odbc_errormsg();
-                                       $this->_errorCode = odbc_error();
-                               }
-+                              if($this->_errorCode == '00000') {      // MS SQL Server sometimes returns this in combination with the FreeTDS
-+                                      $this->_errorMsg = '';          // driver and UnixODBC under Linux. This fixes the bogus "error"
-+                                      $this->_errorCode = 0;          // <karsten@typo3.org>
-+                                      return true;
-+                              }
-                               return false;
-                       }
-               
-@@ -524,6 +529,11 @@
-                                       $this->_errorMsg = odbc_errormsg();
-                                       $this->_errorCode = odbc_error();
-                               }
-+                              if($this->_errorCode == '00000') {      // MS SQL Server sometimes returns this in combination with the FreeTDS
-+                                      $this->_errorMsg = '';          // driver and UnixODBC under Linux. This fixes the bogus "error"
-+                                      $this->_errorCode = 0;          // <karsten@typo3.org>
-+                                      return true;
-+                              }
-                               return false;
-                       }
-               } else