[BUGFIX] Workspaces module: Add h1 headline with page title 89/34789/3
authorBenjamin Mack <benni@typo3.org>
Sat, 29 Nov 2014 23:48:58 +0000 (00:48 +0100)
committerFrank Nägler <typo3@naegler.net>
Sun, 30 Nov 2014 00:21:54 +0000 (01:21 +0100)
In order to be consistent with the
other Web modules, the workspace
module should output the page title as
h1.

Resolves: #63209
Releases: master
Change-Id: Iac6cf837f8fee60feafa8f6e5bd34a8968b70a5c
Reviewed-on: http://review.typo3.org/34789
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
typo3/sysext/workspaces/Classes/Controller/ReviewController.php
typo3/sysext/workspaces/Resources/Private/Layouts/Module.html

index b0d91a9..f54247f 100644 (file)
@@ -36,6 +36,10 @@ class ReviewController extends AbstractController {
                $this->view->assign('showGrid', !($GLOBALS['BE_USER']->workspace === 0 && !$GLOBALS['BE_USER']->isAdmin()));
                $this->view->assign('showAllWorkspaceTab', TRUE);
                $this->view->assign('pageUid', GeneralUtility::_GP('id'));
+               if (GeneralUtility::_GP('id')) {
+                       $pageRecord = BackendUtility::getRecord('pages', GeneralUtility::_GP('id'));
+                       $this->view->assign('pageTitle', BackendUtility::getRecordTitle('pages', $pageRecord));
+               }
                $this->view->assign('showLegend', !($GLOBALS['BE_USER']->workspace === 0 && !$GLOBALS['BE_USER']->isAdmin()));
                $wsList = $wsService->getAvailableWorkspaces();
                $activeWorkspace = $GLOBALS['BE_USER']->workspace;
index 6cf2882..902cc35 100644 (file)
@@ -25,6 +25,7 @@
 
 <div id="typo3-docbody">
        <div id="typo3-inner-docbody">
+               <f:if condition="{pageTitle}"><h1>{pageTitle}</h1></f:if>
                <f:flashMessages renderMode="div" />
                <div id="workspacetabs"></div>
                <div class="typo3-dyntabmenu-divs"><f:render section="main" /></div>