[TASK] Remove tabs_images for module groups 93/21193/3
authorFelix Kopp <felix-source@phorax.com>
Sun, 2 Jun 2013 18:01:09 +0000 (20:01 +0200)
committerFelix Kopp <felix-source@phorax.com>
Sun, 2 Jun 2013 19:27:27 +0000 (21:27 +0200)
Backend Modules are mostly recognized by their icons. Those
modules are accessed via the module menu on the left.
Modules are grouped into module groups.

Since module groups are defined the same way as
sub-modules are - also module *groups* have icons.

Those icons are not displayed widely and not maintained.
Because these module -group- icons do not bring benefits:

This patch removes tabs_images from module groups.

Change-Id: I1a1de5d1fa8899c362dcf1d2c592ec85cf32e59b
Resolves: #48774
Releases: 6.2
Reviewed-on: https://review.typo3.org/21193
Reviewed-by: Soren Malling
Tested-by: Soren Malling
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
18 files changed:
typo3/mod/README.txt [deleted file]
typo3/mod/file/conf.php
typo3/mod/file/file.gif [deleted file]
typo3/mod/help/clear.gif [deleted file]
typo3/mod/help/conf.php
typo3/mod/help/help.gif [deleted file]
typo3/mod/tools/clear.gif [deleted file]
typo3/mod/tools/conf.php
typo3/mod/tools/note.txt [deleted file]
typo3/mod/tools/tool.gif [deleted file]
typo3/mod/user/clear.gif [deleted file]
typo3/mod/user/conf.php
typo3/mod/user/user.gif [deleted file]
typo3/mod/web/clear.gif [deleted file]
typo3/mod/web/conf.php
typo3/mod/web/website.gif [deleted file]
typo3/sysext/aboutmodules/Classes/Controller/ModulesController.php
typo3/sysext/aboutmodules/Resources/Private/Templates/Modules/Index.html

diff --git a/typo3/mod/README.txt b/typo3/mod/README.txt
deleted file mode 100755 (executable)
index 18e3660..0000000
+++ /dev/null
@@ -1,9 +0,0 @@
-typo3/mod/
-
-TYPO3 modules, old repository.
-The history of this directory is that it contained all the modules which belongs to the core. 
-When the extension manager came, most of the modules were moved out from here and into extensions.
-You will still find a few modules here, such as the Extension Manager and Web>Access module.
-Further, other core modules may be configured in here. One of them is the "Web>List" module which has its main code positioned in typo3/db_list.php (for historical reasons).
-
-Generally, this directory is not expanded with new stuff anymore. All modules developed today are created in extensions.
index d56d532..c2e3e71 100755 (executable)
@@ -1,5 +1,4 @@
 <?php
-$MLANG['default']['tabs_images']['tab'] = 'file.gif';
 $MLANG['default']['ll_ref'] = 'LLL:EXT:lang/locallang_mod_file.xlf';
 $MCONF['navFrameScript'] = '../../alt_file_navframe.php';
 $MCONF['access'] = 'group,user';
diff --git a/typo3/mod/file/file.gif b/typo3/mod/file/file.gif
deleted file mode 100755 (executable)
index 1133e37..0000000
Binary files a/typo3/mod/file/file.gif and /dev/null differ
diff --git a/typo3/mod/help/clear.gif b/typo3/mod/help/clear.gif
deleted file mode 100755 (executable)
index 9ed1269..0000000
Binary files a/typo3/mod/help/clear.gif and /dev/null differ
index 0b918f8..ead0c1e 100755 (executable)
@@ -1,5 +1,4 @@
 <?php
-$MLANG['default']['tabs_images']['tab'] = 'help.gif';
 $MLANG['default']['ll_ref'] = 'LLL:EXT:lang/locallang_mod_help.xlf';
 $MCONF['defaultMod'] = 'welcome';
 $MCONF['name'] = 'help';
diff --git a/typo3/mod/help/help.gif b/typo3/mod/help/help.gif
deleted file mode 100755 (executable)
index aec5e60..0000000
Binary files a/typo3/mod/help/help.gif and /dev/null differ
diff --git a/typo3/mod/tools/clear.gif b/typo3/mod/tools/clear.gif
deleted file mode 100755 (executable)
index 9ed1269..0000000
Binary files a/typo3/mod/tools/clear.gif and /dev/null differ
index 8136aa8..454985b 100755 (executable)
@@ -1,5 +1,4 @@
 <?php
-$MLANG['default']['tabs_images']['tab'] = 'tool.gif';
 $MLANG['default']['ll_ref'] = 'LLL:EXT:lang/locallang_mod_admintools.xlf';
 $MCONF['name'] = 'tools';
 $MCONF['access'] = 'admin';
diff --git a/typo3/mod/tools/note.txt b/typo3/mod/tools/note.txt
deleted file mode 100755 (executable)
index d256337..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-NOTE:
-
-The mod/tools/ section is meant to be for admin-users ONLY (where the admin-flag is set), so all access configurations should be set to "admin"
-If you want access-minded modules for ordinary users, the mod/user module is suggested.
-
-All language labels (except module name and short description in the $conf-files) are in english for administrators.
-
-
-- kasper
-
-(5/12 2001, reviewed 2003/2)
\ No newline at end of file
diff --git a/typo3/mod/tools/tool.gif b/typo3/mod/tools/tool.gif
deleted file mode 100755 (executable)
index d60f290..0000000
Binary files a/typo3/mod/tools/tool.gif and /dev/null differ
diff --git a/typo3/mod/user/clear.gif b/typo3/mod/user/clear.gif
deleted file mode 100755 (executable)
index 9ed1269..0000000
Binary files a/typo3/mod/user/clear.gif and /dev/null differ
index a436505..bc411d7 100755 (executable)
@@ -1,5 +1,4 @@
 <?php
-$MLANG['default']['tabs_images']['tab'] = 'user.gif';
 $MLANG['default']['ll_ref'] = 'LLL:EXT:lang/locallang_mod_usertools.xlf';
 $MCONF['defaultMod'] = 'task';
 $MCONF['name'] = 'user';
diff --git a/typo3/mod/user/user.gif b/typo3/mod/user/user.gif
deleted file mode 100755 (executable)
index aab05b1..0000000
Binary files a/typo3/mod/user/user.gif and /dev/null differ
diff --git a/typo3/mod/web/clear.gif b/typo3/mod/web/clear.gif
deleted file mode 100755 (executable)
index 9ed1269..0000000
Binary files a/typo3/mod/web/clear.gif and /dev/null differ
index 0a2f152..95c6c81 100755 (executable)
@@ -1,5 +1,4 @@
 <?php
-$MLANG['default']['tabs_images']['tab'] = 'website.gif';
 $MLANG['default']['ll_ref'] = 'LLL:EXT:lang/locallang_mod_web.xlf';
 $MCONF['defaultMod'] = 'list';
 $MCONF['navFrameScript'] = '../../alt_db_navframe.php';
diff --git a/typo3/mod/web/website.gif b/typo3/mod/web/website.gif
deleted file mode 100755 (executable)
index 7b7cd5b..0000000
Binary files a/typo3/mod/web/website.gif and /dev/null differ
index 4d71a3c..763604e 100644 (file)
@@ -68,7 +68,6 @@ class ModulesController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionControll
                        $mainModuleData = array();
                        $moduleKey = $moduleName . '_tab';
                        $mainModuleData['name'] = $moduleName;
-                       $mainModuleData['icon'] = substr($GLOBALS['LANG']->moduleLabels['tabs_images'][$moduleKey], strlen(PATH_site));
                        $mainModuleData['label'] = $GLOBALS['LANG']->moduleLabels['tabs'][$moduleKey];
                        if (is_array($moduleInfo['sub']) && count($moduleInfo['sub']) > 0) {
                                $mainModuleData['subModules'] = $this->getSubModuleData($moduleName, $moduleInfo['sub']);
index ca9a488..2dcc793 100644 (file)
                        <f:for each="{modules}" as="mainModule">
                                <tr class="c-mainitem">
                                        <td colspan="3">
-                                               <f:if condition="{mainModules.subModules -> f:count()} > 0">
-                                                       <f:then>
-                                                               <h2><f:image src="{mainModule.icon}" alt="" /> {mainModule.label}</h2>
-                                                       </f:then>
-                                                       <f:else>
-                                                               <h2>
-                                                                       <a href="#" onclick="top.goToModule('{mainModule.name}'); return false;">
-                                                                               <f:image src="{mainModule.icon}" alt="" />
-                                                                       </a>
-
-                                                                       <a href="#" onclick="top.goToModule('{mainModule.name}'); return false;">
-                                                                               {mainModule.label}
-                                                                       </a>
-                                                               </h2>
-                                                       </f:else>
-                                               </f:if>
+                                               <h2>
+                                                       {mainModule.label}
+                                               </h2>
                                        </td>
                                </tr>