[TASK] Missing units "inches" and "points" 17/44217/2
authorXavier Perseguers <xavier@typo3.org>
Thu, 22 Oct 2015 09:52:18 +0000 (11:52 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Thu, 22 Oct 2015 10:38:28 +0000 (12:38 +0200)
Two common document units are missing:

- Inches
- Points

Furthermore, the units should not be abbreviated and become
translatable.

Change-Id: Ieb4478586d3710814cd038de6d9cbdbbdcde0e04
Resolves: #70902
Releases: master
Reviewed-on: https://review.typo3.org/44217
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php
typo3/sysext/filemetadata/Resources/Private/Language/locallang_tca.xlf

index dff71f9..b645535 100644 (file)
@@ -343,11 +343,13 @@ $tca = array(
                 'renderType' => 'selectSingle',
                 'items' => array(
                     array('', ''),
-                    array('px', 'px'),
-                    array('mm', 'mm'),
-                    array('cm', 'cm'),
-                    array('m', 'm'),
-                    array('p', 'p'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.px', 'px'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.cm', 'cm'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.in', 'in'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.mm', 'mm'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.m', 'm'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.p', 'p'),
+                    array('LLL:EXT:filemetadata/Resources/Private/Language/locallang_tca.xlf:sys_file_metadata.unit.pt', 'pt')
                 ),
                 'default' => '',
                 'readOnly' => true,
index 6d97950..5740f4c 100644 (file)
                        <trans-unit id="sys_file_metadata.unit">
                                <source>Unit</source>
                        </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.px">
+                               <source>Pixels</source>
+                       </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.cm">
+                               <source>Centimeters</source>
+                       </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.in">
+                               <source>Inches</source>
+                       </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.mm">
+                               <source>Millimeters</source>
+                       </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.m">
+                               <source>Meters</source>
+                       </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.p">
+                               <source>Picas</source>
+                       </trans-unit>
+                       <trans-unit id="sys_file_metadata.unit.pt">
+                               <source>Points</source>
+                       </trans-unit>
                        <trans-unit id="sys_file_metadata.duration">
                                <source>Duration</source>
                        </trans-unit>