[TASK] Replace icon by IconFactory: apps-toolbar-menu-shortcut 31/43031/3
authorJan Helke <typo3@helke.de>
Fri, 4 Sep 2015 15:01:24 +0000 (17:01 +0200)
committerFrank Nägler <frank.naegler@typo3.org>
Fri, 4 Sep 2015 15:15:38 +0000 (17:15 +0200)
Releases: master
Resolves: #69529
Change-Id: I19b3e8ffa6bcc8b87ff99f519f7dffc287dc29b9
Reviewed-on: http://review.typo3.org/43031
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php
typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js
typo3/sysext/core/Classes/Imaging/IconRegistry.php

index a688e86..24af475 100644 (file)
@@ -113,12 +113,9 @@ class ShortcutToolbarItem implements ToolbarItemInterface {
         * @return string HTML
         */
        public function getItem() {
-               return IconUtility::getSpriteIcon(
-                       'apps-toolbar-menu-shortcut',
-                       array(
-                               'title' => $this->getLanguageService()->sL('LLL:EXT:lang/locallang_core.xlf:toolbarItems.bookmarks', TRUE),
-                       )
-               );
+               $iconRegistry = GeneralUtility::makeInstance(IconFactory::class);
+               $title = $this->getLanguageService()->sL('LLL:EXT:lang/locallang_core.xlf:toolbarItems.bookmarks', TRUE);
+               return '<span title="' . $title . '">' . $iconRegistry->getIcon('apps-toolbar-menu-shortcut', Icon::SIZE_SMALL)->render() . '</span>';
        }
 
        /**
index a655de7..8dd8c72 100644 (file)
@@ -19,11 +19,11 @@ define('TYPO3/CMS/Backend/Toolbar/ShortcutMenu', ['jquery'], function($) {
 
        var ShortcutMenu = {
                $spinnerElement: $('<span>', {
-                       class: 't3-icon fa fa-circle-o-notch fa-spin'
+                       class: 'fa fa-circle-o-notch fa-spin'
                }),
                options: {
                        containerSelector: '#typo3-cms-backend-backend-toolbaritems-shortcuttoolbaritem',
-                       toolbarIconSelector: '.dropdown-toggle span.t3-icon',
+                       toolbarIconSelector: '.dropdown-toggle .fa',
                        toolbarMenuSelector: '.dropdown-menu',
                        shortcutItemSelector: '.dropdown-menu .shortcut',
                        shortcutDeleteSelector: '.shortcut-delete',
index b9bd67f..20f5676 100644 (file)
@@ -46,6 +46,12 @@ class IconRegistry implements \TYPO3\CMS\Core\SingletonInterface {
                                'name' => 'bolt',
                        )
                ),
+               'apps-toolbar-menu-shortcut' => array(
+                       'provider' => FontawesomeIconProvider::class,
+                       'options' => array(
+                               'name' => 'star',
+                       )
+               ),
                'actions-document-close' => array(
                        'provider' => FontawesomeIconProvider::class,
                        'options' => array(