[TASK] Replace gfx/spinner.gif with CSS 11/41011/2
authorBenjamin Mack <benni@typo3.org>
Thu, 9 Jul 2015 07:43:46 +0000 (09:43 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Thu, 9 Jul 2015 08:10:47 +0000 (10:10 +0200)
Replace all possible occurrences of the gfx/spinner.gif with
CSS look-a-likes, and have the t3editor still use the
spinner.gif for the time being, but moved to the
correct location.

Resolves: #67992
Releases: master
Change-Id: I37b50be3f5fbb185dc1620e2d616d3cea3a9a5f5
Reviewed-on: http://review.typo3.org/41011
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/gfx/spinner.gif [deleted file]
typo3/sysext/backend/Classes/Form/Wizard/SuggestWizard.php
typo3/sysext/t3editor/Resources/Public/Icons/spinner.gif [new file with mode: 0644]
typo3/sysext/t3editor/icons/loader_eeeeee.gif [deleted file]
typo3/sysext/t3editor/res/css/t3editor.css
typo3/sysext/t3editor/res/jslib/ts_codecompletion/descriptionPlugin.js

diff --git a/typo3/gfx/spinner.gif b/typo3/gfx/spinner.gif
deleted file mode 100644 (file)
index 12cc304..0000000
Binary files a/typo3/gfx/spinner.gif and /dev/null differ
index 22da6c5..7f13303 100644 (file)
@@ -60,7 +60,7 @@ class SuggestWizard {
                                <span class="input-group-addon"><i class="fa fa-search"></i></span>
                                <input type="search" id="' . htmlspecialchars($fieldname) . 'Suggest" value="' . $languageService->sL('LLL:EXT:lang/locallang_core.xlf:labels.findRecord') . '" class="form-control ' . $this->cssClass . '-search" />
                                <div class="' . $this->cssClass . '-indicator" style="display: none;" id="' . htmlspecialchars($fieldname) . 'SuggestIndicator">
-                                       <img src="' . $GLOBALS['BACK_PATH'] . 'gfx/spinner.gif" alt="' . $languageService->sL('LLL:EXT:lang/locallang_core.xlf:alttext.suggestSearching') . '" />
+                                       <span class="fa fa-spin fa-spinner" title="' . $languageService->sL('LLL:EXT:lang/locallang_core.xlf:alttext.suggestSearching', TRUE) . '"></span>
                                </div>
                                <div class="' . $this->cssClass . '-choices" style="display: none;" id="' . htmlspecialchars($fieldname) . 'SuggestChoices"></div>
                        </div>
diff --git a/typo3/sysext/t3editor/Resources/Public/Icons/spinner.gif b/typo3/sysext/t3editor/Resources/Public/Icons/spinner.gif
new file mode 100644 (file)
index 0000000..12cc304
Binary files /dev/null and b/typo3/sysext/t3editor/Resources/Public/Icons/spinner.gif differ
diff --git a/typo3/sysext/t3editor/icons/loader_eeeeee.gif b/typo3/sysext/t3editor/icons/loader_eeeeee.gif
deleted file mode 100644 (file)
index b0f25e2..0000000
Binary files a/typo3/sysext/t3editor/icons/loader_eeeeee.gif and /dev/null differ
index 33a431c..e1ff672 100644 (file)
@@ -85,7 +85,7 @@ div.CodeMirror-line-numbers {
        border: 1px solid gray;
        position: relative;
        background-color: #EFEFF4;
-       background-image: url('../../../../gfx/spinner.gif');
+       background-image: url('../../Resources/Public/Icons/spinner.gif');
        background-position: 49% 50%;
        background-repeat: no-repeat;
        margin-right: 10px;
@@ -95,7 +95,7 @@ div.CodeMirror-line-numbers {
        position: absolute;
        top: 0; left: 0;
        background-color: #EFEFF4;
-       background-image: url('../../../../gfx/spinner.gif');
+       background-image: url('../../Resources/Public/Icons/spinner.gif');
        background-position: 49% 50%;
        background-repeat: no-repeat;
        z-index:200;
index 2594d8e..6e40a93 100644 (file)
@@ -57,7 +57,7 @@ var DescriptionPlugin = function() {
                        // first a container has to be built
                        descriptionBox.innerHTML  = '<div class="TSREF_type_label">Object-type: </div><div class="TSREF_type">'+type.typeId+'</div>';
                        descriptionBox.innerHTML += '<div class="TSREF_type_label">Property-type: </div><div class="TSREF_type">'+type.properties[proposalObj.word].value+'</div><br/>';
-                       descriptionBox.innerHTML += '<div class="TSREF_description_label">TSREF-description:</div><div id="TSREF_description"><img src="gfx/spinner.gif" border="0" alt="one moment please..."/></div>';
+                       descriptionBox.innerHTML += '<div class="TSREF_description_label">TSREF-description:</div><div id="TSREF_description"><span class="fa fa-spin fa-spinner" title="one moment please..."></span></div>';
                        var prop = type.properties[proposalObj.word];
                        // if there is another request for a description in the queue -> cancel it