[TASK] Remove referer check for jumpUrl handling 42/40542/3
authorDavid Greiner <hallo@davidgreiner.de>
Mon, 22 Jun 2015 19:40:58 +0000 (21:40 +0200)
committerHelmut Hummel <helmut.hummel@typo3.org>
Tue, 23 Jun 2015 15:55:10 +0000 (17:55 +0200)
This commit removes the referer check while handling jumpurls.

Resolves: #66602
Releases: master
Change-Id: Ice0795fb8de4647834719b6f4152eb076631c40c
Reviewed-on: http://review.typo3.org/40542
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
typo3/sysext/core/Documentation/Changelog/master/Breaking-66602-RemoveRefererCheckWhileHandlingJumpUrl.rst [new file with mode: 0644]
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/frontend/Classes/RequestHandler.php

diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-66602-RemoveRefererCheckWhileHandlingJumpUrl.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-66602-RemoveRefererCheckWhileHandlingJumpUrl.rst
new file mode 100644 (file)
index 0000000..8f145a6
--- /dev/null
@@ -0,0 +1,25 @@
+=========================================================
+Breaking - #66602: Check jumpUrl referer has been removed
+=========================================================
+
+Description
+===========
+
+The following method has been removed:
+
+
+.. code-block:: php
+
+       TypoScriptFrontendController::checkJumpUrlReferer()
+
+
+Impact
+======
+
+Calls to this method will result in a fatal error.
+
+
+Affected Installations
+======================
+
+Instances with third-party extensions calling this method.
index 7b22d46..5ebca9c 100644 (file)
@@ -2810,20 +2810,6 @@ class TypoScriptFrontendController {
        }
 
        /**
-        * Check the jumpUrl referer if required
-        *
-        * @return void
-        */
-       public function checkJumpUrlReferer() {
-               if ($this->jumpurl !== '' && !$this->TYPO3_CONF_VARS['SYS']['doNotCheckReferer']) {
-                       $referer = parse_url(GeneralUtility::getIndpEnv('HTTP_REFERER'));
-                       if (isset($referer['host']) && !($referer['host'] == GeneralUtility::getIndpEnv('TYPO3_HOST_ONLY'))) {
-                               unset($this->jumpurl);
-                       }
-               }
-       }
-
-       /**
         * Sends a header "Location" to jumpUrl, if jumpurl is set.
         * Will exit if a location header is sent (for instance if jumpUrl was triggered)
         *
index d43dae6..a87944a 100644 (file)
@@ -180,7 +180,6 @@ class RequestHandler implements RequestHandlerInterface {
 
                // Check JumpUrl
                $this->controller->setExternalJumpUrl();
-               $this->controller->checkJumpUrlReferer();
 
                $this->controller->handleDataSubmission();