[!!!][TASK] Remove unused configuration settings 77/54077/4
authorChristian Kuhn <lolli@schwarzbu.ch>
Sat, 9 Sep 2017 18:07:03 +0000 (20:07 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sun, 10 Sep 2017 08:07:58 +0000 (10:07 +0200)
The patch drops some unused pre-doctrine DB related TYPO3_CONF_VARS.

Change-Id: I9204ef926b1de145f541e2c84dadc6a968e153b9
Resolves: #82421
Releases: master
Reviewed-on: https://review.typo3.org/54077
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml
typo3/sysext/core/Documentation/Changelog/master/Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst [new file with mode: 0644]
typo3/sysext/install/Classes/Configuration/Context/CustomPreset.php
typo3/sysext/install/Classes/Configuration/Context/DebugPreset.php
typo3/sysext/install/Classes/Configuration/Context/LivePreset.php
typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php

index 189bcc1..951d1a2 100644 (file)
@@ -77,7 +77,6 @@ return [
         'recursiveDomainSearch' => false,
         'trustedHostsPattern' => 'SERVER_NAME',
         'devIPmask' => '127.0.0.1,::1',
-        'sqlDebug' => 0,
         'enable_DLOG' => false,
         'ddmmyy' => 'd-m-y',
         'hhmm' => 'H:i',
@@ -88,8 +87,6 @@ return [
         'mediafile_ext' => 'gif,jpg,jpeg,bmp,png,pdf,svg,ai,mp3,wav,mp4,ogg,flac,opus,webm,youtube,vimeo',
         'binPath' => '',
         'binSetup' => '',
-        'no_pconnect' => true,
-        'dbClientCompress' => false,
         'setDBinit' => '',
         'setMemoryLimit' => 0,
         'phpTimeZone' => '',
index 393f7b3..f5258db 100644 (file)
@@ -105,13 +105,6 @@ SYS:
         devIPmask:
             type: text
             description: 'Defines a list of IP addresses which will allow development-output to display. The debug() function will use this as a filter. See the function <code>\TYPO3\CMS\Core\Utility\GeneralUtility::cmpIP()</code> for details on syntax. Setting this to blank value will deny all. Setting to "*" will allow all.'
-        sqlDebug:
-            type: int
-            allowedValues:
-              '0': 'Disable SQL debug output'
-              '1': 'Display only failed SQL queries'
-              '2': 'Display all SQL queries'
-            description: 'Allows displaying executed SQL queries in the browser (for debugging purposes and development)'
         enable_DLOG:
             type: bool
             description: 'Whether the developer log is enabled.'
@@ -142,12 +135,6 @@ SYS:
         binSetup:
             type: multiline
             description: 'List of programs (separated by newline or comma). By default programs will be searched in default paths and the special paths defined by <code>binPath</code>. When PHP has openbasedir enabled the programs can not be found and have to be configured here. Example: <code>perl=/usr/bin/perl,unzip=/usr/local/bin/unzip</code>'
-        no_pconnect:
-            type: bool
-            description: 'If TRUE, "connect" is used to connect to the database. If FALSE, a persistent connection using "pconnect" will be established!'
-        dbClientCompress:
-            type: bool
-            description: 'if TRUE, data exchange between TYPO3 and database server will be compressed. This may improve performance if (1) database serever is on the different server and (2) network connection speed to database server is 100mbps or less. CPU usage will be higher if this option is used but database operations will be executed faster due to much less (up to 3 times) database network traffic. This option has no effect if MySQL server is localhost.'
         setDBinit:
             type: multiline
             description: 'These commands are executed after the database connection was established. Hint: The previous default "SET NAMES utf8;" is not required any more and will be removed automatically if set!'
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst
new file mode 100644 (file)
index 0000000..02c1a26
--- /dev/null
@@ -0,0 +1,38 @@
+.. include:: ../../Includes.txt
+
+===============================================================
+Breaking: #82421 - Dropped old DB related configuration options
+===============================================================
+
+See :issue:`82421`
+
+Description
+===========
+
+Some configuration options related to pre-doctrine era have been removed
+from :php:`$GLOBALS['TYPO3_CONF_VARS']`:
+
+* `SYS/sqlDebug` - Obsolete since version 8, no substitution
+* `SYS/no_pconnect` - Obsolete since core version 8 and migrated automatically
+* `SYS/dbClientCompress` - Obsolete since core version 8 and migrated automatically
+
+
+Impact
+======
+
+Extension code usually shouldn't rely on these settings.
+
+
+Affected Installations
+======================
+
+Instances with extension code using these array entries in :php:`$GLOBALS['TYPO3_CONF_VARS']`
+are found by the install tool extension scanner.
+
+
+Migration
+=========
+
+Extension code should not rely on these core framework internal settings.
+
+.. index:: Database, LocalConfiguration, PHP-API, FullyScanned
\ No newline at end of file
index 2b716a2..5822e12 100644 (file)
@@ -30,7 +30,6 @@ class CustomPreset extends Configuration\AbstractCustomPreset implements Configu
         'SYS/devIPmask' => '',
         'SYS/displayErrors' => '',
         'SYS/enableDeprecationLog' => '',
-        'SYS/sqlDebug' => '',
         'SYS/systemLogLevel' => '',
     ];
 }
index 010721a..7255820 100644 (file)
@@ -40,7 +40,6 @@ class DebugPreset extends Configuration\AbstractPreset
         'SYS/devIPmask' => '*',
         'SYS/displayErrors' => 1,
         'SYS/enableDeprecationLog' => 'file',
-        'SYS/sqlDebug' => 1,
         'SYS/systemLogLevel' => 0,
         // E_WARNING | E_RECOVERABLE_ERROR | E_DEPRECATED | E_USER_DEPRECATED
         'SYS/exceptionalErrors' => 28674,
index ffc7cc7..3b965ec 100644 (file)
@@ -40,7 +40,6 @@ class LivePreset extends Configuration\AbstractPreset
         'SYS/devIPmask' => '',
         'SYS/displayErrors' => 0,
         'SYS/enableDeprecationLog' => false,
-        'SYS/sqlDebug' => 0,
         'SYS/systemLogLevel' => 2,
         // E_RECOVERABLE_ERROR | E_USER_DEPRECATED
         'SYS/exceptionalErrors' => 20480,
index 6289382..d19d96a 100644 (file)
@@ -102,6 +102,10 @@ class SilentConfigurationUpgradeService
         'SYS/enable_exceptionDLOG',
         // #82377
         'EXT/allowSystemInstall',
+        // #82421
+        'SYS/sqlDebug',
+        'SYS/no_pconnect',
+        'SYS/dbClientCompress',
     ];
 
     public function __construct(ConfigurationManager $configurationManager = null)
index aca7d12..25b49e2 100644 (file)
@@ -34,6 +34,21 @@ return [
             'Breaking-82162-GlobalErrorConstantsRemoved.rst',
         ],
     ],
+    '$GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'sqlDebug\']' => [
+        'restFiles' => [
+            'Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst',
+        ],
+    ],
+    '$GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'no_pconnect\']' => [
+        'restFiles' => [
+            'Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst',
+        ],
+    ],
+    '$GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'dbClientCompress\']' => [
+        'restFiles' => [
+            'Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst',
+        ],
+    ],
 
     // Hooks
     '$GLOBALS[\'TYPO3_CONF_VARS\'][\'SC_OPTIONS\'][\'t3lib/class.t3lib_befunc.php\'][\'getFlexFormDSClass\']' => [