[BUGFIX] ExportPageTreeView wrapTitle() signature is incompatible 11/45211/5
authorMarkus Sommer <markus.sommer@in2code.de>
Fri, 11 Dec 2015 13:11:50 +0000 (14:11 +0100)
committerMorton Jonuschat <m.jonuschat@mojocode.de>
Fri, 11 Dec 2015 19:45:36 +0000 (20:45 +0100)
ExportPageTreeView contains following method declaration:

 public function wrapTitle($title, $v);

however in the AbstractTreeView the signature is:

 public function wrapTitle($title, $row, $bank = 0);

This will create a PHP warning on PHP7.

This change updates the method signature of the ExportPageTreeView to be
in line with the AbstractTreeView.

Resolves: #72176
Releases: master
Change-Id: Icc6cb69ffd4860f882157239e25135e2a6744a65
Reviewed-on: https://review.typo3.org/45211
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
typo3/sysext/impexp/Classes/View/ExportPageTreeView.php

index d64487a..96abce9 100644 (file)
@@ -38,10 +38,12 @@ class ExportPageTreeView extends BrowseTreeView
      * Wrapping title from page tree.
      *
      * @param string $title Title to wrap
-     * @param mixed $v (See parent class)
+     * @param string $row Item record
+     * @param int $bank Bank pointer (which mount point number)
      * @return string Wrapped title
+     * @access private
      */
-    public function wrapTitle($title, $v)
+    public function wrapTitle($title, $row, $bank = 0)
     {
         return trim($title) === '' ? '<em>[' . $this->getLanguageService()->sL('LLL:EXT:lang/locallang_core.xlf:labels.no_title', true) . ']</em>' : htmlspecialchars($title);
     }