[TASK] Move signal slots from EXT:install to EXT:core 36/53836/4
authorBenni Mack <benni@typo3.org>
Wed, 30 Aug 2017 10:38:40 +0000 (12:38 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 31 Aug 2017 14:43:18 +0000 (16:43 +0200)
The left-over signals in EXT:install/ext_localconf.php belong
to EXT:core (uses classes from EXT:core anyways) and since
both extensions are required at any time (part of minimal system)
this is just a separation cleanup.

Resolves: #82241
Releases: master
Change-Id: I9ec93ada9b4985ced285276fa5c33b851ec0be8f
Reviewed-on: https://review.typo3.org/53836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
typo3/sysext/core/ext_localconf.php
typo3/sysext/install/ext_localconf.php

index ea209d2..5643778 100644 (file)
@@ -76,7 +76,18 @@ $signalSlotDispatcher->connect(
     \TYPO3\CMS\Core\DataHandling\DatabaseSchemaService::class,
     'getLocalizationRequiredDatabaseSchema'
 );
-
+$signalSlotDispatcher->connect(
+    'TYPO3\\CMS\\Install\\Service\\SqlExpectedSchemaService',
+    'tablesDefinitionIsBeingBuilt',
+    \TYPO3\CMS\Core\Cache\DatabaseSchemaService::class,
+    'addCachingFrameworkRequiredDatabaseSchemaForSqlExpectedSchemaService'
+);
+$signalSlotDispatcher->connect(
+    'TYPO3\\CMS\\Install\\Service\\SqlExpectedSchemaService',
+    'tablesDefinitionIsBeingBuilt',
+    \TYPO3\CMS\Core\Category\CategoryRegistry::class,
+    'addCategoryDatabaseSchemaToTablesDefinition'
+);
 $signalSlotDispatcher->connect(
     \TYPO3\CMS\Extensionmanager\Utility\InstallUtility::class,
     'tablesDefinitionIsBeingBuilt',
index b048f5e..fe291e6 100644 (file)
@@ -1,21 +1,6 @@
 <?php
 defined('TYPO3_MODE') or die();
 
-$signalSlotDispatcher = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Extbase\SignalSlot\Dispatcher::class);
-$signalSlotDispatcher->connect(
-    'TYPO3\\CMS\\Install\\Service\\SqlExpectedSchemaService',
-    'tablesDefinitionIsBeingBuilt',
-    \TYPO3\CMS\Core\Cache\DatabaseSchemaService::class,
-    'addCachingFrameworkRequiredDatabaseSchemaForSqlExpectedSchemaService'
-);
-$signalSlotDispatcher->connect(
-    'TYPO3\\CMS\\Install\\Service\\SqlExpectedSchemaService',
-    'tablesDefinitionIsBeingBuilt',
-    \TYPO3\CMS\Core\Category\CategoryRegistry::class,
-    'addCategoryDatabaseSchemaToTablesDefinition'
-);
-unset($signalSlotDispatcher);
-
 // Do not delete this wizard. This makes sure new installations get the TER repository set in the database.
 $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'][\TYPO3\CMS\Install\Updates\ExtensionManagerTables::class]
     = \TYPO3\CMS\Install\Updates\ExtensionManagerTables::class;