[TASK] Remove extension commerce specific code in TYPO3 Core
authorMarcus Krause <marcus.krause@e-netconsulting.com>
Wed, 25 May 2011 09:15:05 +0000 (11:15 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 25 May 2011 09:58:43 +0000 (11:58 +0200)
Class tslib_feUserAuth contains TER specific code. This issue is about
to remove this piece of code.

In specific this is EXT:commerce related code which has been
introduced with the TYPO3 Core Session Fixation Security Fix.

Whether fixed or not in commerce, Core should not fix code for
TER listed extensions. However, as commerce list currently very active
it should be possible for the contributors to fix problems if still
existing.

Change-Id: I2dae9c6f5fa24ce11f43ebd612523a00101e2990
Resolves: #27027
Reviewed-on: http://review.typo3.org/2364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/sysext/cms/tslib/class.tslib_feuserauth.php

index 70e5af2..94d296d 100644 (file)
@@ -573,24 +573,6 @@ class tslib_feUserAuth extends t3lib_userAuth {
                        }
                }
 
-                       // @deprecated: Check for commerce basket records. The following lines should be removed once a fixed commerce version is released.
-                       // Extensions like commerce which have their own session table should just put some small bit of data into fe_session_data using $GLOBALS['TSFE']->fe_user->setKey('ses', ...) to make the session stable.
-               if ($count == FALSE && t3lib_extMgm::isLoaded('commerce')) {
-                       t3lib_div::deprecationLog("EXT:commerce specific code in tslib_feuserauth::isExistingSessionRecord() is deprecated. Will be removed in 4.6");
-
-                       $dbres = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
-                                                       '*',
-                                                       'tx_commerce_baskets',
-                                                       'sid=' . $GLOBALS['TYPO3_DB']->fullQuoteStr($id, 'tx_commerce_baskets')
-                                               );
-                       if ($dbres !== FALSE) {
-                               if ($sesDataRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($dbres)) {
-                                       $count = TRUE;
-                               }
-                               $GLOBALS['TYPO3_DB']->sql_free_result($dbres);
-                       }
-               }
-
                return $count;
        }
 }