[BUGFIX] Fix double encoding in VersionModuleController 76/49176/2
authorWouter Wolters <typo3@wouterwolters.nl>
Thu, 21 Jul 2016 11:02:40 +0000 (13:02 +0200)
committerMarkus Klein <markus.klein@typo3.org>
Sat, 23 Jul 2016 08:34:01 +0000 (10:34 +0200)
The function getRecordTitle does htmlspecialchars when
3rd parameter is set to true. Remove the surrounding
htmlspecialchars to prevent double encoding.

Resolves: #77192
Releases: master,7.6
Change-Id: Ic973c127dd6b5134ab74f89df7061144e5d03068
Reviewed-on: https://review.typo3.org/49176
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
typo3/sysext/version/Classes/Controller/VersionModuleController.php

index f70b35e..07d5c09 100644 (file)
@@ -382,7 +382,7 @@ class VersionModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClass
                         ) . '
                                        </td>
                                        <td class="col-icon">' . $this->moduleTemplate->getIconFactory()->getIconForRecord($this->table, $row, Icon::SIZE_SMALL)->render() . '</td>
-                                       <td>' . htmlspecialchars(BackendUtility::getRecordTitle($this->table, $row, true)) . '</td>
+                                       <td>' . BackendUtility::getRecordTitle($this->table, $row, true) . '</td>
                                        <td>' . $row['uid'] . '</td>
                                        <td>' . $row['t3ver_oid'] . '</td>
                                        <td>' . $row['t3ver_id'] . '</td>
@@ -473,7 +473,7 @@ class VersionModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClass
                     $content .= '
                                                <tr>
                                                        <td class="col-icon">' . $this->moduleTemplate->getIconFactory()->getIconForRecord($table, $subrow, Icon::SIZE_SMALL)->render() . '</td>
-                                                       <td class="col-title">' . htmlspecialchars(BackendUtility::getRecordTitle($table, $subrow, true)) . '</td>
+                                                       <td class="col-title">' . BackendUtility::getRecordTitle($table, $subrow, true) . '</td>
                                                        <td>' . ($ownVer > 1 ? '<a href="' . htmlspecialchars(BackendUtility::getModuleUrl('web_txversionM1', array('table' => $table, 'uid' => $subrow['uid']))) . '">' . ($ownVer - 1) . '</a>' : '') . '</td>
                                                        <td class="col-control">' . $this->adminLinks($table, $subrow) . '</td>
                                                </tr>';