[TASK] Functionals: Rename "@group mysql" to "@group not-postgres" 85/52985/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 31 May 2017 20:28:12 +0000 (22:28 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 31 May 2017 20:57:57 +0000 (22:57 +0200)
Functional tests annotated with "@group mysql" are currently ignored
if running tests on postgres via "--exclude-group mysql" argument.
With mssql we have some tests that run fine with mysql and postgres,
but not with mssql.
To improve handling, "@group mysql" annotation is renamed
to "@group not-postgres". Tests not available on postgres and mssql
will then later have a second annotation "@group not-mssql".
This way its easier to keep track which tests go red on which DBMS.

Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3
Resolves: #81394
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52985
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php
typo3/sysext/core/Tests/Functional/Database/DatabaseConnectionTest.php
typo3/sysext/core/Tests/Functional/Database/PreparedStatementTest.php
typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php
typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInEmptyDatabaseTest.php
typo3/sysext/install/Tests/Functional/SqlSchemaMigrationServiceTest.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php

index f983035..32f7cbe 100644 (file)
@@ -401,7 +401,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function flushByTagWorksWithEmptyCacheTablesWithMysql()
     {
@@ -412,7 +412,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function flushByTagsWorksWithEmptyCacheTablesWithMysql()
     {
@@ -423,7 +423,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function flushByTagRemovesCorrectRowsFromDatabaseWithMysql()
     {
@@ -443,7 +443,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function flushByTagsRemovesCorrectRowsFromDatabaseWithMysql()
     {
@@ -517,7 +517,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function collectGarbageWorksWithEmptyTableWithMysql()
     {
@@ -528,7 +528,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function collectGarbageRemovesCacheEntryWithExpiredLifetimeWithMysql()
     {
@@ -559,7 +559,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function collectGarbageRemovesTagEntriesForCacheEntriesWithExpiredLifetimeWithMysql()
     {
@@ -590,7 +590,7 @@ class Typo3DatabaseBackendTest extends \TYPO3\TestingFramework\Core\Functional\F
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function collectGarbageRemovesOrphanedTagEntriesFromTagsTableWithMysql()
     {
index 96ffcd5..9e3d03c 100644 (file)
@@ -72,7 +72,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function selectDbReturnsTrue()
     {
@@ -82,7 +82,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function selectDbReturnsFalse()
     {
@@ -97,7 +97,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlAffectedRowsReturnsCorrectAmountOfRows()
     {
@@ -108,7 +108,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlInsertIdReturnsCorrectId()
     {
@@ -119,7 +119,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function noSqlError()
     {
@@ -130,7 +130,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlErrorWhenInsertIntoInexistentField()
     {
@@ -141,7 +141,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function noSqlErrorCode()
     {
@@ -152,7 +152,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlErrorNoWhenInsertIntoInexistentField()
     {
@@ -163,7 +163,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlPconnectReturnsInstanceOfMySqli()
     {
@@ -173,7 +173,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function connectDbThrowsExeptionsWhenNoDatabaseIsGiven()
     {
@@ -188,7 +188,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function connectDbConnectsToDatabaseWithoutErrors()
     {
@@ -199,7 +199,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function disconnectIfConnectedDisconnects()
     {
@@ -260,7 +260,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $values
      * @param string $expectedResult
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function fullQuoteStrReturnsQuotedString($values, $expectedResult)
     {
@@ -386,7 +386,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $values
      * @param string $expectedResult
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function fullQuoteArrayQuotesArray($values, $expectedResult)
     {
@@ -434,7 +434,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $string String to quote
      * @param string $expectedResult Quoted string we expect
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function quoteStrQuotesDoubleQuotesCorrectly($string, $expectedResult)
     {
@@ -445,7 +445,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminQueryReturnsTrueForInsertQuery()
     {
@@ -457,7 +457,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminQueryReturnsTrueForUpdateQuery()
     {
@@ -473,7 +473,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminQueryReturnsTrueForDeleteQuery()
     {
@@ -487,7 +487,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminQueryReturnsResultForSelectQuery()
     {
@@ -503,7 +503,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminGetCharsetsReturnsArrayWithCharsets()
     {
@@ -520,7 +520,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminGetKeysReturnIndexKeysOfTable()
     {
@@ -531,7 +531,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminGetFieldsReturnFieldInformationsForTable()
     {
@@ -543,7 +543,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminGetTablesReturnAllTablesFromDatabase()
     {
@@ -555,7 +555,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function adminGetDbsReturnsAllDatabases()
     {
@@ -598,7 +598,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
      * @param string $sql
      * @param string $expectedResult
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlNumRowsReturnsCorrectAmountOfRows($sql, $expectedResult)
     {
@@ -616,7 +616,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlNumRowsReturnsFalse()
     {
@@ -655,7 +655,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlFetchAssocReturnsAssocArray()
     {
@@ -714,7 +714,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlFetchRowReturnsNumericArray()
     {
@@ -736,7 +736,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlFreeResultReturnsFalseOnFailure()
     {
@@ -750,7 +750,7 @@ class DatabaseConnectionTest extends \TYPO3\TestingFramework\Core\Functional\Fun
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function sqlFreeResultReturnsTrueOnSuccess()
     {
index edc0ba5..b7e016f 100644 (file)
@@ -72,7 +72,7 @@ class PreparedStatementTest extends \TYPO3\TestingFramework\Core\Functional\Func
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function prepareSelectQueryCreateValidQuery()
     {
index cc9591a..32ff6eb 100644 (file)
@@ -199,7 +199,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
 
     /**
      * @test
-     * @group mysql
+     * @group not-postgres
      */
     public function renameUnusedField()
     {
@@ -280,7 +280,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
 
     /**
      * @test
-     * @group mysql
+     * @group not-postgres
      */
     public function installPerformsOnlyAddAndCreateOperations()
     {
@@ -308,7 +308,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
 
     /**
      * @test
-     * @group mysql
+     * @group not-postgres
      */
     public function installCanPerformChangeOperations()
     {
@@ -324,7 +324,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
 
     /**
      * @test
-     * @group mysql
+     * @group not-postgres
      */
     public function importStaticDataInsertsRecords()
     {
@@ -350,7 +350,7 @@ class SchemaMigratorTest extends \TYPO3\TestingFramework\Core\Functional\Functio
 
     /**
      * @test
-     * @group mysql
+     * @group not-postgres
      */
     public function changeTableEngine()
     {
index 3058a77..b05e683 100644 (file)
@@ -170,7 +170,7 @@ class PagesAndTtContentWithImagesInEmptyDatabaseTest extends AbstractImportExpor
 
     /**
      * @test
-     * @group mysql
+     * @group not-postgres
      */
     public function importPagesAndRelatedTtContentWithImageWithForcedUids()
     {
index b859ada..2d1545e 100644 (file)
@@ -36,7 +36,7 @@ class SqlSchemaMigrationServiceTest extends \TYPO3\TestingFramework\Core\Functio
     /**
      * @test
      *
-     * @group mysql
+     * @group not-postgres
      */
     public function columnAndKeyDeletionDoesNotReturnAnError()
     {
index d837a69..b5f4cc1 100644 (file)
@@ -584,7 +584,7 @@ class ActionTest extends \TYPO3\CMS\Workspaces\Tests\Functional\DataHandling\Reg
     /**
      * @test
      * @see DataSet/changeContentSortingAndCopyDraftPage.csv
-     * @group mysql
+     * @group not-postgres
      * @todo Analyse PostgreSQL issues further, which is a generic issue
      */
     public function changeContentSortingAndCopyDraftPage()