[TASK] CGL fixes after upgrade to php-cs-fixer 1.4 76/53776/3
authorChristian Kuhn <lolli@schwarzbu.ch>
Tue, 22 Aug 2017 17:33:24 +0000 (19:33 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Wed, 23 Aug 2017 16:27:53 +0000 (18:27 +0200)
Change a series of cgl details after update of php-cs-fixer
from 1.0 to 1.4.

Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f
Resolves: #82171
Related: #82164
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53776
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
188 files changed:
typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php
typo3/sysext/backend/Classes/Clipboard/Clipboard.php
typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php
typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php
typo3/sysext/backend/Classes/Controller/EditDocumentController.php
typo3/sysext/backend/Classes/Controller/File/RenameFileController.php
typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php
typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php
typo3/sysext/backend/Classes/Controller/PageLayoutController.php
typo3/sysext/backend/Classes/Controller/Wizard/EditController.php
typo3/sysext/backend/Classes/Form/FieldWizard/FileThumbnails.php
typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageContent.php
typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php
typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php
typo3/sysext/backend/Classes/History/RecordHistory.php
typo3/sysext/backend/Classes/Http/RequestHandler.php
typo3/sysext/backend/Classes/Module/ModuleLoader.php
typo3/sysext/backend/Classes/Template/Components/MetaInformation.php
typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php
typo3/sysext/backend/Classes/Utility/BackendUtility.php
typo3/sysext/backend/Classes/View/BackendLayout/DataProviderCollection.php
typo3/sysext/backend/Classes/View/PageLayoutView.php
typo3/sysext/backend/Tests/Unit/View/BackendLayoutViewTest.php
typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php
typo3/sysext/core/Classes/Configuration/ConfigurationManager.php
typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php
typo3/sysext/core/Classes/Controller/ErrorPageController.php
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php
typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php
typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php
typo3/sysext/core/Classes/Database/QueryGenerator.php
typo3/sysext/core/Classes/Database/RelationHandler.php
typo3/sysext/core/Classes/Http/UploadedFile.php
typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php
typo3/sysext/core/Classes/Imaging/IconFactory.php
typo3/sysext/core/Classes/Localization/LanguageService.php
typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php
typo3/sysext/core/Classes/Migrations/TcaMigration.php
typo3/sysext/core/Classes/Package/DependencyResolver.php
typo3/sysext/core/Classes/Page/PageRenderer.php
typo3/sysext/core/Classes/Resource/Driver/DriverRegistry.php
typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php
typo3/sysext/core/Classes/Resource/FileRepository.php
typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php
typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/YouTubeHelper.php
typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.php
typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php
typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php
typo3/sysext/core/Classes/Resource/ResourceCompressor.php
typo3/sysext/core/Classes/Resource/ResourceStorage.php
typo3/sysext/core/Classes/Resource/Service/UserStorageCapabilityService.php
typo3/sysext/core/Classes/Resource/StorageRepository.php
typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php
typo3/sysext/core/Classes/Type/Enumeration.php
typo3/sysext/core/Classes/Type/File/ImageInfo.php
typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
typo3/sysext/core/Classes/TypoScript/TemplateService.php
typo3/sysext/core/Classes/Utility/ArrayUtility.php
typo3/sysext/core/Classes/Utility/CommandUtility.php
typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Configuration/TCA/pages.php
typo3/sysext/core/Tests/Functional/DataHandling/Group/AbstractActionTestCase.php
typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/AbstractActionTestCase.php
typo3/sysext/core/Tests/Functional/DataHandling/Select/AbstractActionTestCase.php
typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/ext_localconf.php
typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php
typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php
typo3/sysext/core/Tests/Unit/Category/CategoryRegistryTest.php
typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php
typo3/sysext/core/Tests/Unit/Configuration/RichtextTest.php
typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php
typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php
typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php
typo3/sysext/core/Tests/Unit/LinkHandling/RecordLinkHandlerTest.php
typo3/sysext/core/Tests/Unit/Localization/Parser/LocallangXmlParserTest.php
typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php
typo3/sysext/core/Tests/Unit/Log/LoggerTest.php
typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php
typo3/sysext/core/Tests/Unit/Resource/FileTest.php
typo3/sysext/core/Tests/Unit/Resource/Filter/FileNameFilterTest.php
typo3/sysext/core/Tests/Unit/Resource/FolderTest.php
typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php
typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php
typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php
typo3/sysext/extbase/Classes/Command/HelpCommand.php
typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php
typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php
typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php
typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php
typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/DateTimeValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/EmailAddressValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/IntegerValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/NumberRangeValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/NumberValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/StringLengthValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/StringValidator.php
typo3/sysext/extbase/Classes/Validation/Validator/TextValidator.php
typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php
typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php
typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedContentTest.php
typo3/sysext/extbase/Tests/Unit/Mvc/Cli/RequestBuilderTest.php
typo3/sysext/extbase/Tests/Unit/Mvc/Controller/AbstractControllerTest.php
typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php
typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php
typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php
typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php
typo3/sysext/extensionmanager/ext_tables.php
typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php
typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php
typo3/sysext/filelist/Classes/Controller/FileListController.php
typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Widget/Controller/PaginateController.php
typo3/sysext/fluid/Tests/Unit/View/StandaloneViewTest.php
typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.php
typo3/sysext/fluid/Tests/Unit/ViewHelpers/Widget/Controller/PaginateControllerTest.php
typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php
typo3/sysext/form/Classes/Domain/Finishers/FlashMessageFinisher.php
typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php
typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php
typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php
typo3/sysext/form/Classes/Mvc/ProcessingRule.php
typo3/sysext/form/Classes/Mvc/Validation/CountValidator.php
typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php
typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php
typo3/sysext/form/Tests/Unit/Hooks/DataStructureIdentifierHookTest.php
typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php
typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php
typo3/sysext/frontend/Classes/Http/RequestHandler.php
typo3/sysext/frontend/Classes/Page/PageRepository.php
typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php
typo3/sysext/frontend/Configuration/TCA/pages_language_overlay.php
typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedContentRenderingTest.php
typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php
typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php
typo3/sysext/impexp/Classes/Controller/ImportExportController.php
typo3/sysext/impexp/Classes/Import.php
typo3/sysext/impexp/Classes/Task/ImportExportTask.php
typo3/sysext/indexed_search/Classes/Controller/SearchController.php
typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php
typo3/sysext/info/Classes/Controller/TranslationStatusController.php
typo3/sysext/install/Classes/Controller/Action/Ajax/CoreUpdateAbstract.php
typo3/sysext/install/Classes/Controller/Action/Tool/Upgrade.php
typo3/sysext/install/Classes/Report/SecurityStatusReport.php
typo3/sysext/install/Classes/Updates/AbstractDownloadExtensionUpdate.php
typo3/sysext/install/Classes/Updates/FrontendUserImageUpdateWizard.php
typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php
typo3/sysext/install/Tests/Unit/UpgradeAnalysis/DocumentationFileTest.php
typo3/sysext/lang/Classes/Service/TerService.php
typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php
typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php
typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php
typo3/sysext/recordlist/Classes/Controller/ElementBrowserFramesetController.php
typo3/sysext/recordlist/Classes/RecordList.php
typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php
typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php
typo3/sysext/reports/ext_tables.php
typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php
typo3/sysext/version/Classes/Dependency/ElementEntityProcessor.php
typo3/sysext/version/Classes/Hook/DataHandlerHook.php
typo3/sysext/workspaces/Classes/Controller/AjaxController.php
typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php
typo3/sysext/workspaces/Classes/Hook/TypoScriptFrontendControllerHook.php
typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php
typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/AbstractActionTestCase.php

index 6c1b925..4da6f7a 100644 (file)
@@ -1,4 +1,5 @@
 <?php
+
 namespace TYPO3\CMS\Backend\Backend\Avatar;
 
 /*
@@ -53,9 +54,10 @@ class Avatar
         }
 
         $cacheId = 'avatar_' . md5(
-                $backendUser['uid'] . '/' .
-                (string)$size . '/' .
-                (string)$showIcon);
+            $backendUser['uid'] . '/' .
+            (string)$size . '/' .
+            (string)$showIcon
+        );
 
         $avatar = static::getCache()->get($cacheId);
 
@@ -142,10 +144,19 @@ class Avatar
         $providers = $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['backend']['avatarProviders'];
         foreach ($providers as $identifier => $configuration) {
             if (empty($configuration) || !is_array($configuration)) {
-                throw new \RuntimeException('Missing configuration for avatar provider "' . $identifier . '".', 1439317801);
+                throw new \RuntimeException(
+                    'Missing configuration for avatar provider "' . $identifier . '".',
+                    1439317801
+                );
             }
-            if (!is_string($configuration['provider']) || empty($configuration['provider']) || !class_exists($configuration['provider']) || !is_subclass_of($configuration['provider'], AvatarProviderInterface::class)) {
-                throw new \RuntimeException('The avatar provider "' . $identifier . '" defines an invalid provider. Ensure the class exists and implements the "' . AvatarProviderInterface::class . '".', 1439317802);
+            if (!is_string($configuration['provider']) || empty($configuration['provider']) || !class_exists($configuration['provider']) || !is_subclass_of(
+                $configuration['provider'],
+                    AvatarProviderInterface::class
+            )) {
+                throw new \RuntimeException(
+                    'The avatar provider "' . $identifier . '" defines an invalid provider. Ensure the class exists and implements the "' . AvatarProviderInterface::class . '".',
+                    1439317802
+                );
             }
         }
 
index b31c442..2a7345f 100644 (file)
@@ -381,8 +381,12 @@ class Clipboard
                             $thumb = [];
                             $folder = $fileObject instanceof \TYPO3\CMS\Core\Resource\Folder;
                             $size = $folder ? '' : '(' . GeneralUtility::formatSize($fileObject->getSize()) . 'bytes)';
-                            if (!$folder && GeneralUtility::inList($GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'],
-                                    $fileObject->getExtension())
+                            if (
+                                !$folder
+                                && GeneralUtility::inList(
+                                    $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'],
+                                    $fileObject->getExtension()
+                                )
                             ) {
                                 $thumb = [
                                     'image' => $fileObject->process(\TYPO3\CMS\Core\Resource\ProcessedFile::CONTEXT_IMAGEPREVIEW, []),
@@ -390,10 +394,14 @@ class Clipboard
                                 ];
                             }
                             $lines[] = [
-                                'icon' => '<span title="' . htmlspecialchars($fileObject->getName() . ' ' . $size) . '">' . $this->iconFactory->getIconForResource($fileObject,
-                                        Icon::SIZE_SMALL)->render() . '</span>',
-                                'title' => $this->linkItemText(htmlspecialchars(GeneralUtility::fixed_lgd_cs($fileObject->getName(),
-                                    $this->getBackendUser()->uc['titleLen'])), $fileObject->getName()),
+                                'icon' => '<span title="' . htmlspecialchars($fileObject->getName() . ' ' . $size) . '">' . $this->iconFactory->getIconForResource(
+                                    $fileObject,
+                                    Icon::SIZE_SMALL
+                                )->render() . '</span>',
+                                'title' => $this->linkItemText(htmlspecialchars(GeneralUtility::fixed_lgd_cs(
+                                    $fileObject->getName(),
+                                    $this->getBackendUser()->uc['titleLen']
+                                )), $fileObject->getName()),
                                 'thumb' => $thumb,
                                 'infoLink' => htmlspecialchars('top.launchView(' . GeneralUtility::quoteJSvalue($table) . ', ' . GeneralUtility::quoteJSvalue($v) . '); return false;'),
                                 'removeLink' => $this->removeUrl('_FILE', GeneralUtility::shortMD5($v))
@@ -408,10 +416,15 @@ class Clipboard
                         $rec = BackendUtility::getRecordWSOL($table, $uid);
                         if (is_array($rec)) {
                             $lines[] = [
-                                'icon' => $this->linkItemText($this->iconFactory->getIconForRecord($table, $rec,
-                                    Icon::SIZE_SMALL)->render(), $rec, $table),
-                                'title' => $this->linkItemText(htmlspecialchars(GeneralUtility::fixed_lgd_cs(BackendUtility::getRecordTitle($table,
-                                    $rec), $this->getBackendUser()->uc['titleLen'])), $rec, $table),
+                                'icon' => $this->linkItemText($this->iconFactory->getIconForRecord(
+                                    $table,
+                                    $rec,
+                                    Icon::SIZE_SMALL
+                                )->render(), $rec, $table),
+                                'title' => $this->linkItemText(htmlspecialchars(GeneralUtility::fixed_lgd_cs(BackendUtility::getRecordTitle(
+                                    $table,
+                                    $rec
+                                ), $this->getBackendUser()->uc['titleLen'])), $rec, $table),
                                 'infoLink' => htmlspecialchars('top.launchView(' . GeneralUtility::quoteJSvalue($table) . ', \'' . (int)$uid . '\'); return false;'),
                                 'removeLink' => $this->removeUrl($table, $uid)
                             ];
index 3091212..45eccca 100644 (file)
@@ -145,7 +145,7 @@ class ElementHistoryController extends AbstractModule
             ->setFieldName('history_log');
         $buttonBar->addButton($helpButton);
 
-         // Get returnUrl parameter
+        // Get returnUrl parameter
         $returnUrl = GeneralUtility::sanitizeLocalUrl(GeneralUtility::_GP('returnUrl'));
         if ($returnUrl) {
             $backButton = $buttonBar->makeLinkButton()
index 2e64689..c977cdd 100644 (file)
@@ -273,14 +273,13 @@ class NewContentElementController extends AbstractModule
                     $icon = $this->moduleTemplate->getIconFactory()->getIcon($wInfo['iconIdentifier'])->render();
 
                     $this->menuItemView->assignMultiple([
-                            'onClickEvent' => $this->onClickEvent,
-                            'aOnClick' => $aOnClick,
-                            'wizardInformation' => $wInfo,
-                            'icon' => $icon,
-                            'wizardOnClick' => $wizardOnClick,
-                            'wizardKey' => $wizardKey
-                        ]
-                    );
+                        'onClickEvent' => $this->onClickEvent,
+                        'aOnClick' => $aOnClick,
+                        'wizardInformation' => $wInfo,
+                        'icon' => $icon,
+                        'wizardOnClick' => $wizardOnClick,
+                        'wizardKey' => $wizardKey
+                    ]);
                     $menuItems[$key]['content'] .= $this->menuItemView->render();
                     $cc++;
                 }
index 0fef121..be023af 100644 (file)
@@ -655,8 +655,8 @@ class EditDocumentController extends AbstractModule
                     } else {
                         $relatedPageId = -$nRec['uid'];
                     }
-                // Determine related page ID for workspace context
                 } else {
+                    // Determine related page ID for workspace context
                     if ($insertRecordOnTop) {
                         // Fetch live version of workspace version since the pid value is always -1 in workspaces
                         $liveRecord = BackendUtility::getRecord($nTable, $nRec['t3ver_oid'], $recordFields);
index 1da7541..2f89118 100644 (file)
@@ -109,9 +109,11 @@ class RenameFileController extends AbstractModule
             $parsedUrl = parse_url($this->returnUrl);
             $queryParts = GeneralUtility::explodeUrl2Array(urldecode($parsedUrl['query']));
             if ($queryParts['id'] === $this->fileOrFolderObject->getCombinedIdentifier()) {
-                $this->returnUrl = str_replace(urlencode($queryParts['id']),
+                $this->returnUrl = str_replace(
+                    urlencode($queryParts['id']),
                     urlencode($this->fileOrFolderObject->getStorage()->getRootLevelFolder()->getCombinedIdentifier()),
-                    $this->returnUrl);
+                    $this->returnUrl
+                );
             }
         }
 
index 2ab2343..f0ac012 100644 (file)
@@ -106,7 +106,8 @@ class FormFlexAjaxController extends AbstractFormEngineAjaxController
                 ['lDEF'][$flexFormFieldName]
                 ['el'][$flexFormContainerIdentifier][$flexFormContainerName]['el']
             )
-            && is_array($formData['databaseRow'][$fieldName]
+            && is_array(
+                $formData['databaseRow'][$fieldName]
                 ['data'][$flexFormSheetName]
                 ['lDEF'][$flexFormFieldName]
                 ['el'][$flexFormContainerIdentifier][$flexFormContainerName]['el']
index da74766..edf47cf 100644 (file)
@@ -331,8 +331,8 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
                     'language' => $parentLanguage,
                     'ids' => [$type],
                 ];
-            // Either localize or synchronize all child elements from default language of the parent element
             } else {
+                // Either localize or synchronize all child elements from default language of the parent element
                 $cmd[$parent['table']][$parent['uid']]['inlineLocalizeSynchronize'] = [
                     'field' => $parent['field'],
                     'language' => $parentLanguage,
index 261143d..4e05998 100644 (file)
@@ -344,10 +344,18 @@ class PageLayoutController
                         )
                     )
                 )
-                ->groupBy('pages_language_overlay.sys_language_uid', 'sys_language.uid', 'sys_language.pid',
-                    'sys_language.tstamp', 'sys_language.hidden', 'sys_language.title',
-                    'sys_language.language_isocode', 'sys_language.static_lang_isocode', 'sys_language.flag',
-                    'sys_language.sorting')
+                ->groupBy(
+                    'pages_language_overlay.sys_language_uid',
+                    'sys_language.uid',
+                    'sys_language.pid',
+                    'sys_language.tstamp',
+                    'sys_language.hidden',
+                    'sys_language.title',
+                    'sys_language.language_isocode',
+                    'sys_language.static_lang_isocode',
+                    'sys_language.flag',
+                    'sys_language.sorting'
+                )
                 ->orderBy('sys_language.sorting');
             if (!$this->getBackendUser()->isAdmin()) {
                 $queryBuilder->andWhere(
index 4e5066e..6c16d1a 100644 (file)
@@ -121,7 +121,8 @@ class EditController extends AbstractWizardController
             HttpUtility::redirect($url);
         } elseif (is_array($config)
             && $this->P['currentSelectedValues']
-            && ($config['type'] === 'select'
+            && (
+                $config['type'] === 'select'
                 && $config['foreign_table']
                 || $config['type'] === 'group'
                 && $config['internal_type'] === 'db'
index 57ccdd9..c957fab 100644 (file)
@@ -61,8 +61,10 @@ class FileThumbnails extends AbstractNode
                 $fileObject = $fileFactory->getFileObject($uidOrPath);
                 if (!$fileObject->isMissing()) {
                     $extension = $fileObject->getExtension();
-                    if (GeneralUtility::inList($GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'],
-                        $extension)
+                    if (GeneralUtility::inList(
+                        $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'],
+                        $extension
+                    )
                     ) {
                         $thumbnailsHtml[] = '<li>';
                         $thumbnailsHtml[] =     '<span class="thumbnail">';
@@ -93,8 +95,13 @@ class FileThumbnails extends AbstractNode
                         . '</li>';
                 } catch (\Exception $exception) {
                     $message = $exception->getMessage();
-                    $flashMessage = GeneralUtility::makeInstance(FlashMessage::class, $message, '',
-                        FlashMessage::ERROR, true);
+                    $flashMessage = GeneralUtility::makeInstance(
+                        FlashMessage::class,
+                        $message,
+                        '',
+                        FlashMessage::ERROR,
+                        true
+                    );
                     $flashMessageService = GeneralUtility::makeInstance(FlashMessageService::class);
                     $defaultFlashMessageQueue = $flashMessageService->getMessageQueueByIdentifier();
                     $defaultFlashMessageQueue->enqueue($flashMessage);
index d86b0ba..68a5a72 100644 (file)
@@ -137,7 +137,9 @@ class OtherLanguageContent extends AbstractNode
                         $field,
                         '',
                         '',
-                        $config['config']['uploadfolder'], 0, ' align="middle"'
+                        $config['config']['uploadfolder'],
+                        0,
+                        ' align="middle"'
                     ) .
                     ($absFilePath ? BackendUtility::wrapClickMenuOnIcon($fileIcon, $absFilePath, 0) : $fileIcon) .
                     $imgPath .
index 7c0453d..1dc508b 100644 (file)
@@ -1034,8 +1034,8 @@ abstract class AbstractItemProvider
                 // Use pid from parent page clause if in flex form context
                 if (!empty($result['flexParentDatabaseRow']['pid'])) {
                     $effectivePid = $result['flexParentDatabaseRow']['pid'];
-                // Use pid from database row if in inline context
                 } elseif (!$effectivePid && !empty($result['databaseRow']['pid'])) {
+                    // Use pid from database row if in inline context
                     $effectivePid = $result['databaseRow']['pid'];
                 }
             }
index 32511ce..2775fcf 100644 (file)
@@ -176,7 +176,8 @@ class DatabaseRowInitializeNew implements FormDataProviderInterface
         }
         $selectorFieldName = $result['inlineParentConfig']['foreign_selector'];
         if (!isset($result['processedTca']['columns'][$selectorFieldName]['config']['type'])
-            || ($result['processedTca']['columns'][$selectorFieldName]['config']['type'] !== 'select'
+            || (
+                $result['processedTca']['columns'][$selectorFieldName]['config']['type'] !== 'select'
                 && $result['processedTca']['columns'][$selectorFieldName]['config']['type'] !== 'group'
             )
         ) {
index 11e3055..f448ca5 100644 (file)
@@ -481,9 +481,8 @@ class TcaFlexProcess implements FormDataProviderInterface
                             ['sheets'][$dataStructureSheetName]['ROOT']['el']
                             [$dataStructureFieldName]['children'] = [];
                     }
-
-                // A "normal" TCA flex form element, no section
                 } else {
+                    // A "normal" TCA flex form element, no section
                     if (isset($dataValues['data'][$dataStructureSheetName]['lDEF'][$dataStructureFieldName])
                         && array_key_exists('vDEF', $dataValues['data'][$dataStructureSheetName]['lDEF'][$dataStructureFieldName])
                     ) {
index d1e076f..4f9c495 100644 (file)
@@ -49,7 +49,9 @@ class TcaGroup implements FormDataProviderInterface
 
             // Sanitize max items, set to 99999 if not defined
             $result['processedTca']['columns'][$fieldName]['config']['maxitems'] = MathUtility::forceIntegerInRange(
-                $fieldConfig['config']['maxitems'], 0, 99999
+                $fieldConfig['config']['maxitems'],
+                0,
+                99999
             );
             if ($result['processedTca']['columns'][$fieldName]['config']['maxitems'] === 0) {
                 $result['processedTca']['columns'][$fieldName]['config']['maxitems'] = 99999;
index acc1680..f127711 100644 (file)
@@ -339,7 +339,8 @@ class TcaInline extends AbstractDatabaseRecordProvider implements FormDataProvid
                     $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang.xlf:formEngine.databaseRecordErrorInlineChildChild'),
                     [ $e->getTableName(), $e->getUid(), $childTableName, (int)$childUid ]
                 );
-                $flashMessage = GeneralUtility::makeInstance(FlashMessage::class,
+                $flashMessage = GeneralUtility::makeInstance(
+                    FlashMessage::class,
                     $message,
                     '',
                     FlashMessage::ERROR
index ad29af9..619ae5b 100644 (file)
@@ -957,7 +957,8 @@ class RecordHistory
 
         if (!isset($this->pageAccessCache[$pageId])) {
             $this->pageAccessCache[$pageId] = BackendUtility::readPageAccess(
-                $pageId, $this->getBackendUser()->getPagePermsClause(1)
+                $pageId,
+                $this->getBackendUser()->getPagePermsClause(1)
             );
         }
 
index 18fcbdc..084e891 100644 (file)
@@ -70,9 +70,8 @@ class RequestHandler implements RequestHandlerInterface
         // Check if the router has the available route and dispatch.
         try {
             return $this->dispatch($request);
-
-        // When token was invalid redirect to login
         } catch (InvalidRequestTokenException $e) {
+            // When token was invalid redirect to login
             $url = GeneralUtility::getIndpEnv('TYPO3_SITE_URL') . TYPO3_mainDir;
             \TYPO3\CMS\Core\Utility\HttpUtility::redirect($url);
         }
index dd090c4..08286a2 100644 (file)
@@ -200,8 +200,8 @@ class ModuleLoader
         // check if there is a navigation component (like the pagetree)
         if (is_array($this->navigationComponents[$name])) {
             $finalModuleConfiguration['navigationComponentId'] = $this->navigationComponents[$name]['componentId'];
-        // navigation component can be overridden by the main module component
         } elseif ($mainModule && is_array($this->navigationComponents[$mainModule]) && $setupInformation['configuration']['inheritNavigationComponentFromMainModule'] !== false) {
+            // navigation component can be overridden by the main module component
             $finalModuleConfiguration['navigationComponentId'] = $this->navigationComponents[$mainModule]['componentId'];
         }
         return $finalModuleConfiguration;
index 6e0d521..3159046 100644 (file)
@@ -181,8 +181,8 @@ class MetaInformation
             $theIcon = BackendUtility::wrapClickMenuOnIcon($iconImg, 'pages', $pageRecord['uid']);
             $uid = $pageRecord['uid'];
             $title = BackendUtility::getRecordTitle('pages', $pageRecord);
-        // If the module is about a FAL resource
         } elseif (is_array($pageRecord) && !empty($pageRecord['combined_identifier'])) {
+            // If the module is about a FAL resource
             try {
                 $resourceObject = ResourceFactory::getInstance()->getInstance()->getObjectFromCombinedIdentifier($pageRecord['combined_identifier']);
                 $fileMountTitle = $resourceObject->getStorage()->getFileMounts()[$resourceObject->getIdentifier()]['title'];
index f9aceb5..1f4c066 100644 (file)
@@ -273,7 +273,9 @@ class PagePositionMap
         $TSconfig = BackendUtility::getModTSconfig($newPagePID, 'mod.newPageWizard');
         $TSconfig = $TSconfig['properties'];
         if (isset($TSconfig['override']) && !empty($TSconfig['override'])) {
-            $url = BackendUtility::getModuleUrl($TSconfig['override'], [
+            $url = BackendUtility::getModuleUrl(
+                $TSconfig['override'],
+                [
                 'positionPid' => $pid,
                 'newPageId'   => $newPagePID,
                 'cmd'         => 'crPage',
index 0953545..68055be 100644 (file)
@@ -4276,7 +4276,8 @@ class BackendUtility
             sprintf(
                 $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_login.xlf:free.software'),
                 ('<a href="' . TYPO3_URL_LICENSE . '" target="_blank">'),
-                '</a> ')
+                '</a> '
+            )
             . $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_login.xlf:keep.notice');
         return $cNotice;
     }
index 806e5a9..b22e0aa 100644 (file)
@@ -122,7 +122,8 @@ class DataProviderCollection implements \TYPO3\CMS\Core\SingletonInterface
     protected function createBackendLayoutCollection($identifier)
     {
         return \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(
-            BackendLayoutCollection::class, $identifier
+            BackendLayoutCollection::class,
+            $identifier
         );
     }
 }
index b313968..e5c72b0 100644 (file)
@@ -933,7 +933,8 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                         'returnUrl' => GeneralUtility::getIndpEnv('REQUEST_URI')
                     ];
                     $url = BackendUtility::getModuleUrl('record_edit', $urlParameters);
-                    $editLink = ($this->getBackendUser()->check('tables_modify', 'pages_language_overlay')
+                    $editLink = (
+                        $this->getBackendUser()->check('tables_modify', 'pages_language_overlay')
                         ? '<a href="' . htmlspecialchars($url) . '" class="btn btn-default btn-sm"'
                         . ' title="' . htmlspecialchars($this->getLanguageService()->getLL('edit')) . '">'
                         . $this->iconFactory->getIcon('actions-open', Icon::SIZE_SMALL)->render() . '</a>'
@@ -951,7 +952,10 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                     $recordIcon = '';
                     if ($this->getBackendUser()->checkLanguageAccess(0)) {
                         $recordIcon = BackendUtility::wrapClickMenuOnIcon(
-                            $this->iconFactory->getIconForRecord('pages', $this->pageRecord, Icon::SIZE_SMALL)->render(), 'pages', $this->id);
+                            $this->iconFactory->getIconForRecord('pages', $this->pageRecord, Icon::SIZE_SMALL)->render(),
+                            'pages',
+                            $this->id
+                        );
                         $urlParameters = [
                             'edit' => [
                                 'pages' => [
@@ -961,7 +965,8 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                             'returnUrl' => GeneralUtility::getIndpEnv('REQUEST_URI')
                         ];
                         $url = BackendUtility::getModuleUrl('record_edit', $urlParameters);
-                        $editLink = ($this->getBackendUser()->check('tables_modify', 'pages_language_overlay')
+                        $editLink = (
+                            $this->getBackendUser()->check('tables_modify', 'pages_language_overlay')
                             ? '<a href="' . htmlspecialchars($url) . '" class="btn btn-default btn-sm"'
                             . ' title="' . htmlspecialchars($this->getLanguageService()->getLL('edit')) . '">'
                             . $this->iconFactory->getIcon('actions-open', Icon::SIZE_SMALL)->render() . '</a>'
@@ -1451,7 +1456,8 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
             . ' class="t3js-paste t3js-paste' . htmlspecialchars($copyMode) . ' ' . htmlspecialchars($cssClass) . ' btn btn-default btn-sm"'
             . ' title="' . htmlspecialchars($this->getLanguageService()->getLL($title)) . '">'
             . $this->iconFactory->getIcon('actions-document-paste-into', Icon::SIZE_SMALL)->render()
-            . '</a>');
+            . '</a>'
+        );
         return $pasteIcon;
     }
 
@@ -1474,7 +1480,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
             $info[] = htmlspecialchars($row[$GLOBALS['TCA']['tt_content']['ctrl']['descriptionColumn']]);
         }
 
-            // Call drawFooter hooks
+        // Call drawFooter hooks
         $drawFooterHooks = &$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawFooter'];
         if (is_array($drawFooterHooks)) {
             foreach ($drawFooterHooks as $className) {
@@ -2089,7 +2095,8 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                 )
                 ->where(
                     $queryBuilder->expr()->eq(
-                        'pages_language_overlay.deleted', $queryBuilder->createNamedParameter(0, \PDO::PARAM_INT)
+                        'pages_language_overlay.deleted',
+                        $queryBuilder->createNamedParameter(0, \PDO::PARAM_INT)
                     ),
                     $queryBuilder->expr()->eq(
                         'pages_language_overlay.pid',
@@ -2109,10 +2116,18 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                         )
                     )
                 )
-                ->groupBy('pages_language_overlay.sys_language_uid', 'sys_language.uid', 'sys_language.pid',
-                    'sys_language.tstamp', 'sys_language.hidden', 'sys_language.title',
-                    'sys_language.language_isocode', 'sys_language.static_lang_isocode', 'sys_language.flag',
-                    'sys_language.sorting')
+                ->groupBy(
+                    'pages_language_overlay.sys_language_uid',
+                    'sys_language.uid',
+                    'sys_language.pid',
+                    'sys_language.tstamp',
+                    'sys_language.hidden',
+                    'sys_language.title',
+                    'sys_language.language_isocode',
+                    'sys_language.static_lang_isocode',
+                    'sys_language.flag',
+                    'sys_language.sorting'
+                )
                 ->orderBy('sys_language.sorting');
             if (!$this->getBackendUser()->isAdmin()) {
                 $queryBuilder->andWhere(
@@ -2406,7 +2421,8 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
         foreach ($theTables as $tName) {
             // Check access and whether the proper extensions are loaded:
             if ($this->getBackendUser()->check('tables_select', $tName)
-                && (isset($this->externalTables[$tName])
+                && (
+                    isset($this->externalTables[$tName])
                     || $tName === 'fe_users' || $tName === 'tt_content'
                     || \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::isLoaded($tName)
                 )
index f981756..1eeff91 100644 (file)
@@ -32,7 +32,9 @@ class BackendLayoutViewTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCa
         $this->backendLayoutView = $this->getAccessibleMock(
             \TYPO3\CMS\Backend\View\BackendLayoutView::class,
             ['getPage', 'getRootLine'],
-            [], '', false
+            [],
+            '',
+            false
         );
     }
 
index d565eeb..3df0f01 100644 (file)
@@ -63,7 +63,8 @@ class BackendUserRepository extends BackendUserGroupRepository
             $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('be_users');
             foreach (['userName', 'uid', 'realName'] as $field) {
                 $searchConstraints[] = $query->like(
-                    $field, '%' . $queryBuilder->escapeLikeWildcards($demand->getUserName()) . '%'
+                    $field,
+                    '%' . $queryBuilder->escapeLikeWildcards($demand->getUserName()) . '%'
                 );
             }
             $constraints[] = $query->logicalOr($searchConstraints);
index ae4efda..ebc59f9 100644 (file)
@@ -323,7 +323,8 @@ class ConfigurationManager
         $localConfigurationFile = $this->getLocalConfigurationFileLocation();
         if (!$this->canWriteConfiguration()) {
             throw new \RuntimeException(
-                $localConfigurationFile . ' is not writable.', 1346323822
+                $localConfigurationFile . ' is not writable.',
+                1346323822
             );
         }
         $configuration = ArrayUtility::sortByKeyRecursive($configuration);
index fb92400..18a89a7 100644 (file)
@@ -130,7 +130,10 @@ class FlexFormTools
                 $hookInstance = GeneralUtility::makeInstance($hookClass);
                 if (method_exists($hookClass, 'getDataStructureIdentifierPreProcess')) {
                     $dataStructureIdentifier = $hookInstance->getDataStructureIdentifierPreProcess(
-                        $fieldTca, $tableName, $fieldName, $row
+                        $fieldTca,
+                        $tableName,
+                        $fieldName,
+                        $row
                     );
                     if (!is_array($dataStructureIdentifier)) {
                         throw new \RuntimeException(
@@ -152,11 +155,19 @@ class FlexFormTools
             $tcaDataStructurePointerField = $fieldTca['config']['ds_pointerField'] ?? null;
             if (!is_array($tcaDataStructureArray) && $tcaDataStructurePointerField) {
                 // "ds" is not an array, but "ds_pointerField" is set -> data structure is found in different table
-                $dataStructureIdentifier = $this->getDataStructureIdentifierFromRecord($fieldTca, $tableName,
-                    $fieldName, $row);
+                $dataStructureIdentifier = $this->getDataStructureIdentifierFromRecord(
+                    $fieldTca,
+                    $tableName,
+                    $fieldName,
+                    $row
+                );
             } elseif (is_array($tcaDataStructureArray)) {
-                $dataStructureIdentifier = $this->getDataStructureIdentifierFromTcaArray($fieldTca, $tableName,
-                    $fieldName, $row);
+                $dataStructureIdentifier = $this->getDataStructureIdentifierFromTcaArray(
+                    $fieldTca,
+                    $tableName,
+                    $fieldName,
+                    $row
+                );
             } else {
                 throw new \RuntimeException(
                     'TCA misconfiguration in table "' . $tableName . '" field "' . $fieldName . '" config section:'
@@ -181,7 +192,11 @@ class FlexFormTools
                 $hookInstance = GeneralUtility::makeInstance($hookClass);
                 if (method_exists($hookClass, 'getDataStructureIdentifierPostProcess')) {
                     $dataStructureIdentifier = $hookInstance->getDataStructureIdentifierPostProcess(
-                        $fieldTca, $tableName, $fieldName, $row, $dataStructureIdentifier
+                        $fieldTca,
+                        $tableName,
+                        $fieldName,
+                        $row,
+                        $dataStructureIdentifier
                     );
                     if (!is_array($dataStructureIdentifier) || empty($dataStructureIdentifier)) {
                         throw new \RuntimeException(
@@ -274,9 +289,11 @@ class FlexFormTools
                     $queryBuilder->addSelect($pointerSubFieldName);
                 }
                 $queryStatement = $queryBuilder->from($tableName)
-                    ->where($queryBuilder->expr()->eq(
+                    ->where(
+                        $queryBuilder->expr()->eq(
                         'uid',
-                        $queryBuilder->createNamedParameter($row[$parentFieldName], \PDO::PARAM_INT))
+                        $queryBuilder->createNamedParameter($row[$parentFieldName], \PDO::PARAM_INT)
+                    )
                     )
                     ->execute();
                 if ($queryStatement->rowCount() !== 1) {
index 7a9f98c..0f12852 100644 (file)
@@ -70,8 +70,8 @@ class ErrorPageController
         string $title,
         string $message,
         int $severity = AbstractMessage::ERROR,
-        int $errorCode = 0): string
-    {
+        int $errorCode = 0
+    ): string {
         $this->severity = $severity;
         $classes = [
             AbstractMessage::NOTICE => 'notice',
index 45f8308..fb96fd2 100644 (file)
@@ -1865,9 +1865,14 @@ class DataHandler
         if ($tcaFieldConf['itemsProcFunc']) {
             /** @var ItemProcessingService $processingService */
             $processingService = GeneralUtility::makeInstance(ItemProcessingService::class);
-            $items = $processingService->getProcessingItems($table, $realPid, $field,
+            $items = $processingService->getProcessingItems(
+                $table,
+                $realPid,
+                $field,
                 $this->checkValue_currentRecord,
-                $tcaFieldConf, $tcaFieldConf['items']);
+                $tcaFieldConf,
+                $tcaFieldConf['items']
+            );
         }
 
         $itemC = count($items);
@@ -1939,8 +1944,14 @@ class DataHandler
         // if no value was found and an itemsProcFunc is defined, check that for the value
         if ($tcaFieldConf['itemsProcFunc'] && empty($res['value'])) {
             $processingService = GeneralUtility::makeInstance(ItemProcessingService::class);
-            $processedItems = $processingService->getProcessingItems($table, $pid, $field, $this->checkValue_currentRecord,
-                $tcaFieldConf, $tcaFieldConf['items']);
+            $processedItems = $processingService->getProcessingItems(
+                $table,
+                $pid,
+                $field,
+                $this->checkValue_currentRecord,
+                $tcaFieldConf,
+                $tcaFieldConf['items']
+            );
 
             foreach ($processedItems as $set) {
                 if ((string)$set[1] === (string)$value) {
@@ -2894,7 +2905,8 @@ class DataHandler
 
         $set = false;
         /** @var FlashMessage $message */
-        $message = GeneralUtility::makeInstance(FlashMessage::class,
+        $message = GeneralUtility::makeInstance(
+            FlashMessage::class,
             sprintf($GLOBALS['LANG']->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:error.invalidEmail'), $value),
             '', // header is optional
             FlashMessage::ERROR,
@@ -3007,7 +3019,8 @@ class DataHandler
                             $dataStructure['sheets'][$sKey]['ROOT']['el'],
                             $pParams,
                             $callBackFunc,
-                            $sKey . '/' . $lKey . '/', $workspaceOptions
+                            $sKey . '/' . $lKey . '/',
+                            $workspaceOptions
                         );
                     }
                 }
@@ -3575,9 +3588,11 @@ class DataHandler
                     $queryBuilder
                         ->select(...$fields)
                         ->from($table)
-                        ->where($queryBuilder->expr()->eq(
+                        ->where(
+                            $queryBuilder->expr()->eq(
                             'pid',
-                            $queryBuilder->createNamedParameter($uid, \PDO::PARAM_INT))
+                            $queryBuilder->createNamedParameter($uid, \PDO::PARAM_INT)
+                        )
                         );
                     if ($isTableWorkspaceEnabled && (int)$this->BE_USER->workspace === 0) {
                         // Table is workspace enabled, user is in default ws -> add t3ver_wsid=0 restriction
@@ -3692,8 +3707,14 @@ class DataHandler
         // This checks if the record can be selected which is all that a copy action requires.
         if ($row === false) {
             if ($this->enableLogging) {
-                $this->log($table, $uid, 3, 0, 1,
-                    'Attempt to rawcopy/versionize record which either does not exist or you don\'t have permission to read');
+                $this->log(
+                    $table,
+                    $uid,
+                    3,
+                    0,
+                    1,
+                    'Attempt to rawcopy/versionize record which either does not exist or you don\'t have permission to read'
+                );
             }
             return null;
         }
@@ -3903,9 +3924,19 @@ class DataHandler
      * @param string $inlineSubType
      * @return mixed
      */
-    protected function copyRecord_processInline($table, $uid, $field, $value, $row, $conf, $realDestPid, $language,
-                                                array $workspaceOptions, $localizationMode, $inlineSubType)
-    {
+    protected function copyRecord_processInline(
+        $table,
+        $uid,
+        $field,
+        $value,
+        $row,
+        $conf,
+        $realDestPid,
+        $language,
+                                                array $workspaceOptions,
+        $localizationMode,
+        $inlineSubType
+    ) {
         // Localization in mode 'keep', isn't a real localization, but keeps the children of the original parent record:
         if ($language > 0 && $localizationMode === 'keep') {
             $value = $inlineSubType === 'field' ? 0 : '';
@@ -3935,7 +3966,8 @@ class DataHandler
                             // id is the original live default child record
                             $newId = $v['id'];
                             $this->versionizeRecord(
-                                $v['table'], $v['id'],
+                                $v['table'],
+                                $v['id'],
                                 (isset($workspaceOptions['label']) ? $workspaceOptions['label'] : 'Auto-created for WS #' . $this->BE_USER->workspace),
                                 (isset($workspaceOptions['delete']) ? $workspaceOptions['delete'] : false)
                             );
@@ -4692,7 +4724,8 @@ class DataHandler
             && $table !== 'pages') {
             $localizationParentRecord = BackendUtility::getRecord(
                 $table,
-                $row[$GLOBALS['TCA'][$table]['ctrl']['transOrigPointerField']]);
+                $row[$GLOBALS['TCA'][$table]['ctrl']['transOrigPointerField']]
+            );
             if ((int)$localizationParentRecord[$GLOBALS['TCA'][$table]['ctrl']['languageField']] !== 0) {
                 if ($this->enableLogging) {
                     $this->newlog('Localization failed; Source record contained a reference to an original record that is not a default record (which is strange)!', 1);
@@ -5655,8 +5688,10 @@ class DataHandler
         // This checks if the record can be selected which is all that a copy action requires.
         if ($row === false) {
             if ($this->enableLogging) {
-                $this->newlog('The record does not exist or you don\'t have correct permissions to make a new version (copy) of this record "' . $table . ':' . $id . '"',
-                    1);
+                $this->newlog(
+                    'The record does not exist or you don\'t have correct permissions to make a new version (copy) of this record "' . $table . ':' . $id . '"',
+                    1
+                );
             }
             return null;
         }
@@ -6182,8 +6217,8 @@ class DataHandler
                 // Update in database (list of children (csv) or number of relations (foreign_field)):
                 if (!empty($field)) {
                     $this->updateDB($table, $id, [$field => $newValue]);
-                // Collect data to update FlexForms
                 } elseif (!empty($additionalData['flexFormId']) && !empty($additionalData['flexFormPath'])) {
+                    // Collect data to update FlexForms
                     $flexFormId = $additionalData['flexFormId'];
                     $flexFormPath = $additionalData['flexFormPath'];
 
@@ -6281,7 +6316,9 @@ class DataHandler
         // Do recursive processing of the XML data:
         foreach ($modifications as $path => $value) {
             $valueStructure['data'] = ArrayUtility::setValueByPath(
-                $valueStructure['data'], $path, $value
+                $valueStructure['data'],
+                $path,
+                $value
             );
         }
 
@@ -6497,8 +6534,8 @@ class DataHandler
         $res = false;
         if ($insertTable === 'pages') {
             $perms = $this->pMap['new'];
-        // @todo: find a more generic way to handle content relations of a page (without needing content editing access to that page)
         } elseif (($insertTable === 'sys_file_reference') && array_key_exists('pages', $this->datamap)) {
+            // @todo: find a more generic way to handle content relations of a page (without needing content editing access to that page)
             $perms = $this->pMap['edit'];
         } else {
             $perms = $this->pMap['editcontent'];
@@ -6585,8 +6622,10 @@ class DataHandler
      */
     protected function doesRecordExist_pageLookUp($id, $perms, $columns = ['uid'])
     {
-        $cacheId = md5('doesRecordExist_pageLookUp' . '_' . $id . '_' . $perms . '_' . implode('_',
-                $columns) . '_' . (string)$this->admin);
+        $cacheId = md5('doesRecordExist_pageLookUp' . '_' . $id . '_' . $perms . '_' . implode(
+            '_',
+                $columns
+        ) . '_' . (string)$this->admin);
 
         // If result is cached, return it
         $cachedResult = $this->runtimeCache->get($cacheId);
@@ -7693,14 +7732,14 @@ class DataHandler
         // Thus, check whether strings are the same or whether integer values are empty ("0" or "").
         if (!$allowNull) {
             $result = (string)$submittedValue === (string)$storedValue || $storedType === 'int' && (int)$storedValue === (int)$submittedValue;
-        // Null values are allowed, but currently there's a real (not NULL) value.
+            // Null values are allowed, but currently there's a real (not NULL) value.
         // Thus, ensure no NULL value was submitted and fallback to the regular behaviour.
         } elseif ($storedValue !== null) {
             $result = (
                 $submittedValue !== null
                 && $this->isSubmittedValueEqualToStoredValue($submittedValue, $storedValue, $storedType, false)
             );
-        // Null values are allowed, and currently there's a NULL value.
+            // Null values are allowed, and currently there's a NULL value.
         // Thus, check whether a NULL value was submitted.
         } else {
             $result = ($submittedValue === null);
@@ -9026,9 +9065,9 @@ class DataHandler
                     $value,
                     $haystack[$key]
                 );
-            // Field has not been activated in the user interface,
-            // thus a NULL value shall be stored in the database
             } elseif ($value == 0) {
+                // Field has not been activated in the user interface,
+                // thus a NULL value shall be stored in the database
                 $haystack[$key] = null;
             }
         }
index e8cfda5..b1fea73 100644 (file)
@@ -269,14 +269,14 @@ class DataMapItem
             // implicit: default language, it's a parent
             if ($this->language === 0) {
                 $this->type = static::TYPE_PARENT;
-            // implicit: having source value different to parent value, it's a 2nd or higher level translation
             } elseif (
+                // implicit: having source value different to parent value, it's a 2nd or higher level translation
                 $this->source !== null
                 && $this->source !== $this->parent
             ) {
                 $this->type = static::TYPE_GRAND_CHILD;
-            // implicit: otherwise, it's a 1st level translation
             } else {
+                // implicit: otherwise, it's a 1st level translation
                 $this->type = static::TYPE_DIRECT_CHILD;
             }
         }
@@ -454,14 +454,14 @@ class DataMapItem
                 $this->tableName,
                 $this->persistedValues['l10n_state'] ?? null
             );
-        // use provided states for a new and copied element
         } elseif (is_string($this->suggestedValues['l10n_state'] ?? null)) {
+            // use provided states for a new and copied element
             $state = State::fromJSON(
                 $this->tableName,
                 $this->suggestedValues['l10n_state']
             );
-        // provide the default states
         } else {
+            // provide the default states
             $state = State::create($this->tableName);
         }
         // switch "custom" to "source" state for 2nd level translations
index 9a18b5e..a44bc2e 100644 (file)
@@ -392,11 +392,11 @@ class DataMapProcessor
         // retrieve value from in-memory data-map
         if ($this->isSetInDataMap($item->getFromTableName(), $fromId, $fieldName)) {
             $fromValue = $this->allDataMap[$item->getFromTableName()][$fromId][$fieldName];
-        // retrieve value from record
         } elseif (array_key_exists($fieldName, $fromRecord)) {
+            // retrieve value from record
             $fromValue = $fromRecord[$fieldName];
-        // otherwise abort synchronization
         } else {
+            // otherwise abort synchronization
             return;
         }
 
@@ -407,11 +407,11 @@ class DataMapProcessor
                 $item->getId(),
                 [$fieldName => $fromValue]
             );
-        // direct relational values
         } elseif (!$this->isInlineRelationField($item->getFromTableName(), $fieldName)) {
+            // direct relational values
             $this->synchronizeDirectRelations($item, $fieldName, $fromRecord);
-        // inline relational values
         } else {
+            // inline relational values
             $this->synchronizeInlineRelations($item, $fieldName, $fromRecord, $forRecord);
         }
     }
@@ -583,8 +583,8 @@ class DataMapProcessor
             // if child table is not aware of localization, just copy
             if ($isLocalizationModeExclude || !$isTranslatable) {
                 $localCommandMap[$foreignTableName][$createAncestorId]['copy'] = -$createAncestorId;
-            // otherwise, trigger the localization process
             } else {
+                // otherwise, trigger the localization process
                 $localCommandMap[$foreignTableName][$createAncestorId]['localize'] = $item->getLanguage();
             }
         }
@@ -664,8 +664,8 @@ class DataMapProcessor
                 $this->allDataMap[$item->getFromTableName()][$fromId][$fieldName],
                 true
             );
-        // determine suggested elements of either translation parent or source record from storage
         } elseif (MathUtility::canBeInterpretedAsInteger($fromId)) {
+            // determine suggested elements of either translation parent or source record from storage
             $relationHandler = $this->createRelationHandler();
             $relationHandler->start(
                 $fromRecord[$fieldName],
@@ -968,18 +968,18 @@ class DataMapProcessor
             // implicit: use origin pointer if table cannot be translated
             if (!$isTranslatable) {
                 $ancestorId = (int)$dependentElement[$fieldNames['origin']];
-            // only consider element if it reflects the desired language
+                // only consider element if it reflects the desired language
             } elseif ((int)$dependentElement[$fieldNames['language']] === $desiredLanguage) {
                 $ancestorId = $this->resolveAncestorId($fieldNames, $dependentElement);
-            // otherwise skip the element completely
             } else {
+                // otherwise skip the element completely
                 continue;
             }
             // only keep ancestors that were initially requested before expanding
             if (in_array($ancestorId, $ids)) {
                 $dependentIdMap[$ancestorId] = $dependentId;
-            // resolve from previously expanded search criteria
             } elseif (!empty($ancestorIdMap[$ancestorId])) {
+                // resolve from previously expanded search criteria
                 $possibleChainedIds = array_intersect(
                     $ids,
                     $ancestorIdMap[$ancestorId]
@@ -1047,16 +1047,16 @@ class DataMapProcessor
                 // any parent or source pointers
                 $queryBuilder->expr()->orX(...$ancestorPredicates),
             ];
-        // fetch by origin dependency ("copied from")
         } elseif (!empty($fieldNames['origin'])) {
+            // fetch by origin dependency ("copied from")
             $predicates = [
                 $queryBuilder->expr()->in(
                     $fieldNames['origin'],
                     $idsParameter
                 )
             ];
-        // otherwise: stop execution
         } else {
+            // otherwise: stop execution
             throw new \InvalidArgumentException(
                 'Invalid combination of query field names given',
                 1487192370
@@ -1156,8 +1156,8 @@ class DataMapProcessor
             && $element[$fieldNames['source']] !== $element[$fieldNames['parent']]
         ) {
             return (int)$fieldNames['source'];
-        // implicit: use parent pointer if defined
         } elseif (!empty($fieldNames['parent'])) {
+            // implicit: use parent pointer if defined
             return (int)$element[$fieldNames['parent']];
         }
         return null;
index 1e56cf1..ba335d3 100644 (file)
@@ -255,8 +255,8 @@ class PlainDataResolver
             if (isset($ids[$movePlaceholderId])) {
                 $ids[$movePlaceholderId] = $liveReferenceId;
                 unset($ids[$liveReferenceId]);
-            // Just purge live reference
             } elseif (!$this->keepMovePlaceholder) {
+                // Just purge live reference
                 unset($ids[$liveReferenceId]);
             }
         }
index 52e92a4..876a80b 100644 (file)
@@ -1591,7 +1591,9 @@ class QueryGenerator
         } else {
             $queryBuilder->getRestrictions()->removeAll()->add(GeneralUtility::makeInstance(DeletedRestriction::class));
         }
-        $fieldList = GeneralUtility::trimExplode(',', $this->extFieldLists['queryFields']
+        $fieldList = GeneralUtility::trimExplode(
+            ',',
+            $this->extFieldLists['queryFields']
             . ',pid'
             . ($GLOBALS['TCA'][$this->table]['ctrl']['delete'] ? ',' . $GLOBALS['TCA'][$this->table]['ctrl']['delete'] : '')
         );
index d7a31b6..07e7379 100644 (file)
@@ -443,8 +443,8 @@ class RelationHandler
                 foreach ($this->itemArray as &$item) {
                     $item['id'] = $this->getLiveDefaultId($item['table'], $item['id']);
                 }
-            // Directly overlay workspace data
             } else {
+                // Directly overlay workspace data
                 $this->itemArray = [];
                 $foreignTable = $configuration['foreign_table'];
                 $ids = $this->getResolver($foreignTable, $this->tableArray[$foreignTable])->get();
@@ -1385,8 +1385,8 @@ class RelationHandler
         // Ensure, only live relations are in the items Array
         if ($workspaceId === 0) {
             $purgeCallback = 'purgeVersionedIds';
-        // Otherwise, ensure that live relations are purged if version exists
         } else {
+            // Otherwise, ensure that live relations are purged if version exists
             $purgeCallback = 'purgeLiveVersionedIds';
         }
 
index 17c2749..a74856f 100644 (file)
@@ -137,7 +137,7 @@ class UploadedFile implements UploadedFileInterface
         return $this->stream;
     }
 
-     /**
+    /**
      * Move the uploaded file to a new location.
      *
      * Use this method as an alternative to move_uploaded_file(). This method is
index 00afae9..bf8cdb9 100644 (file)
@@ -2613,7 +2613,9 @@ class GraphicalFunctions
         }
         $newFile = PATH_site . 'typo3temp/assets/images/' . md5($theFile . '|' . filemtime($theFile)) . ($output_png ? '.png' : '.gif');
         $cmd = CommandUtility::imageMagickCommand(
-            'convert', '"' . $theFile . '" "' . $newFile . '"', $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_path']
+            'convert',
+            '"' . $theFile . '" "' . $newFile . '"',
+            $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_path']
         );
         CommandUtility::exec($cmd);
         if (@is_file($newFile)) {
index 37dfe90..0cdbea3 100644 (file)
@@ -425,8 +425,6 @@ class IconFactory
                     $overlayIdentifier = 'overlay-locked';
                 }
             }
-
-        // File
         } elseif ($resource instanceof File) {
             $mimeTypeIcon = $this->iconRegistry->getIconIdentifierForMimeType($resource->getMimeType());
 
index 1500fcc..8865e40 100644 (file)
@@ -170,14 +170,14 @@ class LanguageService
         if (strpos($input, 'LLL:') === 0) {
             $restStr = trim(substr($input, 4));
             $extPrfx = '';
-                // ll-file referred to is found in an extension.
+            // ll-file referred to is found in an extension.
             if (strpos($restStr, 'EXT:') === 0) {
                 $restStr = trim(substr($restStr, 4));
                 $extPrfx = 'EXT:';
             }
             $parts = explode(':', $restStr);
             $parts[0] = $extPrfx . $parts[0];
-                // Getting data if not cached
+            // Getting data if not cached
             if (!isset($this->LL_files_cache[$parts[0]])) {
                 $this->LL_files_cache[$parts[0]] = $this->readLLfile($parts[0]);
             }
@@ -201,31 +201,31 @@ class LanguageService
     public function loadSingleTableDescription($table)
     {
         // First the 'table' cannot already be loaded in [columns]
-            // and secondly there must be a references to locallang files available in [refs]
+        // and secondly there must be a references to locallang files available in [refs]
         if (is_array($GLOBALS['TCA_DESCR'][$table]) && !isset($GLOBALS['TCA_DESCR'][$table]['columns']) && is_array($GLOBALS['TCA_DESCR'][$table]['refs'])) {
             // Init $TCA_DESCR for $table-key
             $GLOBALS['TCA_DESCR'][$table]['columns'] = [];
-                // Get local-lang for each file in $TCA_DESCR[$table]['refs'] as they are ordered.
+            // Get local-lang for each file in $TCA_DESCR[$table]['refs'] as they are ordered.
             foreach ($GLOBALS['TCA_DESCR'][$table]['refs'] as $llfile) {
                 $localLanguage = $this->includeLLFile($llfile, false, true);
-                    // Traverse all keys
+                // Traverse all keys
                 if (is_array($localLanguage['default'])) {
                     foreach ($localLanguage['default'] as $lkey => $lVal) {
                         // Exploding by '.':
-                            // 0-n => fieldname,
-                            // n+1 => type from (alttitle, description, details, syntax, image_descr,image,seeAlso),
-                            // n+2 => special instruction, if any
+                        // 0-n => fieldname,
+                        // n+1 => type from (alttitle, description, details, syntax, image_descr,image,seeAlso),
+                        // n+2 => special instruction, if any
                         $keyParts = explode('.', $lkey);
                         $keyPartsCount = count($keyParts);
-                            // Check if last part is special instruction
-                            // Only "+" is currently supported
+                        // Check if last part is special instruction
+                        // Only "+" is currently supported
                         $specialInstruction = $keyParts[$keyPartsCount - 1] === '+';
                         if ($specialInstruction) {
                             array_pop($keyParts);
                         }
-                            // If there are more than 2 parts, get the type from the last part
-                            // and merge back the other parts with a dot (.)
-                            // Otherwise just get type and field name straightaway
+                        // If there are more than 2 parts, get the type from the last part
+                        // and merge back the other parts with a dot (.)
+                        // Otherwise just get type and field name straightaway
                         if ($keyPartsCount > 2) {
                             $type = array_pop($keyParts);
                             $fieldName = implode('.', $keyParts);
@@ -233,14 +233,14 @@ class LanguageService
                             $fieldName = $keyParts[0];
                             $type = $keyParts[1];
                         }
-                            // Detecting 'hidden' labels, converting to normal fieldname
+                        // Detecting 'hidden' labels, converting to normal fieldname
                         if ($fieldName === '_') {
                             $fieldName = '';
                         }
                         if ($fieldName !== '' && $fieldName[0] === '_') {
                             $fieldName = substr($fieldName, 1);
                         }
-                            // Append label
+                        // Append label
                         $label = $lVal[0]['target'] ? :
                             $lVal[0]['source'];
                         if ($specialInstruction) {
@@ -267,7 +267,7 @@ class LanguageService
     public function includeLLFile($fileRef, $setGlobal = true, $mergeLocalOntoDefault = false)
     {
         $globalLanguage = [];
-            // Get default file
+        // Get default file
         $localLanguage = $this->readLLfile($fileRef);
         if (is_array($localLanguage) && !empty($localLanguage)) {
             // it depends on, whether we should return the result or set it in the global $LOCAL_LANG array
@@ -277,15 +277,15 @@ class LanguageService
             } else {
                 $globalLanguage = $localLanguage;
             }
-                // Merge local onto default
+            // Merge local onto default
             if ($mergeLocalOntoDefault && $this->lang !== 'default' && is_array($globalLanguage[$this->lang]) && is_array($globalLanguage['default'])) {
                 // array_merge can be used so far the keys are not
-                    // numeric - which we assume they are not...
+                // numeric - which we assume they are not...
                 $globalLanguage['default'] = array_merge($globalLanguage['default'], $globalLanguage[$this->lang]);
                 unset($globalLanguage[$this->lang]);
             }
         }
-            // Return value if not global is set.
+        // Return value if not global is set.
         if (!$setGlobal) {
             return $globalLanguage;
         } else {
@@ -323,7 +323,7 @@ class LanguageService
             }
             if ($this->lang !== 'default' && isset($tempLL[$language])) {
                 // Merge current language labels onto labels from previous language
-                    // This way we have a labels with fall back applied
+                // This way we have a labels with fall back applied
                 ArrayUtility::mergeRecursiveWithOverrule($localLanguage[$this->lang], $tempLL[$language], true, false);
             }
         }
index 6ec7996..56d7788 100644 (file)
@@ -335,6 +335,7 @@ class Rfc822AddressesParser
                     if ($slashes % 2 == 0) {
                         $in_quote = !$in_quote;
                     }
+                    // no break
                 default:
                     $slashes = 0;
             }
index 25205da..093819d 100644 (file)
@@ -2052,7 +2052,8 @@ class TcaMigration
                                     && isset($wizardConfig['module']['name'])
                                     && $wizardConfig['module']['name'] === 'wizard_rte'
                                     && !isset($fieldConfig['config']['fieldControl']['fullScreenRichtext'])
-                                    && (!isset($fieldConfig['config']['enableRichtext'])
+                                    && (
+                                        !isset($fieldConfig['config']['enableRichtext'])
                                         || isset($fieldConfig['config']['enableRichtext']) && (bool)$fieldConfig['config']['enableRichtext'] === false
                                     )
                                 ) {
index 677d620..2f860a3 100644 (file)
@@ -73,7 +73,8 @@ class DependencyResolver
                         throw new \UnexpectedValueException(
                             'The package "' . $packageKey . '" depends on "'
                             . $dependentPackageKey . '" which is not present in the system.',
-                            1382276561);
+                            1382276561
+                        );
                     }
                     $dependencies[$packageKey]['after'][] = $dependentPackageKey;
                 }
@@ -119,7 +120,8 @@ class DependencyResolver
             // The order of the array_merge is crucial here,
             // we want the framework first
             $packageStateConfiguration[$packageKey]['dependencies'] = array_merge(
-                $rootPackageKeys, $packageKeysWithoutFramework
+                $rootPackageKeys,
+                $packageKeysWithoutFramework
             );
         }
         return $packageStateConfiguration;
index ad556e1..14afcce 100644 (file)
@@ -1985,7 +1985,7 @@ class PageRenderer implements \TYPO3\CMS\Core\SingletonInterface
         if ($this->addRequireJs) {
             // load the paths of the requireJS configuration
             $out .= GeneralUtility::wrapJS('var require = ' . json_encode($this->requireJsConfig)) . LF;
-                // directly after that, include the require.js file
+            // directly after that, include the require.js file
             $out .= '<script src="' . $this->processJsFile($this->requireJsPath . 'require.js') . '" type="text/javascript"></script>' . LF;
         }
 
index 79f0900..2f77ecb 100644 (file)
@@ -114,7 +114,8 @@ class DriverRegistry implements \TYPO3\CMS\Core\SingletonInterface
         if (!array_key_exists($shortName, $this->drivers)) {
             throw new \InvalidArgumentException(
                 'Desired storage "' . $shortName . '" is not in the list of available storages.',
-                1314085990);
+                1314085990
+            );
         }
         return $this->drivers[$shortName];
     }
index 4836de5..b453616 100644 (file)
@@ -1144,7 +1144,9 @@ class LocalDriver extends AbstractHierarchicalFilesystemDriver
             throw new \RuntimeException(
                 sprintf(
                     'Creating filename mapping after renaming "%1$s" to "%2$s" failed. Reverted rename operation.\\n\\nOriginal error: %3$s"',
-                    $sourcePath, $targetPath, $e->getMessage()
+                    $sourcePath,
+                    $targetPath,
+                    $e->getMessage()
                 ),
                 1334160746
             );
index 072e2de..695c7d5 100644 (file)
@@ -114,7 +114,11 @@ class FileRepository extends AbstractRepository
             /** @var $relationHandler RelationHandler */
             $relationHandler = GeneralUtility::makeInstance(RelationHandler::class);
             $relationHandler->start(
-                '', 'sys_file_reference', '', $uid, $tableName,
+                '',
+                'sys_file_reference',
+                '',
+                $uid,
+                $tableName,
                 BackendUtility::getTcaFieldConfiguration($tableName, $fieldName)
             );
             if (!empty($relationHandler->tableArray['sys_file_reference'])) {
index eca664d..1f44acc 100644 (file)
@@ -275,8 +275,10 @@ class FileIndexRepository implements SingletonInterface
                     $queryBuilder->andWhere(
                         $queryBuilder->expr()->like(
                             'name',
-                            $queryBuilder->createNamedParameter('%' . $queryBuilder->escapeLikeWildcards($part) . '%',
-                                \PDO::PARAM_STR)
+                            $queryBuilder->createNamedParameter(
+                                '%' . $queryBuilder->escapeLikeWildcards($part) . '%',
+                                \PDO::PARAM_STR
+                            )
                         )
                     );
                 }
index 961e95e..7a6b2a7 100644 (file)
@@ -99,7 +99,8 @@ class YouTubeHelper extends AbstractOEmbedHelper
      */
     protected function getOEmbedUrl($mediaId, $format = 'json')
     {
-        return sprintf('https://www.youtube.com/oembed?url=%s&format=%s',
+        return sprintf(
+            'https://www.youtube.com/oembed?url=%s&format=%s',
             urlencode(sprintf('https://www.youtube.com/watch?v=%s', $mediaId)),
             rawurlencode($format)
         );
index 2055301..c9307ce 100644 (file)
@@ -69,8 +69,8 @@ abstract class AbstractGraphicalTask extends AbstractTask
             $targetFileExtension = $this->configuration['fileExtension'];
         } elseif (in_array($this->getSourceFile()->getExtension(), ['jpg', 'jpeg', 'png', 'gif'], true)) {
             $targetFileExtension = $this->getSourceFile()->getExtension();
-        // If true, thumbnails from non-processable files will be converted to 'png', otherwise 'gif'
         } elseif ($GLOBALS['TYPO3_CONF_VARS']['GFX']['thumbnails_png']) {
+            // If true, thumbnails from non-processable files will be converted to 'png', otherwise 'gif'
             $targetFileExtension = 'png';
         } else {
             $targetFileExtension = 'gif';
index f765722..101258c 100644 (file)
@@ -121,9 +121,8 @@ class LocalCropScaleMaskHelper
                     1 => $newDimensions['height'],
                     3 => '' // no file = use original
                 ];
-
-            // all other images
             } else {
+                // all other images
                 // the result info is an array with 0=width,1=height,2=extension,3=filename
                 $result = $gifBuilder->imageMagickConvert(
                     $originalFileName,
index 7d37934..2798fb8 100644 (file)
@@ -79,17 +79,15 @@ class LocalImageProcessor implements ProcessorInterface
                     ['width' => $imageDimensions[0], 'height' => $imageDimensions[1], 'size' => filesize($result['filePath']), 'checksum' => $task->getConfigurationChecksum()]
                 );
                 $task->getTargetFile()->updateWithLocalFile($result['filePath']);
-
-            // New dimensions + no new file (for instance svg)
             } elseif (!empty($result['width']) && !empty($result['height']) && empty($result['filePath'])) {
+                // New dimensions + no new file (for instance svg)
                 $task->setExecuted(true);
                 $task->getTargetFile()->setUsesOriginalFile();
                 $task->getTargetFile()->updateProperties(
                     ['width' => $result['width'], 'height' => $result['height'], 'size' => $task->getSourceFile()->getSize(), 'checksum' => $task->getConfigurationChecksum()]
                 );
-
-            // Seems we have no valid processing result
             } else {
+                // Seems we have no valid processing result
                 $task->setExecuted(false);
             }
         } catch (\Exception $e) {
index 3f62388..26d2cf1 100644 (file)
@@ -122,7 +122,8 @@ class ResourceCompressor
             if (
                 !isset($options['baseDirectories'])
                 || $this->checkBaseDirectory(
-                    $filenameFromMainDir, array_merge($options['baseDirectories'], [$this->targetDirectory])
+                    $filenameFromMainDir,
+                    array_merge($options['baseDirectories'], [$this->targetDirectory])
                 )
             ) {
                 $type = isset($fileOptions['media']) ? strtolower($fileOptions['media']) : 'all';
@@ -674,7 +675,8 @@ class ResourceCompressor
         // There are different conditions for removing leading and trailing
         // whitespace.
         // @see http://php.net/manual/regexp.reference.subpatterns.php
-        $contents = preg_replace('<
+        $contents = preg_replace(
+            '<
                                # Strip leading and trailing whitespace.
                                \s*([@{};,])\s*
                                # Strip only leading whitespace from:
index d626c39..7aa9945 100644 (file)
@@ -1647,7 +1647,8 @@ class ResourceStorage implements ResourceStorageInterface
         // Cache-Control header is needed here to solve an issue with browser IE8 and lower
         // See for more information: http://support.microsoft.com/kb/323308
         header("Cache-Control: ''");
-        header('Last-Modified: ' .
+        header(
+            'Last-Modified: ' .
             gmdate('D, d M Y H:i:s', array_pop($this->driver->getFileInfoByIdentifier($file->getIdentifier(), ['mtime']))) . ' GMT',
             true,
             200
@@ -2339,7 +2340,10 @@ class ResourceStorage implements ResourceStorageInterface
                 $parentPermissions = $this->driver->getPermissions($this->driver->getParentFolderIdentifierOfIdentifier($identifier));
                 if ($parentPermissions['r']) {
                     $folder = GeneralUtility::makeInstance(
-                        InaccessibleFolder::class, $this, $data['identifier'], $data['name']
+                        InaccessibleFolder::class,
+                        $this,
+                        $data['identifier'],
+                        $data['name']
                     );
                 }
             }
@@ -2879,11 +2883,17 @@ class ResourceStorage implements ResourceStorageInterface
                 }
             } catch (Exception\InsufficientFolderWritePermissionsException $e) {
                 $this->processingFolder = GeneralUtility::makeInstance(
-                    InaccessibleFolder::class, $this, $processingFolder, $processingFolder
+                    InaccessibleFolder::class,
+                    $this,
+                    $processingFolder,
+                    $processingFolder
                 );
             } catch (Exception\ResourcePermissionsUnavailableException $e) {
                 $this->processingFolder = GeneralUtility::makeInstance(
-                    InaccessibleFolder::class, $this, $processingFolder, $processingFolder
+                    InaccessibleFolder::class,
+                    $this,
+                    $processingFolder,
+                    $processingFolder
                 );
             }
         }
index 591818b..65727fd 100644 (file)
@@ -87,7 +87,8 @@ class UserStorageCapabilityService
                        </div>
                </div>';
 
-        $content = sprintf($template,
+        $content = sprintf(
+            $template,
             $isPublic ? 'checked="checked"' : ''
         );
 
index 44d5f95..c8dac34 100644 (file)
@@ -220,7 +220,7 @@ class StorageRepository extends AbstractRepository
         $flexObj = GeneralUtility::makeInstance(FlexFormTools::class);
         $flexFormXml = $flexObj->flexArray2Xml($flexFormData, true);
 
-            // create the record
+        // create the record
         $field_values = [
             'pid' => 0,
             'tstamp' => $GLOBALS['EXEC_TIME'],
index b9bcf99..b02cae5 100644 (file)
@@ -296,8 +296,13 @@ class MarkerBasedTemplateService
             }
             if (!empty($markersAndSubparts[$subpartMarker])) {
                 foreach ($markersAndSubparts[$subpartMarker] as $partialMarkersAndSubparts) {
-                    $subpartSubstitutes[$completeMarker] .= $this->substituteMarkerAndSubpartArrayRecursive($subTemplates[$completeMarker],
-                        $partialMarkersAndSubparts, $wrap, $uppercase, $deleteUnused);
+                    $subpartSubstitutes[$completeMarker] .= $this->substituteMarkerAndSubpartArrayRecursive(
+                        $subTemplates[$completeMarker],
+                        $partialMarkersAndSubparts,
+                        $wrap,
+                        $uppercase,
+                        $deleteUnused
+                    );
                 }
             } else {
                 $subpartSubstitutes[$completeMarker] = '';
index 282ee3a..2bd65e8 100644 (file)
@@ -81,7 +81,8 @@ abstract class Enumeration implements TypeInterface
         if (empty($constants)) {
             throw new Exception\InvalidEnumerationValueException(
                 sprintf(
-                    'No constants defined in enumeration "%s"', $class
+                    'No constants defined in enumeration "%s"',
+                    $class
                 ),
                 1381512807
             );
index d9bbf33..c9de84d 100644 (file)
@@ -96,9 +96,8 @@ class ImageInfo extends FileInfo
         // First check if width+height are set
         if (!empty($xmlAttributes['width']) && !empty($xmlAttributes['height'])) {
             $imagesSizes = [(int)$xmlAttributes['width'], (int)$xmlAttributes['height']];
-
-        // Fallback to viewBox
         } elseif (!empty($xmlAttributes['viewBox'])) {
+            // Fallback to viewBox
             $viewBox = explode(' ', $xmlAttributes['viewBox']);
             $imagesSizes = [(int)$viewBox[2], (int)$viewBox[3]];
         }
index d8fb670..58d95aa 100644 (file)
@@ -747,7 +747,12 @@ class ExtendedTemplateService extends TemplateService
      * @return string
      */
     public function ext_outputTS(
-        array $config, $lineNumbers = false, $comments = false, $crop = false, $syntaxHL = false, $syntaxHLBlockmode = 0
+        array $config,
+        $lineNumbers = false,
+        $comments = false,
+        $crop = false,
+        $syntaxHL = false,
+        $syntaxHLBlockmode = 0
     ) {
         $all = '';
         foreach ($config as $str) {
index c968d82..ac2a98b 100644 (file)
@@ -1200,8 +1200,11 @@ class TemplateService
         $TSdataArray[] = $GLOBALS['TYPO3_CONF_VARS']['BE']['defaultPageTSconfig'];
         for ($a = 0; $a <= $this->outermostRootlineIndexWithTemplate; $a++) {
             if (trim($this->absoluteRootLine[$a]['tsconfig_includes'])) {
-                $includeTsConfigFileList = GeneralUtility::trimExplode(',',
-                    $this->absoluteRootLine[$a]['tsconfig_includes'], true);
+                $includeTsConfigFileList = GeneralUtility::trimExplode(
+                    ',',
+                    $this->absoluteRootLine[$a]['tsconfig_includes'],
+                    true
+                );
 
                 $TSdataArray = $this->mergeConstantsFromIncludedTsConfigFiles($includeTsConfigFileList, $TSdataArray);
             }
@@ -1394,8 +1397,8 @@ class TemplateService
         // only show a separator if there are both site title and page title
         if ($pageTitle === '' || $siteTitle === '') {
             $pageTitleSeparator = '';
-        // use the default separator if non given
         } elseif (empty($pageTitleSeparator)) {
+            // use the default separator if non given
             $pageTitleSeparator = ': ';
         }
         return $siteTitle . $pageTitleSeparator . $pageTitle;
index b9efd5e..c4bd977 100644 (file)
@@ -36,7 +36,8 @@ class ArrayUtility
                     'The options "%s" were not allowed (allowed were: "%s")',
                     implode(', ', $notAllowedArrayKeys),
                     implode(', ', $allowedArrayKeys)
-                ), 1325697085
+                ),
+                1325697085
             );
         }
     }
index 533e8e8..1a69d7d 100644 (file)
@@ -153,11 +153,11 @@ class CommandUtility
         if ($handler && !self::checkCommand($handler)) {
             return -1;
         }
-            // Already checked and valid
+        // Already checked and valid
         if (self::$applications[$cmd]['valid']) {
             return true;
         }
-            // Is set but was (above) not TRUE
+        // Is set but was (above) not TRUE
         if (isset(self::$applications[$cmd]['valid'])) {
             return false;
         }
@@ -167,7 +167,7 @@ class CommandUtility
             if ($validPath) {
                 if (TYPO3_OS === 'WIN') {
                     // Windows OS
-                        // @todo Why is_executable() is not called here?
+                    // @todo Why is_executable() is not called here?
                     if (@is_file($path . $cmd)) {
                         self::$applications[$cmd]['app'] = $cmd;
                         self::$applications[$cmd]['path'] = $path;
@@ -193,8 +193,8 @@ class CommandUtility
             }
         }
 
-            // Try to get the executable with the command 'which'.
-            // It does the same like already done, but maybe on other paths
+        // Try to get the executable with the command 'which'.
+        // It does the same like already done, but maybe on other paths
         if (TYPO3_OS !== 'WIN') {
             $cmd = @self::exec('which ' . $cmd);
             if (@is_executable($cmd)) {
@@ -302,12 +302,12 @@ class CommandUtility
     {
         $doCheck = false;
 
-            // Init global paths array if not already done
+        // Init global paths array if not already done
         if (!is_array(self::$paths)) {
             self::$paths = self::getPathsInternal();
             $doCheck = true;
         }
-            // Merge the submitted paths array to the global
+        // Merge the submitted paths array to the global
         if ($paths) {
             $paths = GeneralUtility::trimExplode(',', $paths, true);
             if (is_array($paths)) {
@@ -326,7 +326,7 @@ class CommandUtility
                 }
             }
         }
-            // Check if new paths are invalid
+        // Check if new paths are invalid
         if ($doCheck) {
             foreach (self::$paths as $path => $valid) {
                 // Ignore invalid (FALSE) paths
@@ -373,14 +373,14 @@ class CommandUtility
         $pathsArr = [];
         $sysPathArr = [];
 
-            // Image magick paths first
-            // processor_path_lzw take precedence over processor_path
+        // Image magick paths first
+        // processor_path_lzw take precedence over processor_path
         if ($imPath = $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_path_lzw'] ?: $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_path']) {
             $imPath = self::fixPath($imPath);
             $pathsArr[$imPath] = $imPath;
         }
 
-            // Add configured paths
+        // Add configured paths
         if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['binPath']) {
             $sysPath = GeneralUtility::trimExplode(',', $GLOBALS['TYPO3_CONF_VARS']['SYS']['binPath'], true);
             foreach ($sysPath as $val) {
@@ -389,8 +389,8 @@ class CommandUtility
             }
         }
 
-            // Add path from environment
-            // @todo how does this work for WIN
+        // Add path from environment
+        // @todo how does this work for WIN
         if ($GLOBALS['_SERVER']['PATH']) {
             $sep = (TYPO3_OS === 'WIN' ? ';' : ':');
             $envPath = GeneralUtility::trimExplode($sep, $GLOBALS['_SERVER']['PATH'], true);
@@ -400,7 +400,7 @@ class CommandUtility
             }
         }
 
-            // Set common paths for Unix (only)
+        // Set common paths for Unix (only)
         if (TYPO3_OS !== 'WIN') {
             $sysPathArr = array_merge($sysPathArr, [
                 '/usr/bin/' => '/usr/bin/',
index 8fde475..8253b24 100644 (file)
@@ -202,7 +202,8 @@ class ExtendedFileUtility extends BasicFileUtility
                 $uploads = $this->fileCmdMap['upload'];
                 foreach ($uploads as $upload) {
                     if (empty($_FILES['upload_' . $upload['data']]['name'])
-                        || (is_array($_FILES['upload_' . $upload['data']]['name'])
+                        || (
+                            is_array($_FILES['upload_' . $upload['data']]['name'])
                             && empty($_FILES['upload_' . $upload['data']]['name'][0])
                         )
                     ) {
index 8e48257..c0109bb 100644 (file)
@@ -3466,7 +3466,8 @@ class GeneralUtility
         // Never instantiate with a beginning backslash, otherwise things like singletons won't work.
         if ($className[0] === '\\') {
             throw new \InvalidArgumentException(
-                '$className "' . $className . '" must not start with a backslash.', 1420281366
+                '$className "' . $className . '" must not start with a backslash.',
+                1420281366
             );
         }
         if (isset(static::$finalClassNameCache[$className])) {
@@ -4026,7 +4027,7 @@ class GeneralUtility
         if (preg_match('/@deprecated\\s+(.*)/', $function->getDocComment(), $match)) {
             $msg = $match[1];
         }
-            // Write a longer message to the deprecation log: <function> <annotion> - <trace> (<source>)
+        // Write a longer message to the deprecation log: <function> <annotion> - <trace> (<source>)
         $logMsg = $trail[1]['class'] . $trail[1]['type'] . $trail[1]['function'];
         $logMsg .= '() - ' . $msg . ' - ' . DebugUtility::debugTrail();
         $logMsg .= ' (' . PathUtility::stripPathSitePrefix($function->getFileName()) . '#' . $function->getStartLine() . ')';
index a6128be..acaf14f 100644 (file)
@@ -610,7 +610,9 @@ return [
         'media' => [
             'exclude' => true,
             'label' => 'LLL:EXT:frontend/Resources/Private/Language/locallang_tca.xlf:pages.media',
-            'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig('media', [
+            'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
+                'media',
+                [
                     // Use the imageoverlayPalette instead of the basicoverlayPalette
                     'overrideChildTca' => [
                         'types' => [
index 1dc2b77..af39992 100644 (file)
@@ -62,7 +62,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function addElementRelation()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, self::FIELD_ContentElement, [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond, self::VALUE_ElementIdThird]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond, self::VALUE_ElementIdThird]
         );
     }
 
@@ -73,7 +76,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function deleteElementRelation()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, self::FIELD_ContentElement, [self::VALUE_ElementIdFirst]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdFirst]
         );
     }
 
@@ -93,7 +99,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function changeElementRelationSorting()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, self::FIELD_ContentElement, [self::VALUE_ElementIdSecond, self::VALUE_ElementIdFirst]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdSecond, self::VALUE_ElementIdFirst]
         );
     }
 
@@ -104,7 +113,9 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function createContentAndAddElementRelation()
     {
         $newTableIds = $this->actionService->createNewRecord(
-            self::TABLE_Content, self::VALUE_PageId, ['header' => 'Testing #1', self::FIELD_ContentElement => self::VALUE_ElementIdFirst]
+            self::TABLE_Content,
+            self::VALUE_PageId,
+            ['header' => 'Testing #1', self::FIELD_ContentElement => self::VALUE_ElementIdFirst]
         );
         $this->recordIds['newContentId'] = $newTableIds[self::TABLE_Content][0];
     }
@@ -224,7 +235,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
         $newTableIds = $this->actionService->localizeRecord(self::TABLE_Content, self::VALUE_ContentIdLast, self::VALUE_LanguageId);
         $this->recordIds['localizedContentId'] = $newTableIds[self::TABLE_Content][self::VALUE_ContentIdLast];
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdLast, self::FIELD_ContentElement, [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond]
+            self::TABLE_Content,
+            self::VALUE_ContentIdLast,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond]
         );
     }
 
@@ -241,7 +255,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
             ['l10n_state' => [self::FIELD_ContentElement => 'source']]
         );
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdLast, self::FIELD_ContentElement, [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond]
+            self::TABLE_Content,
+            self::VALUE_ContentIdLast,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond]
         );
     }
 
index a05193a..74b6851 100644 (file)
@@ -63,7 +63,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function addCategoryRelation()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, 'categories', [self::VALUE_CategoryIdFirst, self::VALUE_CategoryIdSecond, 31]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            'categories',
+            [self::VALUE_CategoryIdFirst, self::VALUE_CategoryIdSecond, 31]
         );
     }
 
@@ -74,7 +77,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function deleteCategoryRelation()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, 'categories', [self::VALUE_CategoryIdFirst]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            'categories',
+            [self::VALUE_CategoryIdFirst]
         );
     }
 
@@ -85,7 +91,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function changeCategoryRelationSorting()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, 'categories', [self::VALUE_CategoryIdSecond, self::VALUE_CategoryIdFirst]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            'categories',
+            [self::VALUE_CategoryIdSecond, self::VALUE_CategoryIdFirst]
         );
     }
 
index 554063e..c06a072 100644 (file)
@@ -61,7 +61,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function addElementRelation()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, self::FIELD_ContentElement, [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond, self::VALUE_ElementIdThird]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdFirst, self::VALUE_ElementIdSecond, self::VALUE_ElementIdThird]
         );
     }
 
@@ -72,7 +75,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function deleteElementRelation()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, self::FIELD_ContentElement, [self::VALUE_ElementIdFirst]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdFirst]
         );
     }
 
@@ -92,7 +98,10 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function changeElementRelationSorting()
     {
         $this->actionService->modifyReferences(
-            self::TABLE_Content, self::VALUE_ContentIdFirst, self::FIELD_ContentElement, [self::VALUE_ElementIdSecond, self::VALUE_ElementIdFirst]
+            self::TABLE_Content,
+            self::VALUE_ContentIdFirst,
+            self::FIELD_ContentElement,
+            [self::VALUE_ElementIdSecond, self::VALUE_ElementIdFirst]
         );
     }
 
@@ -103,7 +112,9 @@ abstract class AbstractActionTestCase extends \TYPO3\CMS\Core\Tests\Functional\D
     public function createContentAndAddElementRelation()
     {
         $newTableIds = $this->actionService->createNewRecord(
-            self::TABLE_Content, self::VALUE_PageId, ['header' => 'Testing #1', self::FIELD_ContentElement => self::VALUE_ElementIdFirst]
+            self::TABLE_Content,
+            self::VALUE_PageId,
+            ['header' => 'Testing #1', self::FIELD_ContentElement => self::VALUE_ElementIdFirst]
         );
         $this->recordIds['newContentId'] = $newTableIds[self::TABLE_Content][0];
     }
index 8581598..de31887 100644 (file)
@@ -2,7 +2,8 @@
 defined('TYPO3_MODE') or die();
 
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
-    'OliverHader.' . $_EXTKEY, 'Irre',
+    'OliverHader.' . $_EXTKEY,
+    'Irre',
     [
         'Queue' => 'index',
         'Content' => 'list, show, new, create, edit, update, delete'
index 423316d..d137596 100644 (file)
@@ -208,7 +208,8 @@ class DatabaseSessionBackendTest extends FunctionalTestCase
         // assert that we set anonymous session correctly
         $this->assertArraySubset(
             $anonymousSession,
-            $this->subject->get('anonymousSession'));
+            $this->subject->get('anonymousSession')
+        );
 
         // Run the garbage collection
         $GLOBALS['EXEC_TIME'] = 200;
@@ -218,7 +219,8 @@ class DatabaseSessionBackendTest extends FunctionalTestCase
         // Authenticated session should still be there
         $this->assertArraySubset(
             $authenticatedSession,
-            $this->subject->get('authenticatedSession'));
+            $this->subject->get('authenticatedSession')
+        );
 
         // Non-authenticated session should be removed
         $this->expectException(SessionNotFoundException::class);
index 721acf0..9c6719b 100644 (file)
@@ -238,7 +238,8 @@ class RedisSessionBackendTest extends FunctionalTestCase
         // assert that we set anonymous session correctly
         $this->assertArraySubset(
             $anonymousSession,
-            $this->subject->get('anonymousSession'));
+            $this->subject->get('anonymousSession')
+        );
 
         // Run the garbage collection
         $GLOBALS['EXEC_TIME'] = 200;
@@ -248,7 +249,8 @@ class RedisSessionBackendTest extends FunctionalTestCase
         // Authenticated session should still be there
         $this->assertArraySubset(
             $authenticatedSession,
-            $this->subject->get('authenticatedSession'));
+            $this->subject->get('authenticatedSession')
+        );
 
         // Non-authenticated session should be removed
         $this->expectException(SessionNotFoundException::class);
index f483090..d4d7f6e 100644 (file)
@@ -294,7 +294,8 @@ class CategoryRegistryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCas
 
         foreach ($GLOBALS['TCA'][$this->tables['first']]['types'] as $typeConfig) {
             $this->assertSame(
-                1, substr_count($typeConfig['showitem'], '--div--;LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:sys_category.tabs.category')
+                1,
+                substr_count($typeConfig['showitem'], '--div--;LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:sys_category.tabs.category')
             );
         }
     }
@@ -318,7 +319,8 @@ class CategoryRegistryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCas
         $GLOBALS['TCA'][$this->tables['first']]['types']['newtypeafterfirstadd'] = ['showitem' => ''];
         $this->subject->add('text_extension_a', $this->tables['first'], 'categories1', [], true);
         $this->assertSame(
-            1, substr_count($GLOBALS['TCA'][$this->tables['first']]['types']['newtypeafterfirstadd']['showitem'], '--div--;LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:sys_category.tabs.category')
+            1,
+            substr_count($GLOBALS['TCA'][$this->tables['first']]['types']['newtypeafterfirstadd']['showitem'], '--div--;LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:sys_category.tabs.category')
         );
     }
 
index a9df8ca..8f257d4 100644 (file)
@@ -134,7 +134,8 @@ class ConfigurationManagerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTes
         );
         $this->subject->expects($this->once())
                 ->method('getDefaultConfiguration')
-                ->will($this->returnValue([
+                ->will($this->returnValue(
+                    [
                     'path' => 'value',
                 ]
             ));
@@ -154,7 +155,8 @@ class ConfigurationManagerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTes
         );
         $this->subject->expects($this->once())
                 ->method('getLocalConfiguration')
-                ->will($this->returnValue([
+                ->will($this->returnValue(
+                    [
                     'path' => 'value',
                 ]
             ));
@@ -175,13 +177,15 @@ class ConfigurationManagerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTes
         );
         $this->subject->expects($this->once())
                 ->method('getDefaultConfiguration')
-                ->will($this->returnValue([
+                ->will($this->returnValue(
+                    [
                     'path' => 'value',
                 ]
             ));
         $this->subject->expects($this->once())
                 ->method('getLocalConfiguration')
-                ->will($this->returnValue([
+                ->will($this->returnValue(
+                    [
                     'path' => 'valueOverride',
                 ]
             ));
index 6f05c11..d4ba9c0 100644 (file)
@@ -352,7 +352,8 @@ class RichtextTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
             ],
         ];
 
-        $subject = $this->getAccessibleMock(Richtext::class,
+        $subject = $this->getAccessibleMock(
+            Richtext::class,
             ['loadConfigurationFromPreset', 'getRtePageTsConfigOfPid'],
             [],
             '',
index 03c115f..ca0c84a 100644 (file)
@@ -492,7 +492,10 @@ class DataHandlerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $result = $this->callInaccessibleMethod(
             $this->subject,
             'isSubmittedValueEqualToStoredValue',
-            $submittedValue, $storedValue, $storedType, $allowNull
+            $submittedValue,
+            $storedValue,
+            $storedType,
+            $allowNull
         );
         $this->assertEquals($expected, $result);
     }
index 11fb4e0..44998b3 100644 (file)
@@ -307,8 +307,10 @@ class BulkInsertTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $this->expectExceptionMessage('Multiple types specified for column baz (index 1).');
 
         $query = new BulkInsertQuery($this->connection, $this->testTable, ['bar', 'baz']);
-        $query->addValues(['bar', 'baz'],
-            [Connection::PARAM_INT, Connection::PARAM_INT, 'baz' => Connection::PARAM_STR]);
+        $query->addValues(
+            ['bar', 'baz'],
+            [Connection::PARAM_INT, Connection::PARAM_INT, 'baz' => Connection::PARAM_STR]
+        );
     }
 
     /**
index f1d427c..6de2add 100644 (file)
@@ -119,8 +119,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconReturnsIconWithCorrectMarkupWrapperIfRegisteredIconIdentifierIsUsed()
     {
-        $this->assertContains('<span class="icon-markup">',
-            $this->subject->getIcon($this->registeredIconIdentifier)->render());
+        $this->assertContains(
+            '<span class="icon-markup">',
+            $this->subject->getIcon($this->registeredIconIdentifier)->render()
+        );
     }
 
     /**
@@ -128,8 +130,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconByIdentifierReturnsIconWithCorrectMarkupIfRegisteredIconIdentifierIsUsed()
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-actions-close" data-identifier="actions-close">',
-            $this->subject->getIcon($this->registeredIconIdentifier)->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-actions-close" data-identifier="actions-close">',
+            $this->subject->getIcon($this->registeredIconIdentifier)->render()
+        );
     }
 
     /**
@@ -138,8 +142,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconByIdentifierAndSizeReturnsIconWithCorrectMarkupIfRegisteredIconIdentifierIsUsed($size)
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-' . $size['expected'] . ' icon-state-default icon-actions-close" data-identifier="actions-close">',
-            $this->subject->getIcon($this->registeredIconIdentifier, $size['input'])->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-' . $size['expected'] . ' icon-state-default icon-actions-close" data-identifier="actions-close">',
+            $this->subject->getIcon($this->registeredIconIdentifier, $size['input'])->render()
+        );
     }
 
     /**
@@ -148,8 +154,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconByIdentifierAndSizeAndWithOverlayReturnsIconWithCorrectOverlayMarkupIfRegisteredIconIdentifierIsUsed($size)
     {
-        $this->assertContains('<span class="icon-overlay icon-overlay-readonly">',
-            $this->subject->getIcon($this->registeredIconIdentifier, $size['input'], 'overlay-readonly')->render());
+        $this->assertContains(
+            '<span class="icon-overlay icon-overlay-readonly">',
+            $this->subject->getIcon($this->registeredIconIdentifier, $size['input'], 'overlay-readonly')->render()
+        );
     }
 
     /**
@@ -166,8 +174,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
                 'additionalClasses' => 'fa-fw'
             ]
         ]);
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-default-not-found" data-identifier="default-not-found">',
-            $this->subject->getIcon($this->notRegisteredIconIdentifier)->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-default-not-found" data-identifier="default-not-found">',
+            $this->subject->getIcon($this->notRegisteredIconIdentifier)->render()
+        );
     }
 
     /**
@@ -185,8 +195,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
                 'additionalClasses' => 'fa-fw'
             ]
         ]);
-        $this->assertContains('<span class="t3js-icon icon icon-size-' . $size['expected'] . ' icon-state-default icon-default-not-found" data-identifier="default-not-found">',
-            $this->subject->getIcon($this->notRegisteredIconIdentifier, $size['input'])->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-' . $size['expected'] . ' icon-state-default icon-default-not-found" data-identifier="default-not-found">',
+            $this->subject->getIcon($this->notRegisteredIconIdentifier, $size['input'])->render()
+        );
     }
 
     /**
@@ -202,8 +214,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
                 'spinning' => true
             ]
         ]);
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-' . $this->registeredSpinningIconIdentifier . ' icon-spin" data-identifier="spinning-icon">',
-            $this->subject->getIcon($this->registeredSpinningIconIdentifier)->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-' . $this->registeredSpinningIconIdentifier . ' icon-spin" data-identifier="spinning-icon">',
+            $this->subject->getIcon($this->registeredSpinningIconIdentifier)->render()
+        );
     }
 
     /**
@@ -213,8 +227,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconByIdentifierAndSizeAndOverlayReturnsNotFoundIconWithCorrectMarkupIfUnregisteredIdentifierIsUsed($size)
     {
-        $this->assertContains('<span class="icon-overlay icon-overlay-readonly">',
-            $this->subject->getIcon($this->notRegisteredIconIdentifier, $size['input'], 'overlay-readonly')->render());
+        $this->assertContains(
+            '<span class="icon-overlay icon-overlay-readonly">',
+            $this->subject->getIcon($this->notRegisteredIconIdentifier, $size['input'], 'overlay-readonly')->render()
+        );
     }
 
     /**
@@ -237,8 +253,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconForFileWithNoFileTypeReturnsDefaultFileIcon()
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-other-other" data-identifier="mimetypes-other-other">',
-            $this->subject->getIconForFileExtension('')->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-other-other" data-identifier="mimetypes-other-other">',
+            $this->subject->getIconForFileExtension('')->render()
+        );
     }
 
     /**
@@ -248,8 +266,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconForFileWithUnknownFileTypeReturnsDefaultFileIcon()
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-other-other" data-identifier="mimetypes-other-other">',
-            $this->subject->getIconForFileExtension('foo')->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-other-other" data-identifier="mimetypes-other-other">',
+            $this->subject->getIconForFileExtension('foo')->render()
+        );
     }
 
     /**
@@ -259,8 +279,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconForFileWithFileTypePdfReturnsPdfIcon()
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-pdf" data-identifier="mimetypes-pdf">',
-            $this->subject->getIconForFileExtension('pdf')->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-pdf" data-identifier="mimetypes-pdf">',
+            $this->subject->getIconForFileExtension('pdf')->render()
+        );
     }
 
     /**
@@ -270,8 +292,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconForFileWithFileTypePngReturnsPngIcon()
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-media-image" data-identifier="mimetypes-media-image">',
-            $this->subject->getIconForFileExtension('png')->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-media-image" data-identifier="mimetypes-media-image">',
+            $this->subject->getIconForFileExtension('png')->render()
+        );
     }
 
     /**
@@ -284,8 +308,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $resourceProphecy->getExtension()->willReturn('pdf');
         $resourceProphecy->getMimeType()->willReturn('');
 
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-pdf" data-identifier="mimetypes-pdf">',
-            $this->subject->getIconForResource($resourceProphecy->reveal())->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-mimetypes-pdf" data-identifier="mimetypes-pdf">',
+            $this->subject->getIconForResource($resourceProphecy->reveal())->render()
+        );
     }
 
     //////////////////////////////////////////////
@@ -422,8 +448,10 @@ class IconFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getIconForRecordWithNullTableReturnsMissingIcon()
     {
-        $this->assertContains('<span class="t3js-icon icon icon-size-default icon-state-default icon-default-not-found" data-identifier="default-not-found">',
-            $this->subject->getIconForRecord('', [])->render());
+        $this->assertContains(
+            '<span class="t3js-icon icon icon-size-default icon-state-default icon-default-not-found" data-identifier="default-not-found">',
+            $this->subject->getIconForRecord('', [])->render()
+        );
     }
 
     /**
index 239393a..fc1a92b 100644 (file)
@@ -30,9 +30,11 @@ class RecordLinkHandlerTest extends UnitTestCase
             'identifier' => 'tx_identifier',
             'uid' => 123
         ];
-        $url = sprintf('t3://record?identifier=%s&uid=%s',
+        $url = sprintf(
+            't3://record?identifier=%s&uid=%s',
             $parameters['identifier'],
-            $parameters['uid']);
+            $parameters['uid']
+        );
 
         $this->assertEquals($url, $subject->asString($parameters));
     }
index 9af334b..74c8729 100644 (file)
@@ -53,7 +53,7 @@ class LocallangXmlParserTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestC
 
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['format']['priority'] = 'xml';
         \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Localization\LanguageStore::class)->initialize();
-            // Clear localization cache
+        // Clear localization cache
         \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Cache\CacheManager::class)->getCache('l10n')->flush();
     }
 
index a13d00d..d577b1b 100644 (file)
@@ -50,7 +50,7 @@ class XliffParserTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $this->l10nPriority = $GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['format']['priority'];
         $this->parser = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Localization\Parser\XliffParser::class);
 
-            // We have to take the whole relative path as otherwise this test fails on Windows systems
+        // We have to take the whole relative path as otherwise this test fails on Windows systems
         $fixturePath = PATH_site . 'typo3/sysext/core/Tests/Unit/Localization/Parser/Fixtures/';
         $this->xliffFileNames = [
             'locallang' => $fixturePath . 'locallang.xlf',
@@ -59,7 +59,7 @@ class XliffParserTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         ];
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['format']['priority'] = 'xlf';
         \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Localization\LanguageStore::class)->initialize();
-            // Clear localization cache
+        // Clear localization cache
         \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Cache\CacheManager::class)->getCache('l10n')->flush();
     }
 
index fb0c2f3..f0fb2aa 100644 (file)
@@ -42,7 +42,7 @@ class LoggerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $logger = new Logger('test.core.log');
         $writer = new Fixtures\WriterFixture();
         $logger->addWriter(LogLevel::ERROR, $writer);
-            // warning < error, thus must not be logged
+        // warning < error, thus must not be logged
         $logger->log(LogLevel::WARNING, 'test message');
         $this->assertAttributeEmpty('records', $writer);
     }
@@ -96,7 +96,7 @@ class LoggerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
             ->getMock();
         $processor->expects($this->once())->method('processLogRecord')->will($this->returnValue(new LogRecord($component, $level, $message)));
         $logger->addProcessor($level, $processor);
-            // we need a writer, otherwise we will not process log records
+        // we need a writer, otherwise we will not process log records
         $logger->addWriter($level, new NullWriter());
         $logger->warning($message);
     }
@@ -124,7 +124,7 @@ class LoggerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $logger = new Logger('test.core.log');
         $writer = new Fixtures\WriterFixture();
         $logger->addWriter(LogLevel::NOTICE, $writer);
-            // notice == notice, thus must be logged
+        // notice == notice, thus must be logged
         $logger->log(LogLevel::NOTICE, 'test message');
         $this->assertAttributeNotEmpty('records', $writer);
     }
@@ -168,7 +168,7 @@ class LoggerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $logger = new Logger('test.core.log');
         $writer = new Fixtures\WriterFixture();
         $logger->addWriter(LogLevel::NOTICE, $writer);
-            // warning > notice, thus must be logged
+        // warning > notice, thus must be logged
         $logger->log(LogLevel::WARNING, 'test message');
         $this->assertAttributeNotEmpty('records', $writer);
     }
index 6e05de8..ca1b1f8 100644 (file)
@@ -47,7 +47,8 @@ class FileReferenceTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $originalFileMock = $this->getAccessibleMock(\TYPO3\CMS\Core\Resource\File::class, [], [], '', false);
         $originalFileMock->expects($this->any())
             ->method('getProperties')
-            ->will($this->returnValue($originalFileProperties)
+            ->will(
+                $this->returnValue($originalFileProperties)
         );
         $fixture->_set('originalFile', $originalFileMock);
         $fixture->_set('propertiesOfFileReference', $fileReferenceProperties);
index f0396ae..6e06c55 100644 (file)
@@ -172,7 +172,7 @@ class FileTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $this->assertSame($mockedNewStorage, $subject->getStorage());
     }
 
-/**
+    /**
      * @test
      */
     public function copyToCallsCopyOperationOnTargetFolderStorage()
@@ -215,11 +215,13 @@ class FileTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function getNameWithoutExtensionReturnsCorrectName($originalFilename, $expectedBasename)
     {
-        $fixture = new \TYPO3\CMS\Core\Resource\File([
+        $fixture = new \TYPO3\CMS\Core\Resource\File(
+            [
             'name' => $originalFilename,
             'identifier' => '/' . $originalFilename
         ],
-        $this->storageMock);
+        $this->storageMock
+        );
         $this->assertSame($expectedBasename, $fixture->getNameWithoutExtension());
     }
 
index a3e20e8..5f5d3a9 100644 (file)
@@ -65,7 +65,11 @@ class FileNameFilterTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $this->assertSame(
             $expected,
             FileNameFilter::filterHiddenFilesAndFolders(
-                $itemName, $itemIdentifier, '', [], $driverMock
+                $itemName,
+                $itemIdentifier,
+                '',
+                [],
+                $driverMock
             )
         );
     }
@@ -84,7 +88,11 @@ class FileNameFilterTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         FileNameFilter::setShowHiddenFilesAndFolders(true);
         $this->assertSame(
             FileNameFilter::filterHiddenFilesAndFolders(
-                $itemName, $itemIdentifier, '', [], $driverMock
+                $itemName,
+                $itemIdentifier,
+                '',
+                [],
+                $driverMock
             ),
             $expected
         );
index aa87762..659ad85 100644 (file)
@@ -89,7 +89,8 @@ class FolderTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
     public function getFilesReturnsArrayWithFilenamesAsKeys()
     {
         $mockedStorage = $this->createMock(\TYPO3\CMS\Core\Resource\ResourceStorage::class);
-        $mockedStorage->expects($this->once())->method('getFilesInFolder')->will($this->returnValue([
+        $mockedStorage->expects($this->once())->method('getFilesInFolder')->will($this->returnValue(
+            [
                 'somefile.png' => [
                     'name' => 'somefile.png'
                 ],
index bb89482..eb7ec20 100644 (file)
@@ -136,7 +136,7 @@ class ResourceStorageTest extends BaseTestCase
             $driver = new LocalDriver($driverConfiguration);
         } else {
             // We are using the LocalDriver here because PHPUnit can't mock concrete methods in abstract classes, so
-                // when using the AbstractDriver we would be in trouble when wanting to mock away some concrete method
+            // when using the AbstractDriver we would be in trouble when wanting to mock away some concrete method
             $driver = $this->getMockBuilder(LocalDriver::class)
                 ->setMethods($mockedDriverMethods)
                 ->setConstructorArgs([$driverConfiguration])
@@ -360,7 +360,7 @@ class ResourceStorageTest extends BaseTestCase
         $mockedDriver->expects($this->any())->method('getPermissions')->will($this->returnValue($permissionsFromDriver));
         /** @var $mockedFolder Folder|\PHPUnit_Framework_MockObject_MockObject  */
         $mockedFolder = $this->createMock(Folder::class);
-            // Let all other checks pass
+        // Let all other checks pass
         /** @var $subject ResourceStorage|\PHPUnit_Framework_MockObject_MockObject */
         $subject = $this->getMockBuilder(ResourceStorage::class)
             ->setMethods(['isWritable', 'isBrowsable', 'checkUserActionPermission'])
@@ -760,7 +760,7 @@ class ResourceStorageTest extends BaseTestCase
         $this->subject->renameFile($file, 'bar', DuplicationBehavior::CANCEL);
     }
 
-     /**
+    /**
      * @test
      */
     public function renameFileReplacesIfConflictAndConflictModeIsReplace()
index 079ae7f..e0bfd6b 100644 (file)
@@ -90,7 +90,8 @@ class TemplateServiceTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $GLOBALS['TYPO3_LOADED_EXT'] = [
             $identifier => [
                 'ext_typoscript_setup.txt' => ExtensionManagementUtility::extPath(
-                    'core', 'Tests/Unit/TypoScript/Fixtures/ext_typoscript_setup.txt'
+                    'core',
+                    'Tests/Unit/TypoScript/Fixtures/ext_typoscript_setup.txt'
                 ),
             ],
         ];
@@ -115,7 +116,8 @@ class TemplateServiceTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $GLOBALS['TYPO3_LOADED_EXT'] = [
             $identifier => [
                 'ext_typoscript_setup.txt' => ExtensionManagementUtility::extPath(
-                        'core', 'Tests/Unit/TypoScript/Fixtures/ext_typoscript_setup.txt'
+                        'core',
+                    'Tests/Unit/TypoScript/Fixtures/ext_typoscript_setup.txt'
                     ),
                 'ext_typoscript_constants.txt' => ''
             ],
index 3a7b024..e52182c 100644 (file)
@@ -56,7 +56,8 @@ class ExtendedFileUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
             ->getMock();
         $folder->expects($this->once())
             ->method('getFiles')->with(0, 0, Folder::FILTER_MODE_USE_OWN_AND_STORAGE_FILTERS, true)
-            ->will($this->returnValue([$file])
+            ->will(
+                $this->returnValue([$file])
         );
 
         /** @var \TYPO3\CMS\Core\Utility\File\ExtendedFileUtility $subject */
index 065eb77..60d1513 100644 (file)
@@ -65,9 +65,8 @@ class HelpCommand extends \Symfony\Component\Console\Command\HelpCommand
             $_SERVER['argv'][1] = 'extbase:help:help';
             $bootstrap = GeneralUtility::makeInstance(Bootstrap::class);
             $bootstrap->run('', []);
-
-        // An extbase command was originally called, but is now required to show the help information
         } elseif ($this->command instanceof ExtbaseCommand) {
+            // An extbase command was originally called, but is now required to show the help information
             // Ugly hack to modify 'argv' so the help command for a specific command is shown
             $args = [$_SERVER['argv'][0], 'help'];
             foreach ($_SERVER['argv'] as $k => $value) {
index 2c34f1f..c35e12c 100644 (file)
@@ -812,7 +812,8 @@ class Backend implements \TYPO3\CMS\Extbase\Persistence\Generic\BackendInterface
         }
         $res = $this->storageBackend->updateRelationTableRow(
             $relationTableName,
-            $row);
+            $row
+        );
         return $res;
     }
 
@@ -915,7 +916,8 @@ class Backend implements \TYPO3\CMS\Extbase\Persistence\Generic\BackendInterface
         $result = $this->storageBackend->getMaxValueFromTable(
             $tableName,
             $matchFields,
-            $sortByFieldName);
+            $sortByFieldName
+        );
         return $result;
     }
 
index b15de78..9990315 100644 (file)
@@ -225,7 +225,8 @@ class Typo3DbBackend implements BackendInterface, SingletonInterface
     {
         if (!isset($fieldValues['uid_local']) && !isset($fieldValues['uid_foreign'])) {
             throw new \InvalidArgumentException(
-                'The given fieldValues must contain a value for "uid_local" and "uid_foreign".', 1360500126
+                'The given fieldValues must contain a value for "uid_local" and "uid_foreign".',
+                1360500126
             );
         }
 
index d5338b0..66a8e1d 100644 (file)
@@ -66,7 +66,7 @@ class PersistentObjectConverter extends ObjectConverter
      */
     protected $persistenceManager;
 
-        /**
+    /**
      * @param \TYPO3\CMS\Extbase\Persistence\PersistenceManagerInterface $persistenceManager
      */
     public function injectPersistenceManager(\TYPO3\CMS\Extbase\Persistence\PersistenceManagerInterface $persistenceManager)
index 0e8451c..256d075 100644 (file)
@@ -86,7 +86,8 @@ class LocalizationUtility
         } else {
             if (empty($extensionName)) {
                 throw new \InvalidArgumentException(
-                    'Parameter $extensionName cannot be empty if a fully-qualified key is not specified.', 1498144052
+                    'Parameter $extensionName cannot be empty if a fully-qualified key is not specified.',
+                    1498144052
                 );
             }
             self::initializeLocalization($extensionName);
index 9a3ef8a..167bed3 100644 (file)
@@ -57,7 +57,7 @@ abstract class AbstractCompositeValidator implements ObjectValidatorInterface, \
             throw new \TYPO3\CMS\Extbase\Validation\Exception\InvalidValidationOptionsException('Unsupported validation option(s) found: ' . implode(', ', array_keys($unsupportedOptions)), 1339079804);
         }
 
-            // check for required options being set
+        // check for required options being set
         array_walk(
             $this->supportedOptions,
             function ($supportedOptionData, $supportedOptionName, $options) {
@@ -68,7 +68,7 @@ abstract class AbstractCompositeValidator implements ObjectValidatorInterface, \
             $options
         );
 
-            // merge with default values
+        // merge with default values
         $this->options = array_merge(
             array_map(
                 function ($value) {
index 023970a..5847164 100644 (file)
@@ -40,6 +40,9 @@ class DateTimeValidator extends AbstractValidator
                 [
                     gettype($value)
                 ]
-            ), 1238087674, [gettype($value)]);
+            ),
+            1238087674,
+            [gettype($value)]
+        );
     }
 }
index 8079230..e7d2db7 100644 (file)
@@ -34,7 +34,9 @@ class EmailAddressValidator extends AbstractValidator
                 $this->translateErrorMessage(
                     'validator.emailaddress.notvalid',
                     'extbase'
-                ), 1221559976);
+                ),
+                1221559976
+            );
         }
     }
 
index daea487..c03ecda 100644 (file)
@@ -38,7 +38,9 @@ class FloatValidator extends AbstractValidator
                 $this->translateErrorMessage(
                 'validator.float.notvalid',
                 'extbase'
-                ), 1221560288);
+                ),
+                1221560288
+            );
         }
     }
 }
index f1efc53..dd03f02 100644 (file)
@@ -34,7 +34,9 @@ class IntegerValidator extends AbstractValidator
                 $this->translateErrorMessage(
                 'validator.integer.notvalid',
                 'extbase'
-                ), 1221560494);
+                ),
+                1221560494
+            );
         }
     }
 }
index 9e954d9..2327f1f 100644 (file)
@@ -41,28 +41,36 @@ class NotEmptyValidator extends AbstractValidator
                 $this->translateErrorMessage(
                     'validator.notempty.null',
                     'extbase'
-                ), 1221560910);
+                ),
+                1221560910
+            );
         }
         if ($value === '') {
             $this->addError(
                 $this->translateErrorMessage(
                     'validator.notempty.empty',
                     'extbase'
-                ), 1221560718);
+                ),
+                1221560718
+            );
         }
         if (is_array($value) && empty($value)) {
             $this->addError(
                 $this->translateErrorMessage(
                     'validator.notempty.empty',
                     'extbase'
-                ), 1347992400);
+                ),
+                1347992400
+            );
         }
         if (is_object($value) && $value instanceof \Countable && $value->count() === 0) {
             $this->addError(
                 $this->translateErrorMessage(
                     'validator.notempty.empty',
                     'extbase'
-                ), 1347992453);
+                ),
+                1347992453
+            );
         }
     }
 }
index 6d269d7..80c733d 100644 (file)
@@ -42,7 +42,9 @@ class NumberRangeValidator extends AbstractValidator
                 $this->translateErrorMessage(
                     'validator.numberrange.notvalid',
                     'extbase'
-                ), 1221563685);
+                ),
+                1221563685
+            );
             return;
         }
 
index c11804b..ae9d67a 100644 (file)
@@ -33,7 +33,9 @@ class NumberValidator extends AbstractValidator
             $this->translateErrorMessage(
                 'validator.number.notvalid',
                 'extbase'
-            ), 1221563685);
+            ),
+                1221563685
+            );
         }
     }
 }
index c582951..2f0b3c9 100644 (file)
@@ -43,7 +43,9 @@ class RegularExpressionValidator extends AbstractValidator
                 $this->translateErrorMessage(
                     'validator.regularexpression.nomatch',
                     'extbase'
-                ), 1221565130);
+                ),
+                1221565130
+            );
         }
         if ($result === false) {
             throw new \TYPO3\CMS\Extbase\Validation\Exception\InvalidValidationOptionsException('regularExpression "' . $this->options['regularExpression'] . '" in RegularExpressionValidator contained an error.', 1298273089);
index 985c82d..04f368c 100644 (file)
@@ -73,7 +73,10 @@ class StringLengthValidator extends AbstractValidator
                             $this->options['minimum'],
                             $this->options['maximum']
                         ]
-                    ), 1428504122, [$this->options['minimum'], $this->options['maximum']]);
+                    ),
+                    1428504122,
+                    [$this->options['minimum'], $this->options['maximum']]
+                );
             } elseif ($this->options['minimum'] > 0) {
                 $this->addError(
                     $this->translateErrorMessage(
@@ -82,7 +85,10 @@ class StringLengthValidator extends AbstractValidator
                         [
                             $this->options['minimum']
                         ]
-                    ), 1238108068, [$this->options['minimum']]);
+                    ),
+                    1238108068,
+                    [$this->options['minimum']]
+                );
             } else {
                 $this->addError(
                     $this->translateErrorMessage(
@@ -91,7 +97,10 @@ class StringLengthValidator extends AbstractValidator
                         [
                             $this->options['maximum']
                         ]
-                    ), 1238108069, [$this->options['maximum']]);
+                    ),
+                    1238108069,
+                    [$this->options['maximum']]
+                );
             }
         }
     }
index b0738e7..6a5d55a 100644 (file)
@@ -34,7 +34,9 @@ class StringValidator extends AbstractValidator
                 $this->translateErrorMessage(
                     'validator.string.notvalid',
                     'extbase'
-                ), 1238108067);
+                ),
+                1238108067
+            );
         }
     }
 }
index 6f2b2c1..6c0dff2 100644 (file)
@@ -40,7 +40,9 @@ class TextValidator extends AbstractValidator
                 $this->translateErrorMessage(
                     'validator.text.notvalid',
                     'extbase'
-                ), 1221565786);
+                ),
+                1221565786
+            );
         }
     }
 }
index d35d230..222f049 100644 (file)
@@ -457,7 +457,7 @@ class ValidatorResolver implements \TYPO3\CMS\Core\SingletonInterface
             }
         } else {
             // Full qualified
-             // Tx_MyExt_Validation_Validator_MyValidator or \Acme\Ext\Validation\Validator\FooValidator
+            // Tx_MyExt_Validation_Validator_MyValidator or \Acme\Ext\Validation\Validator\FooValidator
             $possibleClassName = $validatorName;
             if (!empty($possibleClassName) && $possibleClassName[0] === '\\') {
                 $possibleClassName = substr($possibleClassName, 1);
index cf248f0..3248fbb 100644 (file)
@@ -2,14 +2,16 @@
 defined('TYPO3_MODE') or die();
 
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
-    'ExtbaseTeam.' . $_EXTKEY, 'Blogs',
+    'ExtbaseTeam.' . $_EXTKEY,
+    'Blogs',
     [
         'Blog' => 'list',
     ],
     []
 );
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
-    'ExtbaseTeam.' . $_EXTKEY, 'Content',
+    'ExtbaseTeam.' . $_EXTKEY,
+    'Content',
     [
         'Content' => 'list',
     ],
index 7c3f852..d018946 100644 (file)
@@ -167,12 +167,16 @@ class TranslatedContentTest extends \TYPO3\CMS\Core\Tests\Functional\DataHandlin
         $frontendResponse = $this->getFrontendResponse(self::VALUE_PageId, 0);
         $responseSections = $frontendResponse->getResponseSections('Extbase:list()');
         $visibleHeaders = ['Regular Element #1', 'Regular Element #2', 'Regular Element #3'];
-        $this->assertThat($responseSections, $this->getRequestSectionHasRecordConstraint()
+        $this->assertThat(
+            $responseSections,
+            $this->getRequestSectionHasRecordConstraint()
             ->setTable(self::TABLE_Content)
             ->setField('header')
             ->setValues(...$visibleHeaders)
         );
-        $this->assertThat($responseSections, $this->getRequestSectionDoesNotHaveRecordConstraint()
+        $this->assertThat(
+            $responseSections,
+            $this->getRequestSectionDoesNotHaveRecordConstraint()
             ->setTable(self::TABLE_Content)
             ->setField('header')
             ->setValues(...$this->getNonVisibleHeaders($visibleHeaders))
@@ -288,12 +292,16 @@ class TranslatedContentTest extends \TYPO3\CMS\Core\Tests\Functional\DataHandlin
         $this->addTypoScriptToTemplateRecord(1, $typoScript);
         $frontendResponse = $this->getFrontendResponse(self::VALUE_PageId, 1);
         $responseSections = $frontendResponse->getResponseSections('Extbase:list()');
-        $this->assertThat($responseSections, $this->getRequestSectionHasRecordConstraint()
+        $this->assertThat(
+            $responseSections,
+            $this->getRequestSectionHasRecordConstraint()
             ->setTable(self::TABLE_Content)
             ->setField('header')
             ->setValues(...$visibleHeaders)
         );
-        $this->assertThat($responseSections, $this->getRequestSectionDoesNotHaveRecordConstraint()
+        $this->assertThat(
+            $responseSections,
+            $this->getRequestSectionDoesNotHaveRecordConstraint()
             ->setTable(self::TABLE_Content)
             ->setField('header')
             ->setValues(...$this->getNonVisibleHeaders($visibleHeaders))
@@ -409,12 +417,16 @@ class TranslatedContentTest extends \TYPO3\CMS\Core\Tests\Functional\DataHandlin
         $frontendResponse = $this->getFrontendResponse(self::VALUE_PageId, 2);
         if ($status === Response::STATUS_Success) {
             $responseSections = $frontendResponse->getResponseSections('Extbase:list()');
-            $this->assertThat($responseSections, $this->getRequestSectionHasRecordConstraint()
+            $this->assertThat(
+                $responseSections,
+                $this->getRequestSectionHasRecordConstraint()
                 ->setTable(self::TABLE_Content)
                 ->setField('header')
                 ->setValues(...$visibleHeaders)
             );
-            $this->assertThat($responseSections, $this->getRequestSectionDoesNotHaveRecordConstraint()
+            $this->assertThat(
+                $responseSections,
+                $this->getRequestSectionDoesNotHaveRecordConstraint()
                 ->setTable(self::TABLE_Content)
                 ->setField('header')
                 ->setValues(...$this->getNonVisibleHeaders($visibleHeaders))
@@ -533,12 +545,16 @@ class TranslatedContentTest extends \TYPO3\CMS\Core\Tests\Functional\DataHandlin
         $this->assertEquals('success', $frontendResponse->getStatus());
         $responseSections = $frontendResponse->getResponseSections('Extbase:list()');
 
-        $this->assertThat($responseSections, $this->getRequestSectionHasRecordConstraint()
+        $this->assertThat(
+            $responseSections,
+            $this->getRequestSectionHasRecordConstraint()
             ->setTable(self::TABLE_Content)
             ->setField('header')
             ->setValues(...$visibleHeaders)
         );
-        $this->assertThat($responseSections, $this->getRequestSectionDoesNotHaveRecordConstraint()
+        $this->assertThat(
+            $responseSections,
+            $this->getRequestSectionDoesNotHaveRecordConstraint()
             ->setTable(self::TABLE_Content)
             ->setField('header')
             ->setValues(...$this->getNonVisibleHeaders($visibleHeaders))
index 258bf80..e8df095 100644 (file)
@@ -110,8 +110,10 @@ class RequestBuilderTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
             ->expects($this->any())
             ->method('getCommandByIdentifier')
             ->with('test:default:list')
-            ->will($this->throwException(
-                new \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchCommandException('testing', 1476050312))
+            ->will(
+                $this->throwException(
+                new \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchCommandException('testing', 1476050312)
+            )
             );
         $this->requestBuilder->_set('commandManager', $mockCommandManager);
         $request = $this->requestBuilder->build('test:default:list');
index 1e82999..39009a9 100644 (file)
@@ -116,7 +116,8 @@ class AbstractControllerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestC
             ->getMock();
         $controllerContext->expects($this->once())->method('getFlashMessageQueue')->will($this->returnValue($flashMessageQueue));
 
-        $controller = $this->getMockForAbstractClass(\TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
+        $controller = $this->getMockForAbstractClass(
+            \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
             [],
             '',
             false,
@@ -136,7 +137,8 @@ class AbstractControllerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestC
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionCode(1243258395);
-        $controller = $this->getMockForAbstractClass(\TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
+        $controller = $this->getMockForAbstractClass(
+            \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
             [],
             '',
             false,
index 2a98dcd..d033642 100644 (file)
@@ -896,7 +896,8 @@ class ContainerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
     public function getInstanceOnTwoOptionalGivesNoArgumentsToConstructorIfNoneAreGiven()
     {
         $object = $this->container->getInstance(
-            \TYPO3\CMS\Extbase\Tests\Unit\Object\Container\Fixtures\TwoConstructorArgumentsBothOptional::class);
+            \TYPO3\CMS\Extbase\Tests\Unit\Object\Container\Fixtures\TwoConstructorArgumentsBothOptional::class
+        );
         $this->assertInstanceOf(
             \TYPO3\CMS\Extbase\Tests\Unit\Object\Container\Fixtures\TwoConstructorArgumentsBothOptional::class,
             $object
index 80adbac..549427b 100644 (file)
@@ -47,7 +47,8 @@ class QueryFactoryTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
             ->getMock();
 
         $this->queryFactory = $this->getAccessibleMock(\TYPO3\CMS\Extbase\Persistence\Generic\QueryFactory::class, ['dummy']);
-        $this->queryFactory->_set('configurationManager',
+        $this->queryFactory->_set(
+            'configurationManager',
             $this->createMock(\TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::class)
         );
 
index 38c5a45..5b6a617 100644 (file)
@@ -141,7 +141,7 @@ class CollectionValidatorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
             ->method('buildBaseValidatorConjunction')
             ->will($this->returnValue($aValidator));
 
-            // Add validators to properties
+        // Add validators to properties
         $aValidator->addPropertyValidator('b', $this->validator);
         $aValidator->addPropertyValidator('integer', $integerValidator);
 
@@ -162,7 +162,7 @@ class CollectionValidatorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
             ['someNotEmptyValue']
         );
         \TYPO3\CMS\Extbase\Reflection\ObjectAccess::setProperty($lazyObjectStorage, 'isInitialized', false, true);
-            // only in this test case we want to mock the isValid method
+        // only in this test case we want to mock the isValid method
         $validator = $this->getValidator(['elementType' => $elementType], ['isValid']);
         $validator->expects($this->never())->method('isValid');
         $this->mockValidatorResolver->expects($this->never())->method('createValidator');
index 2960723..0045d31 100644 (file)
@@ -517,7 +517,9 @@ class DependencyUtility implements \TYPO3\CMS\Core\SingletonInterface
     {
         $versions = $this->getLowestAndHighestIntegerVersions($dependency);
         $count = $this->extensionRepository->countByVersionRangeAndExtensionKey(
-            $dependency->getIdentifier(), $versions['lowestIntegerVersion'], $versions['highestIntegerVersion']
+            $dependency->getIdentifier(),
+            $versions['lowestIntegerVersion'],
+            $versions['highestIntegerVersion']
         );
         return !empty($count);
     }
index 5aa43e4..a48fdfa 100644 (file)
@@ -456,7 +456,8 @@ class FileHandlingUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
         $fileHandlerMock = $this->getPreparedFileHandlingMockForDirectoryCreationTests();
         $fileHandlerMock->expects($this->never())
             ->method('createNestedDirectory');
-        $fileHandlerMock->ensureConfiguredDirectoriesExist([
+        $fileHandlerMock->ensureConfiguredDirectoriesExist(
+            [
                 'key' => 'foo_bar',
                 'uploadfolder' => 0,
             ]
@@ -471,7 +472,8 @@ class FileHandlingUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
         $fileHandlerMock = $this->getPreparedFileHandlingMockForDirectoryCreationTests();
         $fileHandlerMock->expects($this->never())
             ->method('createNestedDirectory');
-        $fileHandlerMock->ensureConfiguredDirectoriesExist([
+        $fileHandlerMock->ensureConfiguredDirectoriesExist(
+            [
                 'key' => 'foo_bar',
                 'createDirs' => '',
             ]
@@ -487,7 +489,8 @@ class FileHandlingUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
         $fileHandlerMock->expects($this->once())
             ->method('createNestedDirectory')
             ->with('uploads/tx_foobar/');
-        $fileHandlerMock->ensureConfiguredDirectoriesExist([
+        $fileHandlerMock->ensureConfiguredDirectoriesExist(
+            [
                 'key' => 'foo_bar',
                 'uploadfolder' => 1,
             ]
@@ -502,13 +505,15 @@ class FileHandlingUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
         $fileHandlerMock = $this->getPreparedFileHandlingMockForDirectoryCreationTests();
         $fileHandlerMock->expects($this->exactly(2))
             ->method('createNestedDirectory')
-            ->will($this->returnCallback(function ($path) {
-                if (!in_array($path, ['foo/bar', 'baz/foo'])) {
-                    throw new \Exception('Path "' . $path . '" is not expected to be created', 1476108500);
-                }
-            })
+            ->will(
+                $this->returnCallback(function ($path) {
+                    if (!in_array($path, ['foo/bar', 'baz/foo'])) {
+                        throw new \Exception('Path "' . $path . '" is not expected to be created', 1476108500);
+                    }
+                })
             );
-        $fileHandlerMock->ensureConfiguredDirectoriesExist([
+        $fileHandlerMock->ensureConfiguredDirectoriesExist(
+            [
                 'key' => 'foo_bar',
                 'createDirs' => 'foo/bar, baz/foo',
             ]
@@ -526,7 +531,8 @@ class FileHandlingUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTest
             ->will($this->returnValue(true));
         $fileHandlerMock->expects($this->never())
             ->method('createNestedDirectory');
-        $fileHandlerMock->ensureConfiguredDirectoriesExist([
+        $fileHandlerMock->ensureConfiguredDirectoriesExist(
+            [
                 'key' => 'foo_bar',
                 'uploadfolder' => 1,
                 'createDirs' => 'foo/bar, baz/foo',
index 100f74c..14f6610 100644 (file)
@@ -5,7 +5,9 @@ if (TYPO3_MODE === 'BE') {
     \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule(
         'TYPO3.CMS.Extensionmanager',
         'tools',
-        'extensionmanager', '', [
+        'extensionmanager',
+        '',
+        [
             'List' => 'index,unresolvedDependencies,ter,showAllVersions,distributions',
             'Action' => 'toggleExtensionInstallationState,installExtensionWithoutSystemDependencyCheck,removeExtension,downloadExtensionZip,reloadExtensionData',
             'Configuration' => 'showConfigurationForm,save,saveAndClose',
index 925ad45..27476bf 100644 (file)
@@ -338,15 +338,19 @@ class FrontendLoginController extends \TYPO3\CMS\Frontend\Plugin\AbstractPlugin
                 $postData = GeneralUtility::_POST($this->prefixId);
                 if (isset($postData['changepasswordsubmit'])) {
                     if (strlen($postData['password1']) < $minLength) {
-                        $markerArray['###STATUS_MESSAGE###'] = sprintf($this->getDisplayText(
+                        $markerArray['###STATUS_MESSAGE###'] = sprintf(
+                            $this->getDisplayText(
                             'change_password_tooshort_message',
-                            $this->conf['changePasswordTooShortMessage_stdWrap.']),
+                            $this->conf['changePasswordTooShortMessage_stdWrap.']
+                        ),
                             $minLength
                         );
                     } elseif ($postData['password1'] != $postData['password2']) {
-                        $markerArray['###STATUS_MESSAGE###'] = sprintf($this->getDisplayText(
+                        $markerArray['###STATUS_MESSAGE###'] = sprintf(
+                            $this->getDisplayText(
                             'change_password_notequal_message',
-                            $this->conf['changePasswordNotEqualMessage_stdWrap.']),
+                            $this->conf['changePasswordNotEqualMessage_stdWrap.']
+                        ),
                             $minLength
                         );
                     } else {
index 1070a25..9a17214 100644 (file)
@@ -33,7 +33,9 @@ call_user_func(function () {
         array_splice($GLOBALS['TCA']['tt_content']['columns']['CType']['config']['items'], $groupPosition, 0, [0 => $additionalCTypeItem]);
     } else {
         // nothing found, add two items (group + new CType) at the bottom of the list
-        \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTcaSelectItem('tt_content', 'CType',
+        \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTcaSelectItem(
+            'tt_content',
+            'CType',
             ['LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:CType.div.forms', '--div--']
         );
         \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTcaSelectItem('tt_content', 'CType', $additionalCTypeItem);
index 047a230..a97669c 100644 (file)
@@ -181,8 +181,10 @@ class FileListController extends ActionController
                 $this->folderObject = $resourceFactory->getFolderObjectFromCombinedIdentifier($storage->getUid() . ':' . $identifier);
                 // Disallow access to fallback storage 0
                 if ($storage->getUid() === 0) {
-                    throw new Exception\InsufficientFolderAccessPermissionsException('You are not allowed to access files outside your storages',
-                        1434539815);
+                    throw new Exception\InsufficientFolderAccessPermissionsException(
+                        'You are not allowed to access files outside your storages',
+                        1434539815
+                    );
                 }
                 // Disallow the rendering of the processing folder (e.g. could be called manually)
                 if ($this->folderObject && $storage->isProcessingFolder($this->folderObject)) {
@@ -204,7 +206,8 @@ class FileListController extends ActionController
             }
         } catch (Exception\InsufficientFolderAccessPermissionsException $permissionException) {
             $this->folderObject = null;
-            $this->errorMessage = GeneralUtility::makeInstance(FlashMessage::class,
+            $this->errorMessage = GeneralUtility::makeInstance(
+                FlashMessage::class,
                 sprintf(
                     $this->getLanguageService()->getLL('missingFolderPermissionsMessage'),
                     $this->id
@@ -224,7 +227,8 @@ class FileListController extends ActionController
                     $this->folderObject = null;
                 }
             }
-            $this->errorMessage = GeneralUtility::makeInstance(FlashMessage::class,
+            $this->errorMessage = GeneralUtility::makeInstance(
+                FlashMessage::class,
                 sprintf(
                     $this->getLanguageService()->getLL('folderNotFoundMessage'),
                     $this->id
@@ -234,15 +238,18 @@ class FileListController extends ActionController
             );
         } catch (\RuntimeException $e) {
             $this->folderObject = null;
-            $this->errorMessage = GeneralUtility::makeInstance(FlashMessage::class,
+            $this->errorMessage = GeneralUtility::makeInstance(
+                FlashMessage::class,
                 $e->getMessage() . ' (' . $e->getCode() . ')',
                 $this->getLanguageService()->getLL('folderNotFoundTitle'),
                 FlashMessage::NOTICE
             );
         }
 
-        if ($this->folderObject && !$this->folderObject->getStorage()->checkFolderActionPermission('read',
-                $this->folderObject)
+        if ($this->folderObject && !$this->folderObject->getStorage()->checkFolderActionPermission(
+            'read',
+                $this->folderObject
+        )
         ) {
             $this->folderObject = null;
         }
@@ -344,8 +351,10 @@ class FileListController extends ActionController
             $this->filelist->clipObj->initializeClipboard();
             $CB = GeneralUtility::_GET('CB');
             if ($this->cmd === 'setCB') {
-                $CB['el'] = $this->filelist->clipObj->cleanUpCBC(array_merge(GeneralUtility::_POST('CBH'),
-                    (array)GeneralUtility::_POST('CBC')), '_FILE');
+                $CB['el'] = $this->filelist->clipObj->cleanUpCBC(array_merge(
+                    GeneralUtility::_POST('CBH'),
+                    (array)GeneralUtility::_POST('CBC')
+                ), '_FILE');
             }
             if (!$this->MOD_SETTINGS['clipBoard']) {
                 $CB['setP'] = 'normal';
@@ -374,9 +383,14 @@ class FileListController extends ActionController
             }
             // Start up filelisting object, include settings.
             $this->pointer = MathUtility::forceIntegerInRange($this->pointer, 0, 100000);
-            $this->filelist->start($this->folderObject, $this->pointer, $this->MOD_SETTINGS['sort'],
-                $this->MOD_SETTINGS['reverse'], $this->MOD_SETTINGS['clipBoard'],
-                $this->MOD_SETTINGS['bigControlPanel']);
+            $this->filelist->start(
+                $this->folderObject,
+                $this->pointer,
+                $this->MOD_SETTINGS['sort'],
+                $this->MOD_SETTINGS['reverse'],
+                $this->MOD_SETTINGS['clipBoard'],
+                $this->MOD_SETTINGS['bigControlPanel']
+            );
             // Generate the list
             $this->filelist->generateList();
             // Set top JavaScript:
@@ -387,7 +401,8 @@ class FileListController extends ActionController
                     window.location.href = URL;
                     return false;
                 }
-                ');
+                '
+            );
             $pageRenderer->loadRequireJsModule('TYPO3/CMS/Filelist/FileDelete');
             $pageRenderer->addInlineLanguageLabelFile('EXT:lang/Resources/Private/Language/locallang_alt_doc.xlf', 'buttons');
 
@@ -419,20 +434,38 @@ class FileListController extends ActionController
                 'bigControlPanel' => [
                     'enabled' => $this->getBackendUser()->getTSConfigVal('options.file_list.enableDisplayBigControlPanel') === 'selectable',
                     'label' => htmlspecialchars($this->getLanguageService()->getLL('bigControlPanel')),
-                    'html' => BackendUtility::getFuncCheck($this->id, 'SET[bigControlPanel]',
-                        $this->MOD_SETTINGS['bigControlPanel'], '', '', 'id="bigControlPanel"'),
+                    'html' => BackendUtility::getFuncCheck(
+                        $this->id,
+                        'SET[bigControlPanel]',
+                        $this->MOD_SETTINGS['bigControlPanel'],
+                        '',
+                        '',
+                        'id="bigControlPanel"'
+                    ),
                 ],
                 'displayThumbs' => [
                     'enabled' => $GLOBALS['TYPO3_CONF_VARS']['GFX']['thumbnails'] && $this->getBackendUser()->getTSConfigVal('options.file_list.enableDisplayThumbnails') === 'selectable',
                     'label' => htmlspecialchars($this->getLanguageService()->getLL('displayThumbs')),
-                    'html' => BackendUtility::getFuncCheck($this->id, 'SET[displayThumbs]',
-                        $this->MOD_SETTINGS['displayThumbs'], '', '', 'id="checkDisplayThumbs"'),
+                    'html' => BackendUtility::getFuncCheck(
+                        $this->id,
+                        'SET[displayThumbs]',
+                        $this->MOD_SETTINGS['displayThumbs'],
+                        '',
+                        '',
+                        'id="checkDisplayThumbs"'
+                    ),
                 ],
                 'enableClipBoard' => [
                     'enabled' => $this->getBackendUser()->getTSConfigVal('options.file_list.enableClipBoard') === 'selectable',
                     'label' => htmlspecialchars($this->getLanguageService()->getLL('clipBoard')),
-                    'html' => BackendUtility::getFuncCheck($this->id, 'SET[clipBoard]',
-                        $this->MOD_SETTINGS['clipBoard'], '', '', 'id="checkClipBoard"'),
+                    'html' => BackendUtility::getFuncCheck(
+                        $this->id,
+                        'SET[clipBoard]',
+                        $this->MOD_SETTINGS['clipBoard'],
+                        '',
+                        '',
+                        'id="checkClipBoard"'
+                    ),
                 ]
             ]);
             $this->view->assign('showClipBoard', (bool)$this->MOD_SETTINGS['clipBoard']);
@@ -471,8 +504,11 @@ class FileListController extends ActionController
 
         if (empty($files)) {
             $this->controllerContext->getFlashMessageQueue('core.template.flashMessages')->addMessage(
-                new FlashMessage(LocalizationUtility::translate('flashmessage.no_results', 'filelist'), '',
-                    FlashMessage::INFO)
+                new FlashMessage(
+                    LocalizationUtility::translate('flashmessage.no_results', 'filelist'),
+                    '',
+                    FlashMessage::INFO
+                )
             );
         } else {
             foreach ($files as $file) {
@@ -590,8 +626,10 @@ class FileListController extends ActionController
         }
 
         // Upload button (only if upload to this directory is allowed)
-        if ($this->folderObject && $this->folderObject->getStorage()->checkUserActionPermission('add',
-                'File') && $this->folderObject->checkActionPermission('write')
+        if ($this->folderObject && $this->folderObject->getStorage()->checkUserActionPermission(
+            'add',
+                'File'
+        ) && $this->folderObject->checkActionPermission('write')
         ) {
             $uploadButton = $buttonBar->makeLinkButton()
                 ->setHref(BackendUtility::getModuleUrl(
@@ -609,8 +647,10 @@ class FileListController extends ActionController
 
         // New folder button
         if ($this->folderObject && $this->folderObject->checkActionPermission('write')
-            && ($this->folderObject->getStorage()->checkUserActionPermission('add',
-                    'File') || $this->folderObject->checkActionPermission('add'))
+            && ($this->folderObject->getStorage()->checkUserActionPermission(
+                'add',
+                    'File'
+            ) || $this->folderObject->checkActionPermission('add'))
         ) {
             $newButton = $buttonBar->makeLinkButton()
                 ->setHref(BackendUtility::getModuleUrl(
@@ -633,8 +673,10 @@ class FileListController extends ActionController
                 $elToConfirm = [];
                 foreach ($elFromTable as $key => $element) {
                     $clipBoardElement = $resourceFactory->retrieveFileOrFolderObject($element);
-                    if ($clipBoardElement instanceof Folder && $clipBoardElement->getStorage()->isWithinFolder($clipBoardElement,
-                            $this->folderObject)
+                    if ($clipBoardElement instanceof Folder && $clipBoardElement->getStorage()->isWithinFolder(
+                        $clipBoardElement,
+                            $this->folderObject
+                    )
                     ) {
                         $addPasteButton = false;
                     }
index f0b9a60..d2bdc15 100644 (file)
@@ -94,8 +94,13 @@ abstract class AbstractWidgetViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper
      */
     public function initializeArguments()
     {
-        $this->registerArgument('customWidgetId', 'string', 'extend the widget identifier with a custom widget id',
-            false, null);
+        $this->registerArgument(
+            'customWidgetId',
+            'string',
+            'extend the widget identifier with a custom widget id',
+            false,
+            null
+        );
     }
 
     /**
@@ -172,7 +177,9 @@ abstract class AbstractWidgetViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper
                 'initiateSubRequest() can not be called if there is no valid controller extending ' .
                 'TYPO3\\CMS\\Fluid\\Core\\Widget\\AbstractWidgetController' .
                 ' Got "' . ($this->controller ? get_class($this->controller) : gettype($this->controller)) .
-                '" in class "' . get_class($this) . '".', 1289422564);
+                '" in class "' . get_class($this) . '".',
+                1289422564
+            );
         }
         $subRequest = $this->objectManager->get(\TYPO3\CMS\Fluid\Core\Widget\WidgetRequest::class);
         $subRequest->setWidgetContext($this->widgetContext);
index 38b05af..977d781 100644 (file)
@@ -55,7 +55,8 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
         $this->registerArgument('name', 'string', 'Name of input tag');
         $this->registerArgument('value', 'mixed', 'Value of input tag');
         $this->registerArgument(
-            'property', 'string',
+            'property',
+            'string',
             'Name of Object Property. If used in conjunction with <f:form object="...">, "name" and "value" properties will be ignored.'
         );
     }
@@ -113,7 +114,8 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
     {
         if ($this->isObjectAccessorMode()) {
             $formObjectName = $this->viewHelperVariableContainer->get(
-                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName'
+                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+                'formObjectName'
             );
             if (!empty($formObjectName)) {
                 $propertySegments = explode('.', $this->arguments['property']);
@@ -230,7 +232,8 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
     {
         $propertyPath = rtrim(preg_replace('/(\\]\\[|\\[|\\])/', '.', $this->getNameWithoutPrefix()), '.');
         $value = ObjectAccess::getPropertyPath(
-            $this->renderingContext->getControllerContext()->getRequest()->getOriginalRequest()->getArguments(), $propertyPath
+            $this->renderingContext->getControllerContext()->getRequest()->getOriginalRequest()->getArguments(),
+            $propertyPath
         );
         return $value;
     }
@@ -246,7 +249,8 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
         }
 
         if (!$this->viewHelperVariableContainer->exists(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObject'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObject'
         )
         ) {
             return;
@@ -257,10 +261,12 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
             return;
         }
         $formObject = $this->viewHelperVariableContainer->get(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObject'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObject'
         );
         $objectName = $this->viewHelperVariableContainer->get(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObjectName'
         );
         // If count == 2 -> we need to go through the for-loop exactly once
         for ($i = 1; $i < count($propertySegments); $i++) {
@@ -269,11 +275,13 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
             $hiddenIdentityField = $this->renderHiddenIdentityField($object, $objectName);
             // Add the hidden identity field to the ViewHelperVariableContainer
             $additionalIdentityProperties = $this->viewHelperVariableContainer->get(
-                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'additionalIdentityProperties'
+                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+                'additionalIdentityProperties'
             );
             $additionalIdentityProperties[$objectName] = $hiddenIdentityField;
             $this->viewHelperVariableContainer->addOrUpdate(
-                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'additionalIdentityProperties',
+                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+                'additionalIdentityProperties',
                 $additionalIdentityProperties
             );
         }
@@ -287,13 +295,15 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
     protected function getPropertyValue()
     {
         if (!$this->viewHelperVariableContainer->exists(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObject'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObject'
         )
         ) {
             return null;
         }
         $formObject = $this->viewHelperVariableContainer->get(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObject'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObject'
         );
         return ObjectAccess::getPropertyPath($formObject, $this->arguments['property']);
     }
@@ -306,7 +316,8 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
     protected function isObjectAccessorMode()
     {
         return $this->hasArgument('property') && $this->viewHelperVariableContainer->exists(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObjectName'
         );
     }
 
@@ -344,7 +355,8 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
         }
         $originalRequestMappingResults = $this->getRequest()->getOriginalRequestMappingResults();
         $formObjectName = $this->viewHelperVariableContainer->get(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'formObjectName'
         );
         return $originalRequestMappingResults->forProperty($formObjectName)->forProperty($this->arguments['property']);
     }
@@ -359,11 +371,13 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
     {
         $hiddenFieldNames = [];
         if ($this->viewHelperVariableContainer->exists(
-            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'renderedHiddenFields'
+            \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+            'renderedHiddenFields'
         )
         ) {
             $hiddenFieldNames = $this->viewHelperVariableContainer->get(
-                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'renderedHiddenFields'
+                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+                'renderedHiddenFields'
             );
         }
         $fieldName = $this->getName();
@@ -373,7 +387,9 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper
         if (!in_array($fieldName, $hiddenFieldNames)) {
             $hiddenFieldNames[] = $fieldName;
             $this->viewHelperVariableContainer->addOrUpdate(
-                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'renderedHiddenFields', $hiddenFieldNames
+                \TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class,
+                'renderedHiddenFields',
+                $hiddenFieldNames
             );
             return '<input type="hidden" name="' . htmlspecialchars($fieldName) . '" value="" />';
         }
index 98380ed..f15139b 100644 (file)
@@ -52,30 +52,39 @@ class ButtonViewHelper extends AbstractFormFieldViewHelper
     {
         parent::initializeArguments();
         $this->registerTagAttribute(
-            'autofocus', 'string', 'Specifies that a button should automatically get focus when the page loads'
+            'autofocus',
+            'string',
+            'Specifies that a button should automatically get focus when the page loads'
         );
         $this->registerTagAttribute(
-            'disabled', 'string', 'Specifies that the input element should be disabled when the page loads'
+            'disabled',
+            'string',
+            'Specifies that the input element should be disabled when the page loads'
         );
         $this->registerTagAttribute('form', 'string', 'Specifies one or more forms the button belongs to');
         $this->registerTagAttribute(
-            'formaction', 'string',
+            'formaction',
+            'string',
             'Specifies where to send the form-data when a form is submitted. Only for type="submit"'
         );
         $this->registerTagAttribute(
-            'formenctype', 'string',
+            'formenctype',
+            'string',
             'Specifies how form-data should be encoded before sending it to a server. Only for type="submit" (e.g. "application/x-www-form-urlencoded", "multipart/form-data" or "text/plain")'
         );
         $this->registerTagAttribute(
-            'formmethod', 'string',
+            'formmethod',
+            'string',
             'Specifies how to send the form-data (which HTTP method to use). Only for type="submit" (e.g. "get" or "post")'
         );
         $this->registerTagAttribute(
-            'formnovalidate', 'string',
+            'formnovalidate',
+            'string',
             'Specifies that the form-data should not be validated on submission. Only for type="submit"'
         );
         $this->registerTagAttribute(
-            'formtarget', 'string',
+            'formtarget',
+            'string',
             'Specifies where to display the response after submitting the form. Only for type="submit" (e.g. "_blank", "_self", "_parent", "_top", "framename")'
         );
         $this->registerUniversalTagAttributes();
index 8981f6e..0eec3bb 100644 (file)
@@ -60,10 +60,16 @@ class CheckboxViewHelper extends AbstractFormFieldViewHelper
     {
         parent::initializeArguments();
         $this->registerTagAttribute(
-            'disabled', 'string', 'Specifies that the input element should be disabled when the page loads'
+            'disabled',
+            'string',
+            'Specifies that the input element should be disabled when the page loads'
         );
         $this->registerArgument(
-            'errorClass', 'string', 'CSS class to set if there are errors for this view helper', false, 'f3-form-error'
+            'errorClass',
+            'string',
+            'CSS class to set if there are errors for this view helper',
+            false,
+            'f3-form-error'
         );
         $this->overrideArgument('value', 'string', 'Value of input tag. Required for checkboxes', true);
         $this->registerUniversalTagAttributes();
index 30e4e42..9e0c1ea 100644 (file)
@@ -44,16 +44,24 @@ class PasswordViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormF
     {
         parent::initializeArguments();
         $this->registerTagAttribute(
-            'disabled', 'string', 'Specifies that the input element should be disabled when the page loads'
+            'disabled',
+            'string',
+            'Specifies that the input element should be disabled when the page loads'
         );
         $this->registerTagAttribute(
-            'maxlength', 'int', 'The maxlength attribute of the input field (will not be validated)'
+            'maxlength',
+            'int',
+            'The maxlength attribute of the input field (will not be validated)'
         );
         $this->registerTagAttribute('placeholder', 'string', 'The placeholder of the textfield');
         $this->registerTagAttribute('readonly', 'string', 'The readonly attribute of the input field');
         $this->registerTagAttribute('size', 'int', 'The size of the input field');
         $this->registerArgument(
-            'errorClass', 'string', 'CSS class to set if there are errors for this view helper', false, 'f3-form-error'
+            'errorClass',
+            'string',
+            'CSS class to set if there are errors for this view helper',
+            false,
+            'f3-form-error'
         );
         $this->registerUniversalTagAttributes();
     }
index c5374af..0eedcb8 100644 (file)
@@ -62,13 +62,19 @@ class RadioViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFiel
     {
         parent::initializeArguments();
         $this->registerArgument(
-            'errorClass', 'string', 'CSS class to set if there are errors for this view helper', false, 'f3-form-error'
+            'errorClass',
+            'string',
+            'CSS class to set if there are errors for this view helper',
+            false,
+            'f3-form-error'
         );
         $this->registerArgument('checked', 'bool', 'Specifies that the input element should be preselected');
         $this->overrideArgument('value', 'string', 'Value of input tag. Required for radio buttons', true);
         $this->registerUniversalTagAttributes();
         $this->registerTagAttribute(
-            'disabled', 'string', 'Specifies that the input element should be disabled when the page loads'
+            'disabled',
+            'string',
+            'Specifies that the input element should be disabled when the page loads'
         );
     }
 
index 4bfff5c..b7c3bc4 100644 (file)
@@ -171,7 +171,7 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
         return $content;
     }
 
-   /*
+    /**
      * Render prepended option tag
      *
      * @return string rendered prepended empty option
@@ -226,8 +226,8 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
                             throw new \TYPO3\CMS\Fluid\Core\ViewHelper\Exception('Identifying value for object of class "' . get_class($value) . '" was an object.', 1247827428);
                         }
                     }
-                // @todo use $this->persistenceManager->isNewObject() once it is implemented
                 } elseif ($this->persistenceManager->getIdentifierByObject($value) !== null) {
+                    // @todo use $this->persistenceManager->isNewObject() once it is implemented
                     $key = $this->persistenceManager->getIdentifierByObject($value);
                 } elseif (method_exists($value, '__toString')) {
                     $key = (string)$value;
@@ -245,8 +245,8 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
                     }
                 } elseif (method_exists($value, '__toString')) {
                     $value = (string)$value;
-                // @todo use $this->persistenceManager->isNewObject() once it is implemented
                 } elseif ($this->persistenceManager->getIdentifierByObject($value) !== null) {
+                    // @todo use $this->persistenceManager->isNewObject() once it is implemented
                     $value = $this->persistenceManager->getIdentifierByObject($value);
                 }
             }
index 19e6757..5ffe072 100644 (file)
@@ -51,7 +51,9 @@ class SubmitViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
     {
         parent::initializeArguments();
         $this->registerTagAttribute(
-            'disabled', 'string', 'Specifies that the input element should be disabled when the page loads'
+            'disabled',
+            'string',
+            'Specifies that the input element should be disabled when the page loads'
         );
         $this->registerUniversalTagAttributes();
     }
index f76c184..cb7811b 100644 (file)
@@ -109,8 +109,12 @@ class BytesViewHelper extends AbstractViewHelper
 
         return sprintf(
             '%s %s',
-            number_format(round($bytes, 4 * $arguments['decimals']), $arguments['decimals'],
-                $arguments['decimalSeparator'], $arguments['thousandsSeparator']),
+            number_format(
+                round($bytes, 4 * $arguments['decimals']),
+                $arguments['decimals'],
+                $arguments['decimalSeparator'],
+                $arguments['thousandsSeparator']
+            ),
             $units[$pow]
         );
     }
index 59e51c6..c34cbce 100644 (file)
@@ -189,9 +189,11 @@ class PaginateController extends AbstractWidgetController
             $modifiedObjects = array_slice($this->objects, $offset, $itemsPerPage);
             return $modifiedObjects;
         } else {
-            throw new \InvalidArgumentException('The view helper "' . get_class($this)
+            throw new \InvalidArgumentException(
+                'The view helper "' . get_class($this)
                 . '" accepts as argument "QueryResultInterface", "\SplObjectStorage", "ObjectStorage" or an array. '
-                . 'given: ' . get_class($this->objects), 1385547291
+                . 'given: ' . get_class($this->objects),
+                1385547291
             );
         }
     }
index 1b6f97c..771ed7a 100644 (file)
@@ -106,7 +106,10 @@ class StandaloneViewTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
         $this->singletonInstances = GeneralUtility::getSingletonInstances();
         $this->view = $this->getAccessibleMock(
             \TYPO3\CMS\Fluid\View\StandaloneView::class,
-            ['testFileExistence', 'buildParserConfiguration', 'getOrParseAndStoreTemplate'], [], '', false
+            ['testFileExistence', 'buildParserConfiguration', 'getOrParseAndStoreTemplate'],
+            [],
+            '',
+            false
         );
         $this->mockConfigurationManager = $this->createMock(ConfigurationManagerInterface::class);
         $this->mockObjectManager = $this->createMock(\TYPO3\CMS\Extbase\Object\ObjectManager::class);
index 27d3f0a..36ab886 100644 (file)
@@ -89,8 +89,10 @@ class RadioViewHelperTest extends ViewHelperBaseTestcase
 
         $result = $this->viewHelper->initializeArgumentsAndRender();
 
-        $this->assertContains('<input type="radio" name="fieldPrefix[objectName][someProperty]" value="foo" checked="checked" />',
-            $result);
+        $this->assertContains(
+            '<input type="radio" name="fieldPrefix[objectName][someProperty]" value="foo" checked="checked" />',
+            $result
+        );
     }
 
     /**
index 6e96808..92b2846 100644 (file)
@@ -63,8 +63,13 @@ class PaginateControllerTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestC
         $this->query->_set('persistenceManager', $this->persistenceManager);
         $this->dataMapper = $this->createMock(\TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapper::class);
         $this->query->_set('dataMapper', $this->dataMapper);
-        $this->controller = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController::class,
-            ['dummy'], [], '', false);
+        $this->controller = $this->getAccessibleMock(
+            \TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController::class,
+            ['dummy'],
+            [],
+            '',
+            false
+        );
         $this->controller->_set('view', $this->createMock(\TYPO3\CMS\Extbase\Mvc\View\ViewInterface::class));
     }
 
index 555e795..0ce6911 100644 (file)
@@ -43,19 +43,19 @@ class ConfigurationService
             ->getConfiguration(ConfigurationManagerInterface::CONFIGURATION_TYPE_YAML_SETTINGS, 'form');
     }
 
-     /**
-      * Get the prototype configuration
-      *
-      * @param string $prototypeName name of the prototype to get the configuration for
-      * @return array the prototype configuration
-      * @throws PrototypeNotFoundException if prototype with the name $prototypeName was not found
-      * @api
-      */
-     public function getPrototypeConfiguration(string $prototypeName): array
-     {
-         if (!isset($this->formSettings['prototypes'][$prototypeName])) {
-             throw new PrototypeNotFoundException(sprintf('The Prototype "%s" was not found.', $prototypeName), 1475924277);
-         }
-         return $this->formSettings['prototypes'][$prototypeName];
-     }
+    /**
+     * Get the prototype configuration
+     *
+     * @param string $prototypeName name of the prototype to get the configuration for
+     * @return array the prototype configuration
+     * @throws PrototypeNotFoundException if prototype with the name $prototypeName was not found
+     * @api
+     */
+    public function getPrototypeConfiguration(string $prototypeName): array
+    {
+        if (!isset($this->formSettings['prototypes'][$prototypeName])) {
+            throw new PrototypeNotFoundException(sprintf('The Prototype "%s" was not found.', $prototypeName), 1475924277);
+        }
+        return $this->formSettings['prototypes'][$prototypeName];
+    }
 }
index 62cde2d..ccabfdc 100644 (file)
@@ -89,8 +89,12 @@ class FlashMessageFinisher extends AbstractFinisher
                 break;
         }
 
-        $flashMessage = $this->objectManager->get(FlashMessage::class,
-            $message->render(), $message->getTitle(), $severity, true
+        $flashMessage = $this->objectManager->get(
+            FlashMessage::class,
+            $message->render(),
+            $message->getTitle(),
+            $severity,
+            true
         );
 
         $this->finisherContext->getControllerContext()->getFlashMessageQueue()->addMessage($flashMessage);
index e5e77e8..178b70c 100644 (file)
@@ -19,7 +19,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\Mvc\Exception\StopActionException;
 use TYPO3\CMS\Extbase\Mvc\Exception\UnsupportedRequestTypeException;
 use TYPO3\CMS\Extbase\Mvc\Web\Request;
-use TYPO3\CMS\Extbase\Mvc\Web\Response;
 use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
 
 /**
index f6e8758..5aaa7e8 100644 (file)
@@ -560,7 +560,8 @@ class FormRuntime implements RootRenderableInterface, \ArrayAccess
      */
     protected function invokeFinishers()
     {
-        $finisherContext = $this->objectManager->get(FinisherContext::class,
+        $finisherContext = $this->objectManager->get(
+            FinisherContext::class,
             $this,
             $this->getControllerContext()
         );
index 9be408a..fca1789 100644 (file)
@@ -27,7 +27,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\PathUtility;
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 use TYPO3\CMS\Form\Mvc\Configuration\ConfigurationManagerInterface;
-use TYPO3\CMS\Form\Mvc\Configuration\YamlSource;
 use TYPO3\CMS\Form\Mvc\Persistence\Exception\NoUniqueIdentifierException;
 use TYPO3\CMS\Form\Mvc\Persistence\Exception\NoUniquePersistenceIdentifierException;
 use TYPO3\CMS\Form\Mvc\Persistence\Exception\PersistenceManagerException;
index aac4fa8..69f7968 100644 (file)
@@ -18,7 +18,6 @@ namespace TYPO3\CMS\Form\Mvc;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\Error\Result;
 use TYPO3\CMS\Extbase\Object\ObjectManager;
-use TYPO3\CMS\Extbase\Property\PropertyMapper;
 use TYPO3\CMS\Extbase\Property\PropertyMappingConfiguration;
 use TYPO3\CMS\Extbase\Validation\Validator\ConjunctionValidator;
 use TYPO3\CMS\Extbase\Validation\Validator\ValidatorInterface;
index a1ea499..7faebd3 100644 (file)
@@ -63,7 +63,8 @@ class CountValidator extends AbstractValidator
                     'form',
                     [$minimum, $maximum]
                 ),
-                1475002994, [$this->options['minimum'], $this->options['maximum']]
+                1475002994,
+                [$this->options['minimum'], $this->options['maximum']]
             );
         }
     }
index 66df1da..ec02cc4 100644 (file)
@@ -19,7 +19,6 @@ namespace TYPO3\CMS\Form\ViewHelpers\Form;
 
 use TYPO3\CMS\Core\Page\PageRenderer;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Extbase\Property\PropertyMapper;
 use TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFieldViewHelper;
 use TYPO3\CMS\Form\ViewHelpers\RenderRenderableViewHelper;
 
@@ -194,7 +193,8 @@ class DatePickerViewHelper extends AbstractFormFieldViewHelper
                         });
                     });
                 }
-            ');
+            '
+        );
     }
 
     /**
index 79b38aa..1259e32 100644 (file)
@@ -17,7 +17,6 @@ namespace TYPO3\CMS\Form\ViewHelpers\Form;
  * The TYPO3 project - inspiring people to share!
  */
 
-use TYPO3\CMS\Extbase\Property\PropertyMapper;
 use TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFieldViewHelper;
 use TYPO3\CMS\Form\ViewHelpers\RenderRenderableViewHelper;
 
index ea8f319..c8f7070 100644 (file)
@@ -16,7 +16,6 @@ namespace TYPO3\CMS\Form\ViewHelpers\Form;
  */
 
 use TYPO3\CMS\Extbase\Domain\Model\FileReference;
-use TYPO3\CMS\Extbase\Property\PropertyMapper;
 use TYPO3\CMS\Extbase\Security\Cryptography\HashService;
 use TYPO3\CMS\Fluid\ViewHelpers\Form\UploadViewHelper;
 
index 7db7d69..1d7fb12 100644 (file)
@@ -18,7 +18,6 @@ namespace TYPO3\CMS\Form\ViewHelpers;
  */
 
 use TYPO3\CMS\Extbase\Mvc\Web\Request;
-use TYPO3\CMS\Extbase\Security\Cryptography\HashService;
 use TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper as FluidFormViewHelper;
 use TYPO3Fluid\Fluid\Core\ViewHelper\TagBuilder;
 
index 2efe7d5..bb9459c 100644 (file)
@@ -29,8 +29,14 @@ class AbstractSectionTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
      */
     public function createElementThrowsExceptionIfTypeDefinitionNotFound()
     {
-        $mockAbstractSection = $this->getAccessibleMockForAbstractClass(AbstractSection::class,
-            [], '', false, true, true, [
+        $mockAbstractSection = $this->getAccessibleMockForAbstractClass(
+            AbstractSection::class,
+            [],
+            '',
+            false,
+            true,
+            true,
+            [
                 'getRootForm',
             ]
         );
index 1f5b2cf..7ac9369 100644 (file)
@@ -54,7 +54,11 @@ class DataStructureIdentifierHookTest extends \TYPO3\TestingFramework\Core\Unit\
     {
         $givenIdentifier = ['aKey' => 'aValue'];
         $result = (new DataStructureIdentifierHook())->getDataStructureIdentifierPostProcess(
-            [], 'aTable', 'aField', [], $givenIdentifier
+            [],
+            'aTable',
+            'aField',
+            [],
+            $givenIdentifier
         );
         $this->assertEquals($givenIdentifier, $result);
     }
@@ -65,7 +69,11 @@ class DataStructureIdentifierHookTest extends \TYPO3\TestingFramework\Core\Unit\
     public function getDataStructureIdentifierPostProcessAddDefaultValuesForNewRecord()
     {
         $result = (new DataStructureIdentifierHook())->getDataStructureIdentifierPostProcess(
-            [], 'tt_content', 'pi_flexform', ['CType' => 'form_formframework'], []
+            [],
+            'tt_content',
+            'pi_flexform',
+            ['CType' => 'form_formframework'],
+            []
         );
         $this->assertEquals(
             ['ext-form-persistenceIdentifier' => '', 'ext-form-overrideFinishers' => false],
@@ -103,7 +111,11 @@ class DataStructureIdentifierHookTest extends \TYPO3\TestingFramework\Core\Unit\
             'ext-form-overrideFinishers' => false,
         ];
         $result = (new DataStructureIdentifierHook())->getDataStructureIdentifierPostProcess(
-            [], 'tt_content', 'pi_flexform', $row, $incomingIdentifier
+            [],
+            'tt_content',
+            'pi_flexform',
+            $row,
+            $incomingIdentifier
         );
         $this->assertEquals($expected, $result);
     }
@@ -134,7 +146,11 @@ class DataStructureIdentifierHookTest extends \TYPO3\TestingFramework\Core\Unit\
             'ext-form-overrideFinishers' => true,
         ];
         $result = (new DataStructureIdentifierHook())->getDataStructureIdentifierPostProcess(
-            [], 'tt_content', 'pi_flexform', $row, []
+            [],
+            'tt_content',
+            'pi_flexform',
+            $row,
+            []
         );
         $this->assertEquals($expected, $result);
     }
@@ -147,7 +163,8 @@ class DataStructureIdentifierHookTest extends \TYPO3\TestingFramework\Core\Unit\
         $dataStructure = ['foo' => 'bar'];
         $expected = $dataStructure;
         $result = (new DataStructureIdentifierHook())->parseDataStructureByIdentifierPostProcess(
-            $dataStructure, []
+            $dataStructure,
+            []
         );
         $this->assertEquals($expected, $result);
     }
index 9a687ed..20afcff 100644 (file)
@@ -5248,8 +5248,8 @@ class ContentObjectRenderer
                 // Resource was not found
                 return $linkText;
             }
-        // Disallow direct javascript: or data: links
         } elseif (in_array(strtolower(trim($linkHandlerKeyword)), ['javascript', 'data'], true)) {
+            // Disallow direct javascript: or data: links
             return $linkText;
         } else {
             $linkParameter = $linkParameterParts['url'];
@@ -5383,8 +5383,8 @@ class ContentObjectRenderer
         // Target attribute
         if (!empty($target)) {
             $tagAttributes['target'] = htmlspecialchars($target);
-        // Create TARGET-attribute only if the right doctype is used
         } elseif ($JSwindowParams && !in_array($tsfe->xhtmlDoctype, ['xhtml_strict', 'xhtml_11'], true)) {
+            // Create TARGET-attribute only if the right doctype is used
             $tagAttributes['target'] = 'FEopenLink';
         }
 
@@ -6340,9 +6340,16 @@ class ContentObjectRenderer
                             $theList = array_merge(
                                 GeneralUtility::intExplode(
                                     ',',
-                                    $this->getTreeList($next_id, $depth - 1, $begin - 1,
-                                        $dontCheckEnableFields, $addSelectFields, $moreWhereClauses,
-                                        $prevId_array, $recursionLevel + 1),
+                                    $this->getTreeList(
+                                        $next_id,
+                                        $depth - 1,
+                                        $begin - 1,
+                                        $dontCheckEnableFields,
+                                        $addSelectFields,
+                                        $moreWhereClauses,
+                                        $prevId_array,
+                                        $recursionLevel + 1
+                                    ),
                                     true
                                 ),
                                 $theList
@@ -6515,7 +6522,8 @@ class ContentObjectRenderer
             'where'
         ];
         foreach ($properties as $property) {
-            $conf[$property] = trim(isset($conf[$property . '.'])
+            $conf[$property] = trim(
+                isset($conf[$property . '.'])
                 ? $this->stdWrap($conf[$property], $conf[$property . '.'])
                 : $conf[$property]
             );
index f8f3295..862ac1a 100644 (file)
@@ -159,12 +159,12 @@ class FluidTemplateContentObject extends AbstractContentObject
                 ? $this->cObj->stdWrap(isset($conf['templateName']) ? $conf['templateName'] : '', $conf['templateName.'])
                 : $conf['templateName'];
             $this->view->setTemplate($templateName);
-        // Fetch the Fluid template by template cObject
         } elseif (!empty($conf['template']) && !empty($conf['template.'])) {
+            // Fetch the Fluid template by template cObject
             $templateSource = $this->cObj->cObjGetSingle($conf['template'], $conf['template.']);
             $this->view->setTemplateSource($templateSource);
-        // Fetch the Fluid template by file stdWrap
         } else {
+            // Fetch the Fluid template by file stdWrap
             $file = isset($conf['file.']) ? $this->cObj->stdWrap($conf['file'], $conf['file.']) : $conf['file'];
             /** @var $templateService \TYPO3\CMS\Core\TypoScript\TemplateService */
             $templateService = $GLOBALS['TSFE']->tmpl;
index ae66e18..9b6a573 100644 (file)
@@ -345,7 +345,8 @@ abstract class AbstractMenuContentObject
                     }
                     // Add to register:
                     $this->rL_uidRegister[] = 'ITEM:' . $v_rl['uid'] .
-                        (!empty($rl_MParray)
+                        (
+                            !empty($rl_MParray)
                             ? ':' . implode(',', $rl_MParray)
                             : ''
                         );
@@ -387,7 +388,8 @@ abstract class AbstractMenuContentObject
                     $nextMParray[] = $this->tmpl->rootLine[$currentLevel]['_MP_PARAM'];
                 }
                 $this->nextActive = $this->tmpl->rootLine[$currentLevel]['uid'] .
-                    (!empty($nextMParray)
+                    (
+                        !empty($nextMParray)
                         ? ':' . implode(',', $nextMParray)
                         : ''
                     );
@@ -948,9 +950,11 @@ abstract class AbstractMenuContentObject
         // Max number of items
         $limit = MathUtility::forceIntegerInRange($this->conf['special.']['limit'], 0, 100);
         // Start point
-        $eLevel = $this->parent_cObj->getKey(isset($this->conf['special.']['entryLevel.'])
+        $eLevel = $this->parent_cObj->getKey(
+            isset($this->conf['special.']['entryLevel.'])
             ? $this->parent_cObj->stdWrap($this->conf['special.']['entryLevel'], $this->conf['special.']['entryLevel.'])
-            : $this->conf['special.']['entryLevel'], $this->tmpl->rootLine
+            : $this->conf['special.']['entryLevel'],
+            $this->tmpl->rootLine
         );
         $startUid = (int)$this->tmpl->rootLine[$eLevel]['uid'];
         // Which field is for keywords
index 34370df..c54cb4c 100644 (file)
@@ -98,7 +98,8 @@ class RequestHandler implements RequestHandlerInterface
         if ($GLOBALS['TYPO3_CONF_VARS']['FE']['pageUnavailable_force']
             && !GeneralUtility::cmpIP(
                 GeneralUtility::getIndpEnv('REMOTE_ADDR'),
-                $GLOBALS['TYPO3_CONF_VARS']['SYS']['devIPmask'])
+                $GLOBALS['TYPO3_CONF_VARS']['SYS']['devIPmask']
+            )
         ) {