[TASK] Fix CGL "InlineCommentWrongStyle" in sysext "version"
authorRoland Waldner <most.wanted@gmx.at>
Sun, 3 Jun 2012 15:56:06 +0000 (17:56 +0200)
committerSusanne Moog <typo3@susannemoog.de>
Mon, 11 Jun 2012 18:02:50 +0000 (20:02 +0200)
There are violations against the CGL rule "InlineCommentWrongStyle".

This will be fixed.

Change-Id: I3906272a23b2b8fe740af21de37edbb3d8ca1aaa
Resolves: #37716
Releases: 6.0
Reviewed-on: http://review.typo3.org/11812
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
typo3/sysext/version/cm1/index.php
typo3/sysext/version/ext_emconf.php
typo3/sysext/version/ws/index.php

index 76247ba..490d62b 100755 (executable)
@@ -549,46 +549,44 @@ class tx_version_cm1 extends t3lib_SCbase {
 
                foreach ($tableNames as $tN) {
                                // Basically list ALL tables - not only those being copied might be found!
-                       #if ($GLOBALS['TCA'][$tN]['ctrl']['versioning_followPages'] || $tN=='pages')    {
-                               $mres = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
-                                       '*',
-                                       $tN,
-                                       'pid=' . intval($pid) . t3lib_BEfunc::deleteClause($tN),
-                                       '',
-                                       ($GLOBALS['TCA'][$tN]['ctrl']['sortby'] ? $GLOBALS['TCA'][$tN]['ctrl']['sortby'] : '')
-                               );
+                       $mres = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
+                               '*',
+                               $tN,
+                               'pid=' . intval($pid) . t3lib_BEfunc::deleteClause($tN),
+                               '',
+                               ($GLOBALS['TCA'][$tN]['ctrl']['sortby'] ? $GLOBALS['TCA'][$tN]['ctrl']['sortby'] : '')
+                       );
 
-                               if ($GLOBALS['TYPO3_DB']->sql_num_rows($mres))  {
+                       if ($GLOBALS['TYPO3_DB']->sql_num_rows($mres))  {
+                               $content.='
+                                       <tr>
+                                               <td colspan="4" class="' . ($GLOBALS['TCA'][$tN]['ctrl']['versioning_followPages'] ? 'bgColor6' : ($tN == 'pages' ? 'bgColor5' : 'bgColor-10')) . '"' . (!$GLOBALS['TCA'][$tN]['ctrl']['versioning_followPages'] && $tN !== 'pages' ? ' style="color: #666666; font-style:italic;"' : '') . '>' . $tN . '</td>
+                                       </tr>';
+                               while ($subrow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($mres))  {
+                                       $ownVer = $this->lookForOwnVersions($tN,$subrow['uid']);
                                        $content.='
                                                <tr>
-                                                       <td colspan="4" class="' . ($GLOBALS['TCA'][$tN]['ctrl']['versioning_followPages'] ? 'bgColor6' : ($tN == 'pages' ? 'bgColor5' : 'bgColor-10')) . '"' . (!$GLOBALS['TCA'][$tN]['ctrl']['versioning_followPages'] && $tN !== 'pages' ? ' style="color: #666666; font-style:italic;"' : '') . '>' . $tN . '</td>
+                                                       <td>'.$this->adminLinks($tN,$subrow).'</td>
+                                                       <td>'.$subrow['uid'].'</td>
+                                                       '.($ownVer>1 ? '<td style="font-weight: bold; background-color: yellow;"><a href="index.php?table='.rawurlencode($tN).'&uid='.$subrow['uid'].'">'.($ownVer-1).'</a></td>' : '<td></td>').'
+                                                       <td width="98%">'.t3lib_BEfunc::getRecordTitle($tN,$subrow,TRUE).'</td>
                                                </tr>';
-                                       while ($subrow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($mres))  {
-                                               $ownVer = $this->lookForOwnVersions($tN,$subrow['uid']);
-                                               $content.='
-                                                       <tr>
-                                                               <td>'.$this->adminLinks($tN,$subrow).'</td>
-                                                               <td>'.$subrow['uid'].'</td>
-                                                               '.($ownVer>1 ? '<td style="font-weight: bold; background-color: yellow;"><a href="index.php?table='.rawurlencode($tN).'&uid='.$subrow['uid'].'">'.($ownVer-1).'</a></td>' : '<td></td>').'
-                                                               <td width="98%">'.t3lib_BEfunc::getRecordTitle($tN,$subrow,TRUE).'</td>
-                                                       </tr>';
 
-                                               if ($tN == 'pages' && $c<100)   {
-                                                       $sub = $this->pageSubContent($subrow['uid'],$c+1);
-
-                                                       if ($sub)       {
-                                                               $content.='
-                                                                       <tr>
-                                                                               <td></td>
-                                                                               <td></td>
-                                                                               <td></td>
-                                                                               <td width="98%">'.$sub.'</td>
-                                                                       </tr>';
-                                                       }
+                                       if ($tN == 'pages' && $c<100)   {
+                                               $sub = $this->pageSubContent($subrow['uid'],$c+1);
+
+                                               if ($sub)       {
+                                                       $content.='
+                                                               <tr>
+                                                                       <td></td>
+                                                                       <td></td>
+                                                                       <td></td>
+                                                                       <td width="98%">'.$sub.'</td>
+                                                               </tr>';
                                                }
                                        }
                                }
-                       #}
+                       }
                }
 
                return $content ? '<table border="1" cellpadding="1" cellspacing="0" width="100%">'.$content.'</table>' : '';
@@ -1592,7 +1590,6 @@ class tx_version_cm1 extends t3lib_SCbase {
         * @return      string          HTML content, mainly link tags and images.
         */
        function displayWorkspaceOverview_stageCmd($table,&$rec_off)    {
-#debug($rec_off['t3ver_stage']);
                switch ((int)$rec_off['t3ver_stage']) {
                        case 0:
                                $sId = 1;
@@ -1625,7 +1622,6 @@ class tx_version_cm1 extends t3lib_SCbase {
                                $color = '';
                        break;
                }
-#debug($sId);
 
                $raiseOk = !$GLOBALS['BE_USER']->workspaceCannotEditOfflineVersion($table,$rec_off);
 
index a8cfbdc..6922939 100644 (file)
@@ -1,14 +1,14 @@
 <?php
 
-########################################################################
-# Extension Manager/Repository config file for ext "version".
-#
-# Auto generated 13-03-2012 16:03
-#
-# Manual updates:
-# Only the data in the array - everything else is removed by next
-# writing. "version" and "dependencies" must not be touched!
-########################################################################
+/***************************************************************
+* Extension Manager/Repository config file for ext "version".
+*
+* Auto generated 13-03-2012 16:03
+*
+* Manual updates:
+* Only the data in the array - everything else is removed by next
+* writing. "version" and "dependencies" must not be touched!
+***************************************************************/
 
 $EM_CONF[$_EXTKEY] = array(
        'title' => 'Versioning Management',
index ee4914d..7334922 100755 (executable)
@@ -184,8 +184,6 @@ class SC_mod_user_ws_index extends t3lib_SCbase {
        function execute()      {
                $post = t3lib_div::_POST();
 
-#              debug($post);
-
                if ($post['_with_selected_do']) {
                        if (is_array($post['items']) && count($post['items']))  {
                                $cmdArray = array();