[TASK] Code cleanup based on Psalm static analyser 79/51679/5
authorWouter Wolters <typo3@wouterwolters.nl>
Tue, 14 Feb 2017 16:59:19 +0000 (17:59 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 15 Feb 2017 13:00:40 +0000 (14:00 +0100)
Code cleanup based on the static analyser Psalm.
https://github.com/vimeo/psalm

Resolves: #79815
Releases: master
Change-Id: I67dd33a79564b81931515f210644e980f83d3b7b
Reviewed-on: https://review.typo3.org/51679
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
98 files changed:
typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php
typo3/sysext/backend/Classes/Tree/AbstractTree.php
typo3/sysext/backend/Classes/Tree/Pagetree/CollectionProcessorInterface.php
typo3/sysext/backend/Classes/Tree/Renderer/AbstractTreeRenderer.php
typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php
typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php
typo3/sysext/compatibility7/Configuration/TCA/Overrides/pages.php
typo3/sysext/core/Classes/Cache/Backend/TaggableBackendInterface.php
typo3/sysext/core/Classes/Cache/CacheManager.php
typo3/sysext/core/Classes/Cache/Frontend/FrontendInterface.php
typo3/sysext/core/Classes/Compatibility/LoadedExtensionArrayElement.php
typo3/sysext/core/Classes/Compatibility/LoadedExtensionsArray.php
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php
typo3/sysext/core/Classes/Database/Connection.php
typo3/sysext/core/Classes/Database/PdoHelper.php
typo3/sysext/core/Classes/Database/PreProcessQueryHookInterface.php
typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/IntegerDataType.php
typo3/sysext/core/Classes/Database/Schema/TableDiff.php
typo3/sysext/core/Classes/ExtDirect/ExtDirectApi.php
typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php
typo3/sysext/core/Classes/Http/Request.php
typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php
typo3/sysext/core/Classes/Package/PackageManager.php
typo3/sysext/core/Classes/Resource/ResourceCompressor.php
typo3/sysext/core/Classes/Resource/Service/MagicImageService.php
typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php
typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Tests/Unit/Cache/Backend/Fixtures/ConcreteBackendFixture.php
typo3/sysext/core/Tests/Unit/Cache/Fixtures/FrontendFixture.php
typo3/sysext/css_styled_content/Tests/Functional/Tca/ContentVisibleFieldsTest.php
typo3/sysext/extbase/Classes/Domain/Model/FrontendUser.php
typo3/sysext/extbase/Classes/Error/Result.php
typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php
typo3/sysext/extbase/Classes/Persistence/Generic/Query.php
typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/ContainerConstructorInjectionTestFixtures.php
typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/Testclasses.php
typo3/sysext/extbase/Tests/Unit/Property/PropertyMapperTest.php
typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/ArrayAccessClass.php
typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithGettersAndSetters.php
typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractValidatorTestcase.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/BooleanValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/FloatValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberRangeValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/RawValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/RegularExpressionValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringValidatorTest.php
typo3/sysext/extbase/Tests/Unit/Validation/Validator/TextValidatorTest.php
typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php
typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractExtensionXmlParser.php
typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPushParser.php
typo3/sysext/filemetadata/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php
typo3/sysext/fluid_styled_content/Tests/Functional/Tca/ContentVisibleFieldsTest.php
typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php
typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php
typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php
typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/PlainTextMailViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php
typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php
typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
typo3/sysext/frontend/Tests/Unit/ContentObject/Fixtures/PageRepositoryFixture.php
typo3/sysext/func/Classes/Controller/PageFunctionsController.php
typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContent/ExportTest.php
typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImages/ExportTest.php
typo3/sysext/impexp/Tests/Functional/Fixtures/Extensions/impexp_group_files/Configuration/TCA/tx_impexpgroupfiles_item.php
typo3/sysext/impexp/Tests/Functional/Import/IrreTutorialRecords/ImportInEmptyDatabaseTest.php
typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContent/ImportInEmptyDatabaseTest.php
typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportInEmptyDatabaseTest.php
typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportInFilledDatabaseTest.php
typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php
typo3/sysext/rtehtmlarea/Classes/Controller/SpellCheckingController.php
typo3/sysext/rtehtmlarea/Classes/Extension/MicroDataSchema.php
typo3/sysext/rtehtmlarea/Classes/ImageHandler/EditImageHandler.php
typo3/sysext/rtehtmlarea/Configuration/TCA/tx_rtehtmlarea_acronym.php
typo3/sysext/rtehtmlarea/Tests/Functional/Tca/AcronymVisibleFieldsTest.php
typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php
typo3/sysext/scheduler/Classes/CronCommand/CronCommand.php
typo3/sysext/scheduler/Classes/Task/AbstractTask.php
typo3/sysext/scheduler/Tests/Functional/Tca/TaskGroupVisibleFieldsTest.php
typo3/sysext/sys_note/Tests/Functional/Tca/NoteVisibleFieldsTest.php
typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php
typo3/sysext/workspaces/Classes/Hooks/PagetreeCollectionsProcessor.php
typo3/sysext/workspaces/Classes/Service/GridDataService.php
typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
typo3/sysext/workspaces/Tests/Functional/ActionHandler/ActionHandlerTest.php
typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php
typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceStageVisibleFieldsTest.php
typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceVisibleFieldsTest.php

index 09e1aa7..efcf03c 100644 (file)
@@ -218,7 +218,7 @@ abstract class AbstractRecordList
      * @param array $data Is the dataarray, record with the fields. Notice: These fields are (currently) NOT htmlspecialchar'ed before being wrapped in <td>-tags
      * @param string $rowParams Is insert in the <tr>-tags. Must carry a ' ' as first character
      * @param string $_ OBSOLETE - NOT USED ANYMORE. $lMargin is the leftMargin (int)
-     * @param string $_ OBSOLETE - NOT USED ANYMORE. Is the HTML <img>-tag for an alternative 'gfx/ol/line.gif'-icon (used in the top)
+     * @param string $_2 OBSOLETE - NOT USED ANYMORE. Is the HTML <img>-tag for an alternative 'gfx/ol/line.gif'-icon (used in the top)
      * @param string $colType Defines the tag being used for the columns. Default is td.
      * @return string HTML content for the table row
      */
index bf3db19..b327f73 100644 (file)
@@ -51,7 +51,7 @@ abstract class AbstractTree
     }
 
     /**
-     * @param \TYPO3\CMS\Backend\Tree\Renderer\AbstractTreeRenderer $dataProvider
+     * @param \TYPO3\CMS\Backend\Tree\Renderer\AbstractTreeRenderer $nodeRenderer
      * @return void
      */
     public function setNodeRenderer(\TYPO3\CMS\Backend\Tree\Renderer\AbstractTreeRenderer $nodeRenderer)
index 9ea20d4..1d7a470 100644 (file)
@@ -22,7 +22,6 @@ interface CollectionProcessorInterface
     /**
      * Post process the subelement collection of a specific node
      *
-     * @abstract
      * @param \TYPO3\CMS\Backend\Tree\Pagetree\PagetreeNode $node
      * @param int $mountPoint
      * @param int $level
@@ -34,7 +33,6 @@ interface CollectionProcessorInterface
     /**
      * Post process the subelement collection of a specific node-filter combination
      *
-     * @abstract
      * @param \TYPO3\CMS\Backend\Tree\Pagetree\PagetreeNode $node
      * @param string $searchFilter
      * @param int $mountPoint
@@ -46,7 +44,6 @@ interface CollectionProcessorInterface
     /**
      * Post process the collection of tree mounts
      *
-     * @abstract
      * @param string $searchFilter
      * @param \TYPO3\CMS\Backend\Tree\Pagetree\PagetreeNodeCollection $nodeCollection
      * @return void
index a5d2b5f..b76c33d 100644 (file)
@@ -31,7 +31,7 @@ abstract class AbstractTreeRenderer
     /**
      * Renders a node collection recursive or just a single instance
      *
-     * @param \TYPO3\CMS\Backend\Tree\TreeNodeCollection $node
+     * @param \TYPO3\CMS\Backend\Tree\TreeNodeCollection $collection
      * @param bool $recursive
      * @return mixed
      */
@@ -40,7 +40,7 @@ abstract class AbstractTreeRenderer
     /**
      * Renders an tree recursive or just a single instance
      *
-     * @param \TYPO3\CMS\Backend\Tree\AbstractTree $node
+     * @param \TYPO3\CMS\Backend\Tree\AbstractTree $tree
      * @param bool $recursive
      * @return mixed
      */
index 5709f44..758c522 100644 (file)
@@ -65,7 +65,7 @@ class BackendUser extends \TYPO3\CMS\Extbase\Domain\Model\BackendUser
     }
 
     /**
-     * @param string
+     * @param string $dbMountPoints
      * @return void
      */
     public function setDbMountPoints($dbMountPoints)
index 0b432a2..638c187 100644 (file)
@@ -51,6 +51,9 @@ class SearchFormController extends \TYPO3\CMS\Frontend\Plugin\AbstractPlugin
      */
     public $join_pages = 0;
 
+    /**
+     * @var int
+     */
     public $defaultResultNumber = 10;
 
     /**
@@ -150,6 +153,9 @@ class SearchFormController extends \TYPO3\CMS\Frontend\Plugin\AbstractPlugin
      */
     public $templateCode = '';
 
+    /**
+     * @var string
+     */
     public $hiddenFieldList = 'ext, type, defOp, media, order, group, lang, desc, results';
 
     /**
@@ -164,6 +170,9 @@ class SearchFormController extends \TYPO3\CMS\Frontend\Plugin\AbstractPlugin
      */
     public $enableMetaphoneSearch = false;
 
+    /**
+     * @var bool
+     */
     public $storeMetaphoneInfoAsWords;
 
     /**
index fe6521b..b0de2f1 100644 (file)
@@ -29,5 +29,5 @@ defined('TYPO3_MODE') or die();
     ]
 ]);
 
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addFieldsToPalette('pages', 3, 'url_scheme', 'after:cache_tags');
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addFieldsToPalette('pages', '3', 'url_scheme', 'after:cache_tags');
 \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addFieldsToPalette('pages', 'links', '--linebreak--, url_scheme;LLL:EXT:compatibility7/Resources/Private/Language/locallang_tca.xlf:pages.url_scheme_formlabel', 'after:target');
index 8dd7db8..f58cc67 100644 (file)
@@ -29,7 +29,7 @@ interface TaggableBackendInterface extends \TYPO3\CMS\Core\Cache\Backend\Backend
     /**
      * Removes all cache entries of this cache which are tagged by any of the specified tags.
      *
-     * @param string[] $tag List of tags
+     * @param string[] $tags List of tags
      * @return void
      * @api
      */
index d71b84b..a975ffd 100644 (file)
@@ -244,7 +244,7 @@ class CacheManager implements SingletonInterface
     /**
      * Flushes entries tagged by any of the specified tags in all registered caches.
      *
-     * @param string[] $tag Tags to search for
+     * @param string[] $tags Tags to search for
      * @return void
      * @api
      */
index 5863c61..07db084 100644 (file)
@@ -117,7 +117,7 @@ interface FrontendInterface
     /**
      * Removes all cache entries of this cache which are tagged by any of the specified tags.
      *
-     * @param string[] $tag List of tags
+     * @param string[] $tags List of tags
      * @return void
      * @api
      */
index 388ff1b..23e9ec6 100644 (file)
@@ -105,8 +105,6 @@ class LoadedExtensionArrayElement implements \IteratorAggregate, \ArrayAccess, \
 
     /**
      * Register found files in extension array if extension was found
-     *
-     * @param void
      */
     protected function initializeExtensionFiles()
     {
index 485f3c1..2ab8ac7 100644 (file)
@@ -37,7 +37,7 @@ class LoadedExtensionsArray implements \Iterator, \ArrayAccess, \Serializable, \
     protected $iteratorPosition;
 
     /**
-     * @param \TYPO3\CMS\Core\Package\PackageManager
+     * @param \TYPO3\CMS\Core\Package\PackageManager $packageManager
      */
     public function __construct(\TYPO3\CMS\Core\Package\PackageManager $packageManager)
     {
index 01a0d07..4a6688c 100644 (file)
@@ -3275,7 +3275,7 @@ class DataHandler
      *
      * @param string $table Element table
      * @param int $uid Element UID
-     * @param int $destPid: >=0 then it points to a page-id on which to insert the record (as the first element). <0 then it points to a uid from its own table after which to insert it (works if
+     * @param int $destPid >=0 then it points to a page-id on which to insert the record (as the first element). <0 then it points to a uid from its own table after which to insert it (works if
      * @param bool $first Is a flag set, if the record copied is NOT a 'slave' to another record copied. That is, if this record was asked to be copied in the cmd-array
      * @param array $overrideValues Associative array with field/value pairs to override directly. Notice; Fields must exist in the table record and NOT be among excluded fields!
      * @param string $excludeFields Commalist of fields to exclude from the copy process (might get default values)
index 2654a61..d10b50c 100644 (file)
@@ -672,7 +672,7 @@ class DataMapProcessor
      *
      * @param string $tableName
      * @param array $ids
-     * @param array|null $fieldNames
+     * @param array $fieldNames
      * @return array
      */
     protected function fetchDependentElements(string $tableName, array $ids, array $fieldNames)
@@ -793,7 +793,7 @@ class DataMapProcessor
      *
      * @param DataMapItem $item
      * @param string $scope
-     * @param null|bool $modified
+     * @param bool $modified
      * @return string[]
      */
     protected function getFieldNamesForItemScope(
index 2a2ed6f..531f841 100644 (file)
@@ -413,7 +413,7 @@ class Connection extends \Doctrine\DBAL\Connection
      * are not required / and only the table name is passed through.
      *
      * @param string|null $tableName
-     * @param string|null $fieldName
+     * @param string $fieldName
      * @return string
      */
     public function lastInsertId($tableName = null, string $fieldName = 'uid'): string
index 4839a5e..e9e6543 100644 (file)
@@ -27,7 +27,7 @@ class PdoHelper
      * be given as "field"(xyz) - no space between double quote and parenthesis -
      * so they can be removed automatically.
      *
-     * @param PDO $databaseHandle
+     * @param \PDO $databaseHandle
      * @param string $pdoDriver
      * @param string $pathAndFilename
      * @return void
index ed27921..aac83e5 100644 (file)
@@ -39,7 +39,7 @@ interface PreProcessQueryHookInterface
      *
      * @param string $table Database table name
      * @param array $fieldsValues Field values as key => value pairs
-     * @param string/array $noQuoteFields List/array of keys NOT to quote
+     * @param string|array $noQuoteFields List/array of keys NOT to quote
      * @param \TYPO3\CMS\Core\Database\DatabaseConnection $parentObject
      * @return void
      */
@@ -53,7 +53,7 @@ interface PreProcessQueryHookInterface
      * @param string $table Database table name
      * @param array $fields Field names
      * @param array $rows Table rows
-     * @param string/array $noQuoteFields List/array of keys NOT to quote
+     * @param string|array $noQuoteFields List/array of keys NOT to quote
      * @param \TYPO3\CMS\Core\Database\DatabaseConnection $parentObject
      * @return void
      */
@@ -65,7 +65,7 @@ interface PreProcessQueryHookInterface
      * @param string $table Database table name
      * @param string $where WHERE clause
      * @param array $fieldsValues Field values as key => value pairs
-     * @param string/array $noQuoteFields List/array of keys NOT to quote
+     * @param string|array $noQuoteFields List/array of keys NOT to quote
      * @param \TYPO3\CMS\Core\Database\DatabaseConnection $parentObject
      * @return void
      */
index 991c096..df47ee8 100644 (file)
@@ -24,7 +24,7 @@ class IntegerDataType extends AbstractDataType
     /**
      * IntegerDataType constructor.
      *
-     * @param $length
+     * @param int $length
      * @param array $options
      */
     public function __construct(int $length, array $options)
index f0ac5e4..9687292 100644 (file)
@@ -46,7 +46,7 @@ class TableDiff extends \Doctrine\DBAL\Schema\TableDiff
      * @param array $tableOptions
      * @return \TYPO3\CMS\Core\Database\Schema\TableDiff
      */
-    public function setTableOptions(array $tableOptions): self
+    public function setTableOptions(array $tableOptions): TableDiff
     {
         $this->tableOptions = $tableOptions;
 
index 1f7218f..f77af5b 100644 (file)
@@ -87,7 +87,7 @@ class ExtDirectApi
      * Generates the API that is configured inside the ExtDirect configuration
      * array "$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ExtDirect']".
      *
-     * @param array $filerNamespace Namespace that should be loaded like array('TYPO3.Backend')
+     * @param array $filterNamespaces Namespace that should be loaded like array('TYPO3.Backend')
      * @return array Javascript API configuration
      */
     protected function generateAPI(array $filterNamespaces)
index 4fee28f..2030e15 100644 (file)
@@ -67,7 +67,7 @@ class FormProtectionFactory
      * @param string $classNameOrType Name of a form protection class, or one
      *                                of the pre-defined form protection types:
      *                                frontend, backend, installtool
-     * @param mixed $constructorArguments Arguments for the class-constructor
+     * @param array<int, mixed> $constructorArguments Arguments for the class-constructor
      * @return \TYPO3\CMS\Core\FormProtection\AbstractFormProtection the requested instance
      */
     public static function get($classNameOrType = 'default', ...$constructorArguments)
@@ -179,7 +179,7 @@ class FormProtectionFactory
      * and stores it internally.
      *
      * @param array $className
-     * @param mixed $constructorArguments
+     * @param array<int, mixed> $constructorArguments
      * @throws \InvalidArgumentException
      * @return AbstractFormProtection
      */
index ef12baf..912bb9d 100644 (file)
@@ -156,7 +156,7 @@ class Request extends Message implements RequestInterface
      * If the header does not appear in the message, this method MUST return an
      * empty array.
      *
-     * @param string $name Case-insensitive header field name.
+     * @param string $header Case-insensitive header field name.
      * @return string[] An array of string values as provided for the given
      *    header. If the header does not appear in the message, this method MUST
      *    return an empty array.
index 85b5c78..6ec7996 100644 (file)
@@ -129,10 +129,10 @@ class Rfc822AddressesParser
     /**
      * Sets up the object.
      *
-     * @access public
-     * @param string  $address          The address(es) to validate.
-     * @param string  $default_domain  Default domain/host etc. If not supplied, will be set to localhost.
-     * @param bool $validate           Whether to validate atoms. Turn this off if you need to run addresses through before encoding the personal names, for instance.
+     * @param string $address The address(es) to validate.
+     * @param string $default_domain Default domain/host etc. If not supplied, will be set to localhost.
+     * @param bool $validate Whether to validate atoms. Turn this off if you need to run addresses through before encoding the personal names, for instance.
+     * @param int $limit
      */
     public function __construct($address = null, $default_domain = null, $validate = null, $limit = null)
     {
@@ -155,10 +155,10 @@ class Rfc822AddressesParser
      * or when creating the object. One or the other.
      *
      * @access public
-     * @param string  $address          The address(es) to validate.
-     * @param string  $default_domain  Default domain/host etc.
-     * @param bool $nest_groups         Whether to return the structure with groups nested for easier viewing.
-     * @param bool $validate           Whether to validate atoms. Turn this off if you need to run addresses through before encoding the personal names, for instance.
+     * @param string $address The address(es) to validate.
+     * @param string $default_domain Default domain/host etc.
+     * @param bool $validate Whether to validate atoms. Turn this off if you need to run addresses through before encoding the personal names, for instance.
+     * @param int $limit
      * @return array A structured array of addresses.
      */
     public function parseAddressList($address = null, $default_domain = null, $validate = null, $limit = null)
index c95c779..fd53832 100644 (file)
@@ -118,7 +118,7 @@ class PackageManager implements \TYPO3\CMS\Core\SingletonInterface
     }
 
     /**
-     * @param DependencyResolver
+     * @param DependencyResolver $dependencyResolver
      */
     public function injectDependencyResolver(DependencyResolver $dependencyResolver)
     {
index ff7f116..bd6c795 100644 (file)
@@ -46,6 +46,9 @@ class ResourceCompressor
      */
     protected $gzipCompressionLevel = -1;
 
+    /**
+     * @var string
+     */
     protected $htaccessTemplate = '<FilesMatch "\\.(js|css)(\\.gzip)?$">
        <IfModule mod_expires.c>
                ExpiresActive on
index d381184..2d1e1b5 100644 (file)
@@ -39,7 +39,7 @@ class MagicImageService
     /**
      * Creates a magic image
      *
-     * @param Resource\File $imageFileObject: the original image file
+     * @param Resource\File $imageFileObject the original image file
      * @param array $fileConfiguration (width, height)
      * @return Resource\ProcessedFile
      */
index 29f64f0..c4f4e9f 100644 (file)
@@ -248,8 +248,6 @@ class MarkerBasedTemplateService
      * value, which in its turn contains the elements of the sub-subparts.
      * Empty arrays for Subparts will cause the subtemplate to be cleared.
      *
-     * @static
-     *
      * @param string $content The content stream, typically HTML template content.
      * @param array $markersAndSubparts The array of single markers and subpart contents.
      * @param string $wrap A wrap value - [part1] | [part2] - for the markers before substitution.
index dad5530..c362f1c 100644 (file)
@@ -825,7 +825,6 @@ class ExtensionManagementUtility
      * Adds an ExtJS module (main or sub) to the backend interface
      * FOR USE IN ext_tables.php FILES
      *
-     * @static
      * @param string $extensionName
      * @param string $mainModuleName Is the main module key
      * @param string $subModuleName Is the submodule key, if blank a plain main module is generated
@@ -1027,7 +1026,6 @@ class ExtensionManagementUtility
      * This also tracks which content was added by extensions (in TYPO3_CONF_VARS_extensionAdded)
      * so that they cannot be editted again through the Install Tool.
      *
-     * @static
      * @param string $group The group ('FE', 'BE', 'SYS' ...)
      * @param string $key The key of this setting within the group
      * @param string $content The text to add (include leading "\n" in case of multi-line entries)
index 9d8ffb4..3040893 100644 (file)
@@ -3860,7 +3860,7 @@ class GeneralUtility
      * the instance of a specific class.
      *
      * @param string $className name of the class to instantiate, must not be empty and not start with a backslash
-     * @param mixed $constructorArguments Arguments for the constructor
+     * @param array<int, mixed> $constructorArguments Arguments for the constructor
      * @return object the created instance
      * @throws \InvalidArgumentException if $className is empty or starts with a backslash
      */
index e2e3a19..4aba4d6 100644 (file)
@@ -21,6 +21,9 @@ use TYPO3\CMS\Core\Cache\Backend\AbstractBackend;
  */
 class ConcreteBackendFixture extends AbstractBackend
 {
+    /**
+     * @var string
+     */
     protected $someOption;
 
     public function set($entryIdentifier, $data, array $tags = [], $lifetime = null)
index 4f6cf54..092a750 100644 (file)
@@ -21,6 +21,9 @@ use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
 */
 class FrontendFixture implements FrontendInterface
 {
+    /**
+     * @var string
+     */
     protected $identifier;
 
     public function __construct($identifier)
index 370dc3a..6e0e7f1 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class ContentVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['css_styled_content'];
 
+    /**
+     * @var array
+     */
     protected static $commonContentFields = [
         'CType',
         'colPos',
@@ -38,6 +44,9 @@ class ContentVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\F
         'categories',
     ];
 
+    /**
+     * @var array
+     */
     protected static $headerFields = [
         'header',
         'header_layout',
@@ -46,6 +55,9 @@ class ContentVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\F
         'header_link',
     ];
 
+    /**
+     * @var array
+     */
     protected static $imageFields = [
         'image',
         'image_zoom',
@@ -56,6 +68,9 @@ class ContentVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\F
         'imagecols',
     ];
 
+    /**
+     * @var array
+     */
     protected static $contentFieldsByType = [
         'header' => [
             'additionalFields' => ['subheader'],
index be81885..3845d5d 100644 (file)
@@ -124,9 +124,9 @@ class FrontendUser extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
     /**
      * Constructs a new Front-End User
      *
-     * @api
      * @param string $username
      * @param string $password
+     * @api
      */
     public function __construct($username = '', $password = '')
     {
index 8cf718a..e4f4cdf 100644 (file)
@@ -77,7 +77,7 @@ class Result
      * Injects the parent result and propagates the
      * cached error states upwards
      *
-     * @param \TYPO3\CMS\Extbase\Error\Error $parent
+     * @param Result $parent
      * @return void
      */
     public function setParent(Result $parent)
index 5a0f040..676a7b3 100644 (file)
@@ -368,7 +368,7 @@ class DataMapFactory implements \TYPO3\CMS\Core\SingletonInterface
      * This method sets the configuration for a 1:1 relation based on
      * the $TCA column configuration
      *
-     * @param string|ColumnMap $columnMap The column map
+     * @param ColumnMap $columnMap The column map
      * @param string $columnConfiguration The column configuration from $TCA
      * @return ColumnMap
      */
@@ -390,7 +390,7 @@ class DataMapFactory implements \TYPO3\CMS\Core\SingletonInterface
      * This method sets the configuration for a 1:n relation based on
      * the $TCA column configuration
      *
-     * @param string|ColumnMap $columnMap The column map
+     * @param ColumnMap $columnMap The column map
      * @param string $columnConfiguration The column configuration from $TCA
      * @return ColumnMap
      */
@@ -412,7 +412,7 @@ class DataMapFactory implements \TYPO3\CMS\Core\SingletonInterface
      * This method sets the configuration for a m:n relation based on
      * the $TCA column configuration
      *
-     * @param string|ColumnMap $columnMap The column map
+     * @param ColumnMap $columnMap The column map
      * @param string $columnConfiguration The column configuration from $TCA
      * @throws \TYPO3\CMS\Extbase\Persistence\Generic\Exception\UnsupportedRelationException
      * @return ColumnMap
index c96a60f..8355605 100644 (file)
@@ -604,8 +604,8 @@ class Query implements QueryInterface
      * Returns a greater than or equal criterion used for matching objects against a query
      *
      * @param string $propertyName The name of the property to compare against
-     * @param $operandLower The value of the lower boundary to compare against
-     * @param $operandUpper The value of the upper boundary to compare against
+     * @param mixed $operandLower The value of the lower boundary to compare against
+     * @param mixed $operandUpper The value of the upper boundary to compare against
      * @return \TYPO3\CMS\Extbase\Persistence\Generic\Qom\AndInterface
      * @throws \TYPO3\CMS\Extbase\Persistence\Generic\Exception\InvalidNumberOfConstraintsException
      * @api
index 13179eb..7d8ac22 100644 (file)
@@ -11,8 +11,14 @@ class t3lib_object_tests_singleton implements \TYPO3\CMS\Core\SingletonInterface
  */
 class t3lib_object_tests_a
 {
+    /**
+     * @var \t3lib_object_tests_b
+     */
     public $b;
 
+    /**
+     * @var \t3lib_object_tests_c
+     */
     public $c;
 
     /**
@@ -31,10 +37,19 @@ class t3lib_object_tests_a
  */
 class t3lib_object_tests_amixed_array
 {
+    /**
+     * @var \t3lib_object_tests_b
+     */
     public $b;
 
+    /**
+     * @var \t3lib_object_tests_c
+     */
     public $c;
 
+    /**
+     * @var array
+     */
     public $myvalue;
 
     /**
@@ -55,10 +70,19 @@ class t3lib_object_tests_amixed_array
  */
 class t3lib_object_tests_amixed_null
 {
+    /**
+     * @var \t3lib_object_tests_b
+     */
     public $b;
 
+    /**
+     * @var \t3lib_object_tests_c
+     */
     public $c;
 
+    /**
+     * @var mixed|null
+     */
     public $myvalue;
 
     /**
@@ -79,10 +103,19 @@ class t3lib_object_tests_amixed_null
  */
 class t3lib_object_tests_amixed_array_singleton implements \TYPO3\CMS\Core\SingletonInterface
 {
+    /**
+     * @var \t3lib_object_tests_b
+     */
     public $b;
 
+    /**
+     * @var \t3lib_object_tests_c
+     */
     public $c;
 
+    /**
+     * @var array
+     */
     public $myvalue;
 
     /**
@@ -103,6 +136,9 @@ class t3lib_object_tests_amixed_array_singleton implements \TYPO3\CMS\Core\Singl
  */
 class t3lib_object_tests_b implements \TYPO3\CMS\Core\SingletonInterface
 {
+    /**
+     * @var \t3lib_object_tests_c
+     */
     public $c;
 
     /**
@@ -233,8 +269,14 @@ class t3lib_object_tests_cyclic2WithSetterDependency
  */
 class t3lib_object_tests_injectmethods
 {
+    /**
+     * @var \t3lib_object_tests_b
+     */
     public $b;
 
+    /**
+     * @var \t3lib_object_tests_b_child
+     */
     public $bchild;
 
     /**
@@ -260,6 +302,9 @@ class t3lib_object_tests_injectmethods
  */
 class t3lib_object_tests_injectsettings
 {
+    /**
+     * @var array
+     */
     public $settings;
 
     /**
@@ -276,6 +321,9 @@ class t3lib_object_tests_injectsettings
  */
 class t3lib_object_tests_resolveablecyclic1 implements \TYPO3\CMS\Core\SingletonInterface
 {
+    /**
+     * @var \t3lib_object_tests_resolveablecyclic2
+     */
     public $o2;
 
     /**
@@ -292,8 +340,14 @@ class t3lib_object_tests_resolveablecyclic1 implements \TYPO3\CMS\Core\Singleton
  */
 class t3lib_object_tests_resolveablecyclic2 implements \TYPO3\CMS\Core\SingletonInterface
 {
+    /**
+     * @var \t3lib_object_tests_resolveablecyclic1
+     */
     public $o1;
 
+    /**
+     * @var \t3lib_object_tests_resolveablecyclic3
+     */
     public $o3;
 
     /**
@@ -318,6 +372,9 @@ class t3lib_object_tests_resolveablecyclic2 implements \TYPO3\CMS\Core\Singleton
  */
 class t3lib_object_tests_resolveablecyclic3 implements \TYPO3\CMS\Core\SingletonInterface
 {
+    /**
+     * @var \t3lib_object_tests_resolveablecyclic1
+     */
     public $o1;
 
     /**
index 7be3f3e..e397797 100644 (file)
@@ -33,8 +33,14 @@ use TYPO3\CMS\Extbase\Tests\Unit\Property\Fixtures\DataProviderTwoInterface;
  */
 class PropertyMapperTest extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var \TYPO3\CMS\Extbase\Property\PropertyMappingConfigurationBuilder|\PHPUnit_Framework_MockObject_MockObject
+     */
     protected $mockConfigurationBuilder;
 
+    /**
+     * @var \TYPO3\CMS\Extbase\Property\PropertyMappingConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
     protected $mockConfiguration;
 
     /**
index b9f3dc6..df8e150 100644 (file)
@@ -21,6 +21,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Reflection\Fixture;
  */
 class ArrayAccessClass implements \ArrayAccess
 {
+    /**
+     * @var array
+     */
     protected $array = [];
 
     /**
index 1bc63fa..58fea90 100644 (file)
@@ -21,22 +21,49 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Reflection\Fixture;
  */
 class DummyClassWithGettersAndSetters
 {
+    /**
+     * @var mixed
+     */
     protected $property;
 
+    /**
+     * @var mixed
+     */
     protected $anotherProperty;
 
+    /**
+     * @var mixed
+     */
     protected $property2;
 
+    /**
+     * @var bool
+     */
     protected $booleanProperty = true;
 
+    /**
+     * @var mixed
+     */
     protected $protectedProperty;
 
+    /**
+     * @var string
+     */
     protected $unexposedProperty = 'unexposed';
 
+    /**
+     * @var mixed
+     */
     public $publicProperty;
 
+    /**
+     * @var int
+     */
     public $publicProperty2 = 42;
 
+    /**
+     * @var bool
+     */
     protected $anotherBooleanProperty = true;
 
     /**
index f214998..cf01b93 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Extbase\Reflection\Exception\PropertyNotAccessibleException;
  */
 class ObjectAccessTest extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var \TYPO3\CMS\Extbase\Tests\Unit\Reflection\Fixture\DummyClassWithGettersAndSetters
+     */
     protected $dummyObject;
 
+    /**
+     * Set up
+     */
     protected function setUp()
     {
         $this->dummyObject = new \TYPO3\CMS\Extbase\Tests\Unit\Reflection\Fixture\DummyClassWithGettersAndSetters();
@@ -409,6 +415,7 @@ class ObjectAccessTest extends \TYPO3\Components\TestingFramework\Core\Unit\Unit
     /**
      * @dataProvider propertyGettableTestValues
      * @test
+     *
      * @param string $property
      * @param bool $expected
      */
index 12dcd60..49acae3 100644 (file)
@@ -26,6 +26,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 abstract class AbstractValidatorTestcase extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName;
 
     /**
index de4161f..447f03c 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class BooleanValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\BooleanValidator::class;
 
     /**
index 2c1fbf6..d4c723c 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class FloatValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\FloatValidator::class;
 
     public function setup()
index 948818c..84c106a 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class GenericObjectValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\GenericObjectValidator::class;
 
     protected function setUp()
index 94d298f..7763246 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class IntegerValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\IntegerValidator::class;
 
     public function setup()
index e60b9c8..51068a3 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class NotEmptyValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\NotEmptyValidator::class;
 
     public function setup()
index bd64557..6b81844 100644 (file)
@@ -26,6 +26,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class NumberRangeValidatorTest extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\NumberRangeValidator::class;
 
     /**
index 501447f..ee59afa 100644 (file)
@@ -26,6 +26,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class NumberValidatorTest extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\NumberValidator::class;
 
     /**
index 3a02b0d..d168a52 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class RawValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\RawValidator::class;
 
     /**
index 224a867..714c5a9 100644 (file)
@@ -26,6 +26,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class RegularExpressionValidatorTest extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\RegularExpressionValidator::class;
 
     /**
index 30cb907..7ce3a6e 100644 (file)
@@ -27,6 +27,9 @@ use TYPO3\CMS\Extbase\Validation\Exception\InvalidValidationOptionsException;
  */
 class StringLengthValidatorTest extends \TYPO3\Components\TestingFramework\Core\Unit\UnitTestCase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\StringLengthValidator::class;
 
     public function setup()
index e3402b9..1f93da3 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class StringValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\StringValidator::class;
 
     public function setup()
index 320bb2e..acd7861 100644 (file)
@@ -28,6 +28,9 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator;
  */
 class TextValidatorTest extends \TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\AbstractValidatorTestcase
 {
+    /**
+     * @var string
+     */
     protected $validatorClassName = \TYPO3\CMS\Extbase\Validation\Validator\TextValidator::class;
 
     public function setup()
index b73f7ed..2d12496 100644 (file)
@@ -43,10 +43,10 @@ class EmConfUtility implements \TYPO3\CMS\Core\SingletonInterface
      * Generates the content for the ext_emconf.php file
      * Sets dependencies from TER data if any
      *
-     * @internal
      * @param array $extensionData
      * @param \TYPO3\CMS\Extensionmanager\Domain\Model\Extension $extension Extension object from TER data
      * @return string
+     * @internal
      */
     public function constructEmConf(array $extensionData, \TYPO3\CMS\Extensionmanager\Domain\Model\Extension $extension = null)
     {
index 85960ad..0bf3745 100644 (file)
@@ -380,7 +380,7 @@ abstract class AbstractExtensionXmlParser extends AbstractXmlParser
     /**
      * Method resets version class properties.
      *
-     * @param $resetAll $all if TRUE, additionally extension properties are reset
+     * @param bool $resetAll If TRUE, additionally extension properties are reset
      * @return void
      * @see $extensionKey, $version, $extensionDLCounter, $versionDLCounter,
      */
index b906939..7782f83 100644 (file)
@@ -111,7 +111,7 @@ class ExtensionXmlPushParser extends AbstractExtensionXmlParser
      * Method is invoked when parser accesses end tag of an element.
      *
      * @param resource $parser parser resource
-     * @param string $elementName: element name at parser's current position
+     * @param string $elementName Element name at parser's current position
      * @return void
      */
     protected function endElement($parser, $elementName)
@@ -133,7 +133,7 @@ class ExtensionXmlPushParser extends AbstractExtensionXmlParser
      * Method is invoked when parser accesses any character other than elements.
      *
      * @param resource $parser parser resource
-     * @param string $data: an element's value
+     * @param string $data An element's value
      * @return void
      */
     protected function characterData($parser, $data)
index bf5f085..f374bac 100644 (file)
@@ -21,8 +21,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class FileMetadataVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['filemetadata'];
 
+    /**
+     * @var array
+     */
     protected static $fileMetadataFields = [
         File::FILETYPE_UNKNOWN => [
             'sys_language_uid',
index 59e4334..5a927b4 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class ContentVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['fluid_styled_content'];
 
+    /**
+     * @var array
+     */
     protected static $contentFields = [
         'CType',
         'colPos',
index 48cd483..4a05515 100644 (file)
@@ -83,7 +83,7 @@ class ArrayFormFactory extends AbstractFormFactory
      * Add form elements to the $parentRenderable
      *
      * @param array $nestedRenderableConfiguration
-     * @param CompositeRenderableInterface CompositeRenderableInterface $parentRenderable
+     * @param CompositeRenderableInterface $parentRenderable
      * @return mixed
      * @throws IdentifierNotValidException
      * @throws UnknownCompositRenderableException
index 96e3585..44a2551 100644 (file)
@@ -63,6 +63,7 @@ class FinisherContext
 
     /**
      * @param FormRuntime $formRuntime
+     * @param ControllerContext $controllerContext
      * @internal
      */
     public function __construct(FormRuntime $formRuntime, ControllerContext $controllerContext)
index 28262a5..cd727c3 100644 (file)
@@ -94,7 +94,7 @@ class InheritancesResolverService
      * Set the reference configuration which is used to get untouched
      * values which can be merged into the touched configuration.
      *
-     * @param array
+     * @param array $referenceConfiguration
      * @return InheritancesResolverService
      */
     public function setReferenceConfiguration(array $referenceConfiguration)
index a03f342..6b481f7 100644 (file)
@@ -54,7 +54,7 @@ class RenderContentElementPreviewViewHelper extends AbstractViewHelper
 
     /**
      * @param array $arguments
-     * @param callable|\Closure $renderChildrenClosure
+     * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return string
      * @internal
index 30d9d73..e4a20e1 100644 (file)
@@ -42,7 +42,7 @@ class PlainTextMailViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractV
 
     /**
      * @param array $arguments
-     * @param callable|\Closure $renderChildrenClosure
+     * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return string
      * @api
index 080afa6..cadb293 100644 (file)
@@ -56,7 +56,7 @@ class RenderRenderableViewHelper extends AbstractViewHelper
 
     /**
      * @param array $arguments
-     * @param callable|\Closure $renderChildrenClosure
+     * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return string
      * @public
index 1ccbf27..fd4f898 100644 (file)
@@ -67,7 +67,7 @@ class RenderViewHelper extends AbstractViewHelper
 
     /**
      * @param array $arguments
-     * @param callable|\Closure $renderChildrenClosure
+     * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return string
      * @public
index 5052d48..6ea091f 100644 (file)
@@ -536,9 +536,9 @@ class ContentObjectRenderer
      * This method is private API, please use configuration
      * $GLOBALS['TYPO3_CONF_VARS']['FE']['ContentObjects'] to add new content objects
      *
-     * @internal
      * @param string $className
      * @param string $contentObjectName
+     * @internal
      */
     public function registerContentObjectClass($className, $contentObjectName)
     {
@@ -2819,7 +2819,6 @@ class ContentObjectRenderer
      * according to the doctype
      *
      * @param string $content Input value undergoing processing in this function.
-     * @param array $conf stdWrap properties for br.
      * @return string The processed input value
      */
     public function stdWrap_br($content = '')
index c801fec..5f8934b 100644 (file)
@@ -2299,10 +2299,9 @@ abstract class AbstractMenuContentObject
      * Set the parentMenuArr and key to provide the parentMenu informations to the
      * subMenu, special fur IProcFunc and itemArrayProcFunc user functions.
      *
-     * @internal
-     *
      * @param array $menuArr
      * @param int $menuItemKey
+     * @internal
      */
     public function setParentMenu(array $menuArr = [], $menuItemKey)
     {
index b5f4215..f63f80a 100644 (file)
@@ -820,7 +820,7 @@ class ContentObjectRendererTest extends \TYPO3\Components\TestingFramework\Core\
      *  - Otherwise rounds like round() and decimals can be applied.
      *  - Always returns float.
      *
-     * @param float $expected The expected output.
+     * @param float $expect The expected output.
      * @param mixed $content The given content.
      * @param array $conf The given configuration of 'round.'.
      * @return void
index 8f52b3f..da8a5ff 100644 (file)
@@ -21,8 +21,19 @@ use TYPO3\CMS\Frontend\Page\PageRepository;
  */
 class PageRepositoryFixture extends PageRepository
 {
+    /**
+     * @var int
+     */
     public static $getHashCallCount = 0;
+
+    /**
+     * @var int
+     */
     public static $storeHashCallCount = 0;
+
+    /**
+     * @var mixed
+     */
     public static $dbCacheContent = null;
 
     public static function getHash($hash)
index d49d4ae..d8f1bb1 100644 (file)
@@ -240,7 +240,7 @@ class PageFunctionsController extends \TYPO3\CMS\Backend\Module\BaseScriptClass
      * returns a new standalone view, shorthand function
      *
      * @param string $extensionName
-     * @param string $controllerExtensionname
+     * @param string $controllerExtensionName
      * @param string $templateName
      * @return StandaloneView
      */
index 1272a19..d3fe708 100644 (file)
@@ -21,6 +21,9 @@ use TYPO3\CMS\Backend\Utility\BackendUtility;
  */
 class ExportTest extends \TYPO3\CMS\Impexp\Tests\Functional\Export\AbstractExportTestCase
 {
+    /**
+     * @var array
+     */
     protected $pathsToLinkInTestInstance = [
             'typo3/sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload' => 'fileadmin/user_upload'
     ];
index 07a7007..00cbfed 100644 (file)
@@ -21,6 +21,9 @@ use TYPO3\CMS\Backend\Utility\BackendUtility;
  */
 class ExportTest extends \TYPO3\CMS\Impexp\Tests\Functional\Export\AbstractExportTestCase
 {
+    /**
+     * @var array
+     */
     protected $pathsToLinkInTestInstance = [
         'typo3/sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload' => 'fileadmin/user_upload'
     ];
index c695717..24c1366 100644 (file)
@@ -59,7 +59,7 @@ return [
                 'eval' => 'datetime',
                 'default' => 0,
                 'range' => [
-                    'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y'))
+                    'lower' => mktime(0, 0, 0, (int)date('m'), (int)date('d'), (int)date('Y'))
                 ],
             ],
         ],
@@ -72,7 +72,7 @@ return [
                 'eval' => 'datetime',
                 'default' => 0,
                 'range' => [
-                    'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y'))
+                    'lower' => mktime(0, 0, 0, (int)date('m'), (int)date('d'), (int)date('Y'))
                 ],
             ],
         ],
index cc6d9c0..a3dc1df 100644 (file)
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Impexp\Tests\Functional\Import\IrreTutorialRecords;
  */
 class ImportInEmptyDatabaseTest extends \TYPO3\CMS\Impexp\Tests\Functional\Import\AbstractImportTestCase
 {
+    /**
+     * @var string
+     */
     protected $assertionDataSetDirectory = 'typo3/sysext/impexp/Tests/Functional/Import/IrreTutorialRecords/DataSet/Assertion/';
 
     /**
index d9e9fdb..8556f6b 100644 (file)
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Impexp\Tests\Functional\Import\PagesAndTtContent;
  */
 class ImportInEmptyDatabaseTest extends \TYPO3\CMS\Impexp\Tests\Functional\Import\AbstractImportTestCase
 {
+    /**
+     * @var string
+     */
     protected $assertionDataSetDirectory = 'typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContent/DataSet/Assertion/';
 
     /**
index 590cea2..b4bb05a 100644 (file)
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Impexp\Tests\Functional\Import\PagesAndTtContentWithImages;
  */
 class ImportInEmptyDatabaseTest extends \TYPO3\CMS\Impexp\Tests\Functional\Import\AbstractImportTestCase
 {
+    /**
+     * @var string
+     */
     protected $assertionDataSetDirectory = 'typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/DataSet/Assertion/';
 
     /**
index 5a4c655..4386812 100644 (file)
@@ -19,14 +19,23 @@ namespace TYPO3\CMS\Impexp\Tests\Functional\Import\PagesAndTtContentWithImages;
  */
 class ImportInFilledDatabaseTest extends \TYPO3\CMS\Impexp\Tests\Functional\Import\AbstractImportTestCase
 {
+    /**
+     * @var array
+     */
     protected $additionalFoldersToCreate = [
         '/fileadmin/user_upload'
     ];
 
+    /**
+     * @var array
+     */
     protected $pathsToLinkInTestInstance = [
         'typo3/sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload/typo3_image2.jpg' => 'fileadmin/user_upload/typo3_image2.jpg',
     ];
 
+    /**
+     * @var string
+     */
     protected $assertionDataSetDirectory = 'typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/DataSet/Assertion/';
 
     /**
index 1e2a217..907bf6e 100644 (file)
@@ -112,7 +112,7 @@ class OpendocsToolbarItem implements ToolbarItemInterface
     /**
      * Get menu entries for all eligible records
      *
-     * @param $documents
+     * @param array $documents
      * @return array
      */
     protected function getMenuEntries(array $documents) : array
index 3d218a2..397583d 100644 (file)
@@ -129,13 +129,25 @@ class SpellCheckingController
      */
     public $filePrefix = 'rtehtmlarea_';
 
-    // Pre-FAL backward compatibility
+    /**
+     * Pre-FAL backward compatibility
+     *
+     * @var string
+     */
     protected $uploadFolder = 'uploads/tx_rtehtmlarea/';
 
-    // Path to main dictionary
+    /**
+     * Path to main dictionary
+     *
+     * @var string
+     */
     protected $mainDictionaryPath;
 
-    // Path to personal dictionary
+    /**
+     * Path to personal dictionary
+     *
+     * @var string
+     */
     protected $personalDictionaryPath;
 
     /**
index 9421b6c..2a3ae33 100644 (file)
@@ -100,7 +100,7 @@ class MicroDataSchema extends RteHtmlAreaApi
      * Convert the xml rdf schema into an array
      *
      * @param string $string XML rdf schema to convert into an array
-     * @param array    $schema: reference to the array to be filled
+     * @param array    $schema reference to the array to be filled
      * @return void
      */
     protected function parseSchema($string, &$schema)
index d7d1b17..283c622 100644 (file)
@@ -90,6 +90,7 @@ class EditImageHandler implements LinkHandlerInterface, LinkParameterProviderInt
      * Disallow this handler if no image is there to edit
      *
      * @param array $allowedItems
+     * @param array $linkParts
      * @return array
      */
     public function modifyAllowedItems($allowedItems, $linkParts)
index 1b5d4e8..f62011f 100644 (file)
@@ -44,7 +44,7 @@ return [
                 'default' => 0,
                 'range' => [
                     'upper' => mktime(0, 0, 0, 12, 31, 2020),
-                    'lower' => mktime(0, 0, 0, date('m') - 1, date('d'), date('Y'))
+                    'lower' => mktime(0, 0, 0, (int)date('m') - 1, (int)date('d'), (int)date('Y'))
                 ]
             ]
         ],
index 226058c..7d4de8a 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class AcronymVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['rtehtmlarea'];
 
+    /**
+     * @var array
+     */
     protected static $acronymFields = [
         'hidden',
         'starttime',
index d8cc426..0bb6bb8 100644 (file)
@@ -243,7 +243,7 @@ class SaltedPasswordService extends \TYPO3\CMS\Sv\AbstractAuthenticationService
      * parameters. The syntax is the same as for sprintf()
      *
      * @param string $message Message to output
-     * @param string $params
+     * @param array<int, mixed> $params
      * @return void
      * @see \TYPO3\CMS\Core\Utility\GeneralUtility::sysLog()
      */
index 85bc7f1..ac56ba3 100644 (file)
@@ -46,9 +46,9 @@ class CronCommand
     /**
      * Constructor
      *
-     * @api
      * @param string $cronCommand The cron command can hold any combination documented as valid
      * @param bool|int $timestamp Optional start time, used in unit tests
+     * @api
      */
     public function __construct($cronCommand, $timestamp = false)
     {
index 6393e8b..db3a88c 100644 (file)
@@ -237,7 +237,7 @@ abstract class AbstractTask
     /**
      * This method is used to set the task group (uid) of the task
      *
-     * @param int $timestamp Uid of task group
+     * @param int $taskGroup Uid of task group
      * @return void
      */
     public function setTaskGroup($taskGroup)
index 69341ae..442f5ec 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class TaskGroupVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['scheduler'];
 
+    /**
+     * @var array
+     */
     protected static $taskGroupFields = [
         'hidden',
         'groupName',
index 5904f6a..af57cd5 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class NoteVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['sys_note'];
 
+    /**
+     * @var array
+     */
     protected static $noteFields = [
         'category',
         'personal',
index 4af3806..391e30c 100644 (file)
@@ -99,7 +99,7 @@ class TypoScriptTemplateInformationModuleFunctionController extends AbstractFunc
      * Initializes the module. Done in this function because we may need to re-initialize if data is submitted!
      *
      * @param int $pageId The uid of the current page
-     * @param int $template_uid: The uid of the template record to be rendered (only if more than one template on the current page)
+     * @param int $template_uid The uid of the template record to be rendered (only if more than one template on the current page)
      * @return bool Returns TRUE if a template record was found, otherwise FALSE
      */
     public function initialize_editor($pageId, $template_uid = 0)
index da58716..a36b4f9 100644 (file)
@@ -28,7 +28,6 @@ class PagetreeCollectionsProcessor implements \TYPO3\CMS\Backend\Tree\Pagetree\C
     protected $workspaceService = null;
 
     /**
-     * @abstract
      * @param \TYPO3\CMS\Backend\Tree\Pagetree\PagetreeNode $node
      * @param int $mountPoint
      * @param int $level
@@ -44,7 +43,6 @@ class PagetreeCollectionsProcessor implements \TYPO3\CMS\Backend\Tree\Pagetree\C
     }
 
     /**
-     * @abstract
      * @param \TYPO3\CMS\Backend\Tree\Pagetree\PagetreeNode $node
      * @param string $searchFilter
      * @param int $mountPoint
@@ -60,7 +58,6 @@ class PagetreeCollectionsProcessor implements \TYPO3\CMS\Backend\Tree\Pagetree\C
     }
 
     /**
-     * @abstract
      * @param string $searchFilter
      * @param \TYPO3\CMS\Backend\Tree\Pagetree\PagetreeNodeCollection $nodeCollection
      * @return void
index 241744a..8fc60ab 100644 (file)
@@ -621,7 +621,7 @@ class GridDataService
      * Emits a signal to be handled by any registered slots.
      *
      * @param string $signalName Name of the signal
-     * @param mixed $arguments
+     * @param array<int, mixed> $arguments
      * @return array
      */
     protected function emitSignal($signalName, ...$arguments)
index a6eebe6..b1b7fe0 100644 (file)
@@ -728,7 +728,6 @@ class WorkspaceService implements SingletonInterface
     /**
      * Generates a view link for a page.
      *
-     * @static
      * @param string $table Table to be used
      * @param int $uid Uid of the version(!) record
      * @param array $liveRecord Optional live record data
index 616a95a..72b662b 100644 (file)
@@ -21,6 +21,9 @@ use TYPO3\CMS\Backend\Utility\BackendUtility;
  */
 class ActionHandlerTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['version', 'workspaces'];
 
     /**
index 65a61e0..bb7f8ba 100644 (file)
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Workspaces\Tests\Functional\Service;
  */
 class WorkspaceServiceTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['version', 'workspaces'];
 
     /**
index 9ebf994..ff80bf1 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class WorkspaceStageVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['workspaces'];
 
+    /**
+     * @var array
+     */
     protected static $workspaceStageFields = [
         'title',
         'responsible_persons',
index 8b24328..5333ebb 100644 (file)
@@ -20,8 +20,14 @@ use TYPO3\CMS\Lang\LanguageService;
 
 class WorkspaceVisibleFieldsTest extends \TYPO3\Components\TestingFramework\Core\Functional\FunctionalTestCase
 {
+    /**
+     * @var array
+     */
     protected $coreExtensionsToLoad = ['workspaces'];
 
+    /**
+     * @var array
+     */
     protected static $workspaceFields = [
         'title',
         'description',