[TASK] Replace last occurrences of DocumentTemplate::header 18/46018/2
authorGeorg Ringer <georg.ringer@gmail.com>
Sat, 16 Jan 2016 16:03:35 +0000 (17:03 +0100)
committerMorton Jonuschat <m.jonuschat@mojocode.de>
Sat, 16 Jan 2016 18:24:59 +0000 (19:24 +0100)
As the classes using the mentioned method don't use any templating,
replace the occurrences of the method with inline HTML.

Resolves: #72771
Releases: master
Change-Id: Ife88cd5ff942044037bb0d06678121b9e1490fff
Reviewed-on: https://review.typo3.org/46018
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
typo3/sysext/frontend/Classes/Controller/PageInformationController.php
typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php
typo3/sysext/info_pagetsconfig/Classes/Controller/InfoPageTyposcriptConfigController.php
typo3/sysext/wizard_crpages/Classes/Controller/CreatePagesWizardModuleFunctionController.php
typo3/sysext/wizard_sortpages/Classes/View/SortPagesWizardModuleFunction.php

index 5809761..6b4895e 100644 (file)
@@ -54,7 +54,7 @@ class PageInformationController extends \TYPO3\CMS\Backend\Module\AbstractFuncti
      */
     public function main()
     {
-        $theOutput = $this->pObj->doc->header($this->getLanguageService()->sL('LLL:EXT:frontend/Resources/Private/Language/locallang_webinfo.xlf:page_title'));
+        $theOutput = '<h1>' . htmlspecialchars($this->getLanguageService()->sL('LLL:EXT:frontend/Resources/Private/Language/locallang_webinfo.xlf:page_title')) . '</h1>';
         $dblist = GeneralUtility::makeInstance(PageLayoutView::class);
         $dblist->descrTable = '_MOD_web_info';
         $dblist->thumbs = 0;
index 3d95be1..99aed48 100644 (file)
@@ -75,7 +75,7 @@ class TranslationStatusController extends \TYPO3\CMS\Backend\Module\AbstractFunc
      */
     public function main()
     {
-        $theOutput = $this->pObj->doc->header($this->getLanguageService()->sL('LLL:EXT:frontend/Resources/Private/Language/locallang_webinfo.xlf:lang_title'));
+        $theOutput = '<h1>' . htmlspecialchars($this->getLanguageService()->sL('LLL:EXT:frontend/Resources/Private/Language/locallang_webinfo.xlf:lang_title')) . '</h1>';
         if ($this->pObj->id) {
             // Depth selector:
             $theOutput .= '<div class="form-inline form-inline-spaced">';
index 058b8a8..a73fe73 100644 (file)
@@ -97,7 +97,7 @@ class InfoPageTyposcriptConfigController extends \TYPO3\CMS\Backend\Module\Abstr
             $menu .= BackendUtility::getDropdownMenu($this->pObj->id, 'SET[tsconf_parts]', $this->pObj->MOD_SETTINGS['tsconf_parts'], $this->pObj->MOD_MENU['tsconf_parts']);
             $menu .= '<div class="checkbox"><label for="checkTsconf_alphaSort">' . BackendUtility::getFuncCheck($this->pObj->id, 'SET[tsconf_alphaSort]', $this->pObj->MOD_SETTINGS['tsconf_alphaSort'], '', '', 'id="checkTsconf_alphaSort"') . ' ' . $this->getLanguageService()->getLL('sort_alphabetic', true) . '</label></div>';
             $menu .= '</div>';
-            $theOutput = $this->pObj->doc->header($this->getLanguageService()->getLL('tsconf_title'));
+            $theOutput = '<h1>' . htmlspecialchars($this->getLanguageService()->getLL('tsconf_title')) . '</h1>';
 
             if ($this->pObj->MOD_SETTINGS['tsconf_parts'] == 99) {
                 $TSparts = BackendUtility::getPagesTSconfig($this->pObj->id, null, true);
index 06845ff..561c7e5 100644 (file)
@@ -184,7 +184,7 @@ class CreatePagesWizardModuleFunctionController extends \TYPO3\CMS\Backend\Modul
         }
         // CSH
         $theCode .= BackendUtility::cshItem('_MOD_web_func', 'tx_wizardcrpages', null, '<span class="btn btn-default btn-sm">|</span>');
-        $out = $this->pObj->doc->header($this->getLanguageService()->getLL('wiz_crMany'));
+        $out = '<h1>' . htmlspecialchars($this->getLanguageService()->getLL('wiz_crMany')) . '</h1>';
         $out .= '<div>' . $theCode . '</div>';
         return $out;
     }
index 4da3999..ee4353a 100644 (file)
@@ -38,7 +38,7 @@ class SortPagesWizardModuleFunction extends \TYPO3\CMS\Backend\Module\AbstractFu
         $lang->includeLLFile('EXT:wizard_sortpages/Resources/Private/Language/locallang.xlf');
         $pageRenderer = GeneralUtility::makeInstance(PageRenderer::class);
         $pageRenderer->loadRequireJsModule('TYPO3/CMS/Backend/Modal');
-        $out = $this->pObj->doc->header($lang->getLL('wiz_sort'));
+        $out = '<h1>' . htmlspecialchars($lang->getLL('wiz_sort')) . '</h1>';
         if ($this->getBackendUser()->workspace === 0) {
             $theCode = '';
             // Check if user has modify permissions to