[BUGFIX] Don’t cut urls in link browser 84/57184/3
authorFrank Naegler <frank.naegler@typo3.org>
Mon, 11 Jun 2018 13:31:27 +0000 (15:31 +0200)
committerSusanne Moog <susanne.moog@typo3.org>
Mon, 11 Jun 2018 15:05:57 +0000 (17:05 +0200)
Using the second parameter of TBE_EDITOR.rawurlencode cuts the input to
200 characters for any input value. The parameter is rather useless and
its usage can be simply removed to allow URLs with more than 200
characters.

Resolves: #85226
Releases: master, 8.7
Change-Id: I8391488d6fb21ede9280041dd41e3feb7e19dbd1
Reviewed-on: https://review.typo3.org/57184
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php
typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php
typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php

index 293b5a8..05c0654 100644 (file)
@@ -550,7 +550,7 @@ abstract class AbstractFormElement extends AbstractNode
                         'this.blur();' .
                         $onlyIfSelectedJS .
                         'vHWin=window.open(' . GeneralUtility::quoteJSvalue($url) . '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(' .
-                                'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300' .
+                                'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value' .
                             ')' .
                             '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(' . GeneralUtility::quoteJSvalue($itemName) . '),' .
                             GeneralUtility::quoteJSvalue('popUp' . $md5ID) . ',' .
index b786cd1..b498b48 100644 (file)
@@ -70,7 +70,7 @@ class EditPopup extends AbstractNode
         $onClick[] = 'vHWin=window.open(';
         $onClick[] =    GeneralUtility::quoteJSvalue($url);
         $onClick[] =    '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(';
-        $onClick[] =        'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300';
+        $onClick[] =        'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value';
         $onClick[] =    ')';
         $onClick[] =    '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(';
         $onClick[] =        GeneralUtility::quoteJSvalue($itemName);
index 5375a18..7bd0869 100644 (file)
@@ -70,7 +70,7 @@ class LinkPopup extends AbstractNode
         $onClick[] = 'vHWin=window.open(';
         $onClick[] =    GeneralUtility::quoteJSvalue($url);
         $onClick[] =    '+\'&P[currentValue]=\'+TBE_EDITOR.rawurlencode(';
-        $onClick[] =        'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value,300';
+        $onClick[] =        'document.editform[' . GeneralUtility::quoteJSvalue($itemName) . '].value';
         $onClick[] =    ')';
         $onClick[] =    '+\'&P[currentSelectedValues]=\'+TBE_EDITOR.curSelected(';
         $onClick[] =        GeneralUtility::quoteJSvalue($itemName);