[TASK] use horizontal ellipsis instead of 3 dots 63/55463/2
authorDaniel Ruf <noreply@example.com>
Fri, 26 Jan 2018 18:32:55 +0000 (19:32 +0100)
committerAndreas Wolf <andreas.wolf@typo3.org>
Sat, 27 Jan 2018 10:26:54 +0000 (11:26 +0100)
Releases: master
Resolves: #83697
Change-Id: I6f7217f8a479298249a92ff43eb650638077d8e5
Reviewed-on: https://review.typo3.org/55463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php
typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CropViewHelperTest.php

index 79ddf7c..6791254 100644 (file)
@@ -30,7 +30,7 @@ use TYPO3Fluid\Fluid\Core\ViewHelper\Traits\CompileWithRenderStatic;
  * <f:format.crop maxCharacters="10">This is some very long text</f:format.crop>
  * </code>
  * <output>
- * This is...
+ * This is
  * </output>
  *
  * <code title="Custom suffix">
@@ -44,7 +44,7 @@ use TYPO3Fluid\Fluid\Core\ViewHelper\Traits\CompileWithRenderStatic;
  * <f:format.crop maxCharacters="10" respectWordBoundaries="false">This is some very long text</f:format.crop>
  * </code>
  * <output>
- * This is so...
+ * This is so
  * </output>
  *
  * <code title="Don't respect HTML tags">
@@ -58,7 +58,7 @@ use TYPO3Fluid\Fluid\Core\ViewHelper\Traits\CompileWithRenderStatic;
  * {someLongText -> f:format.crop(maxCharacters: 10)}
  * </code>
  * <output>
- * someLongText cropped after 10 characters...
+ * someLongText cropped after 10 characters
  * (depending on the value of {someLongText})
  * </output>
  */
@@ -82,7 +82,7 @@ class CropViewHelper extends AbstractViewHelper
     public function initializeArguments()
     {
         $this->registerArgument('maxCharacters', 'int', 'Place where to truncate the string', true);
-        $this->registerArgument('append', 'string', 'What to append, if truncation happened', false, '...');
+        $this->registerArgument('append', 'string', 'What to append, if truncation happened', false, '&hellip;');
         $this->registerArgument('respectWordBoundaries', 'bool', 'If TRUE and division is in the middle of a word, the remains of that word is removed.', false, true);
         $this->registerArgument('respectHtml', 'bool', 'If TRUE the cropped string will respect HTML tags and entities. Technically that means, that cropHTML() is called rather than crop()', false, true);
     }
index bb7865f..5077081 100644 (file)
@@ -52,7 +52,7 @@ class CropViewHelperTest extends ViewHelperBaseTestcase
      */
     public function viewHelperCallsCropHtmlByDefault()
     {
-        $this->mockContentObject->expects($this->once())->method('cropHTML')->with('Some Content', '123|...|1')->will($this->returnValue('Cropped Content'));
+        $this->mockContentObject->expects($this->once())->method('cropHTML')->with('Some Content', '123|&hellip;|1')->will($this->returnValue('Cropped Content'));
         GeneralUtility::addInstance(ContentObjectRenderer::class, $this->mockContentObject);
         $this->setArgumentsUnderTest(
             $this->viewHelper,