[BUGFIX] Avoid double escaping of opendocs menu entries 61/62161/2
authorFelix Althaus <felix.althaus@undkonsorten.com>
Wed, 30 Oct 2019 18:35:39 +0000 (19:35 +0100)
committerDaniel Goerz <daniel.goerz@posteo.de>
Thu, 16 Jan 2020 10:50:34 +0000 (11:50 +0100)
Menu entries in both open documents and recent documents list
of the opendocs extension were htmlspecialchar‘ed twice. One
level of escaping was removed.

Resolves: #89553
Releases: master
Change-Id: Id04f8742e3b91ad3ce8618f4d49f2d4e12b93d71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62161
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php

index f0903eb..9547f92 100644 (file)
@@ -175,7 +175,7 @@ class OpendocsToolbarItem implements ToolbarItemInterface
         $result = [];
         $result['table'] = $table;
         $result['record'] = $record;
-        $result['label'] = htmlspecialchars(strip_tags(htmlspecialchars_decode($document[0])));
+        $result['label'] = strip_tags(htmlspecialchars_decode($document[0]));
         /** @var \TYPO3\CMS\Backend\Routing\UriBuilder $uriBuilder */
         $uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
         $uri = (string)$uriBuilder->buildUriFromRoute('record_edit') . '&' . $document[2];