[BUGFIX] missing parameter for implode
authorJigal van Hemert <jigal@xs4all.nl>
Sun, 8 Apr 2012 06:27:25 +0000 (08:27 +0200)
committerJigal van Hemert <jigal@xs4all.nl>
Sun, 8 Apr 2012 06:28:34 +0000 (08:28 +0200)
Use the preferred syntax for implode()

Change-Id: Id5db3a209903978979eba971f7f53180a850289a
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #34695
Reviewed-on: http://review.typo3.org/10192
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
typo3/sysext/cms/tslib/showpic.php
typo3/sysext/lowlevel/class.tx_lowlevel_cleaner.php
typo3/sysext/scheduler/tasks/class.tx_scheduler_cachingframeworkgarbagecollection_additionalfieldprovider.php

index a21d447..d002dd1 100644 (file)
@@ -154,7 +154,7 @@ class SC_tslib_showpic {
                        throw new UnexpectedValueException('Parameter Error: No file or no parameters given.', 1299514081);
                }
 
-               $this->parametersEncoded = implode($parametersArray);
+               $this->parametersEncoded = implode('', $parametersArray);
 
                        // Chech md5-checksum: If this md5-value does not match the one submitted, then we fail... (this is a kind of security that somebody don't just hit the script with a lot of different parameters
                $md5_value = t3lib_div::hmac(
index 6c65045..1c0ed5f 100644 (file)
@@ -193,7 +193,7 @@ debug($contentTreeData);
                                                $output.='<input type="submit" name="_EDIT" value="EDIT" />';
                                                $output.='<input type="submit" name="_DELETE" value="DELETE" onclick="return confirm(\'Are you sure you wish to delete?\');" />';
                                                $output.= t3lib_utility_Debug::viewArray($rec);
-                                               $output.=md5(implode($rec));
+                                               $output.=md5(implode('', $rec));
                                        }
                                } else {
                                        $output.='No record existed!';
index 69e0d4f..853a72f 100644 (file)
@@ -130,7 +130,7 @@ class tx_scheduler_CachingFrameworkGarbageCollection_AdditionalFieldProvider imp
                                '</option>';
                }
 
-               return implode($options);
+               return implode('', $options);
        }
 
        /**