[BUGFIX] make cols and rows in TextareaViewHelper optional
authorMarkus Günther <mail@markus-guenther.de>
Sun, 18 Nov 2012 13:19:15 +0000 (14:19 +0100)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Sun, 18 Nov 2012 19:05:12 +0000 (20:05 +0100)
When using the Tx_Fluid_ViewHelpers_Form_TextareaViewHelper to render
a <textarea> Element you must provide "cols" and "rows", which should
be optional attributes instead. Nowadays you should rather use CSS
to set the dimensions of any HTML Element.

Resolves: #13255
Release: 6.0

Change-Id: Ia77ab8221866f504af64e76d77269bf88a312577
Reviewed-on: http://review.typo3.org/16556
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php

index ceccd6f..4b23a88 100644 (file)
@@ -40,8 +40,8 @@ class TextareaViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormF
         */
        public function initializeArguments() {
                parent::initializeArguments();
-               $this->registerTagAttribute('rows', 'int', 'The number of rows of a text area', TRUE);
-               $this->registerTagAttribute('cols', 'int', 'The number of columns of a text area', TRUE);
+               $this->registerTagAttribute('rows', 'int', 'The number of rows of a text area');
+               $this->registerTagAttribute('cols', 'int', 'The number of columns of a text area');
                $this->registerTagAttribute('disabled', 'string', 'Specifies that the input element should be disabled when the page loads');
                $this->registerArgument('errorClass', 'string', 'CSS class to set if there are errors for this view helper', FALSE, 'f3-form-error');
                $this->registerUniversalTagAttributes();