[!!!][TASK] Remove deprecated isDisplayCondition function from FormEngine 47/32947/4
authorWouter Wolters <typo3@wouterwolters.nl>
Tue, 23 Sep 2014 21:21:41 +0000 (23:21 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 24 Sep 2014 20:21:47 +0000 (22:21 +0200)
Resolves: #61828
Releases: master
Change-Id: Id5c2d81fdff9cb6960749f93b10db1107aa8ed49
Reviewed-on: http://review.typo3.org/32947
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/backend/Classes/Form/FormEngine.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-61828-RemoveIsDisplayCondition.rst [new file with mode: 0644]

index 84bc4b0..24ccbb0 100644 (file)
@@ -6405,23 +6405,6 @@ TBE_EDITOR.customEvalFunctions[\'' . $evalData . '\'] = function(value) {
        }
 
        /**
-        * Returns TRUE, if the evaluation of the required-field code is OK.
-        *
-        * @param string $displayCond The required-field code
-        * @param array $row The record to evaluate
-        * @param string $ffValueKey FlexForm value key, eg. vDEF
-        * @return boolean
-        * @todo Define visibility
-        * @deprecated since TYPO3 6.1, will be removed 2 versions later - Use \TYPO3\CMS\Backend\Form\ElementConditionMatcher instead
-        */
-       public function isDisplayCondition($displayCond, $row, $ffValueKey = '') {
-               GeneralUtility::logDeprecatedFunction();
-               /** @var $elementConditionMatcher \TYPO3\CMS\Backend\Form\ElementConditionMatcher */
-               $elementConditionMatcher = GeneralUtility::makeInstance('TYPO3\\CMS\\Backend\\Form\\ElementConditionMatcher');
-               return $elementConditionMatcher->match($displayCond, $row, $ffValueKey);
-       }
-
-       /**
         * Return TSCpid (cached)
         * Using BackendUtility::getTSCpid()
         *
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-61828-RemoveIsDisplayCondition.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-61828-RemoveIsDisplayCondition.rst
new file mode 100644 (file)
index 0000000..0169e16
--- /dev/null
@@ -0,0 +1,31 @@
+=================================================================================
+Breaking: #61828 - deprecated isDisplayCondition function from FormEngine removed
+=================================================================================
+
+Description
+===========
+
+Method isDisplayCondition() from \TYPO3\CMS\Backend\Form\FormEngine is removed.
+
+
+Impact
+======
+
+Extensions that still use the function isDisplayCondition will trigger a fatal
+PHP error when records are edited in the backend.
+
+
+Affected installations
+======================
+
+A TYPO3 instance is affected if a 3rd party extension uses the removed function.
+
+
+Migration
+=========
+
+Use \TYPO3\CMS\Backend\Form\ElementConditionMatcher instead of \TYPO3\CMS\Backend\Form\FormEngine::isDisplayCondition
+
+/** @var $elementConditionMatcher \TYPO3\CMS\Backend\Form\ElementConditionMatcher */
+$elementConditionMatcher = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Backend\\Form\\ElementConditionMatcher');
+$elementConditionMatcher->match($displayCond, $row, $ffValueKey);