[BUGFIX] Remove manually set database row 43/52543/3
authorSusanne Moog <susanne.moog@typo3.com>
Wed, 14 Jun 2017 08:49:55 +0000 (10:49 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 14 Jun 2017 13:46:42 +0000 (15:46 +0200)
databaseRow should not be set incompletely in a
FormDataProvider or controller as subsequent
processing may rely on the complete database
row being set (for example language fields).

Resolves: #80855
Related: #80100
Release: master, 8.7, 7.6
Change-Id: I139b426c6598a93a2012cae088e3cbece4e1a83b
Reviewed-on: https://review.typo3.org/52543
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Faton Haliti <fha@systime.dk>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php
typo3/sysext/core/Configuration/DefaultConfiguration.php

index 7220404..da74766 100644 (file)
@@ -217,9 +217,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
                     ],
                 ],
             ],
-            'databaseRow' => [
-                'uid' => (int)$parent['uid'],
-            ],
             'tableName' => $parent['table'],
             'inlineFirstPid' => $inlineFirstPid,
         ];
@@ -300,10 +297,6 @@ class FormInlineAjaxController extends AbstractFormEngineAjaxController
                 'vanillaUid' => (int)$parent['uid'],
                 'command' => 'edit',
                 'tableName' => $parent['table'],
-                'databaseRow' => [
-                    // TcaInlineExpandCollapseState needs this
-                    'uid' => (int)$parent['uid'],
-                ],
                 'processedTca' => $processedTca,
                 'inlineFirstPid' => $inlineFirstPid,
                 'columnsToProcess' => [
index 55f8b1c..e6a0b4d 100644 (file)
@@ -442,6 +442,7 @@ return [
                     ],
                     \TYPO3\CMS\Backend\Form\FormDataProvider\TcaInlineExpandCollapseState::class => [
                         'depends' => [
+                            \TYPO3\CMS\Backend\Form\FormDataProvider\DatabaseEditRow::class,
                             \TYPO3\CMS\Backend\Form\FormDataProvider\TcaColumnsOverrides::class,
                         ],
                     ],