[TASK] Extension Manager: Remove superfluous tests
authorSusanne Moog <typo3@susannemoog.de>
Sat, 1 Sep 2012 20:32:31 +0000 (22:32 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 1 Sep 2012 21:07:12 +0000 (23:07 +0200)
The file handling utility tests contain two tests that
fail under certain circumstances. As the called functions
are already fully  tested, the tests in the file handling
utility are superfluous and can be removed.

Change-Id: I4f9862090786bbf2bbb366cb01ac54c11a7f0cc2
Resolves: #40512
Releases: 6.0
Reviewed-on: http://review.typo3.org/14271
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php

index 7882904..5f542ab 100644 (file)
@@ -110,17 +110,6 @@ class FileHandlingUtilityTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase
 
        /**
         * @test
-        * @expectedException \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException
-        * @return void
-        */
-       public function addDirectoryThrowsExceptionOnError() {
-               $extDirPath = '/etc/test123/';
-               $fileHandlerMock = $this->getAccessibleMock('TYPO3\\CMS\\Extensionmanager\\Utility\\FileHandlingUtility', array('dummy'));
-               $fileHandlerMock->_call('addDirectory', $extDirPath);
-       }
-
-       /**
-        * @test
         * @return void
         */
        public function removeDirectoryRemovesDirectory() {
@@ -133,17 +122,6 @@ class FileHandlingUtilityTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase
 
        /**
         * @test
-        * @expectedException \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException
-        * @return void
-        */
-       public function removeDirectoryThrowsExceptionOnError() {
-               $extDirPath = '/etc/test123/';
-               $fileHandlerMock = $this->getAccessibleMock('TYPO3\\CMS\\Extensionmanager\\Utility\\FileHandlingUtility', array('dummy'));
-               $fileHandlerMock->_call('removeDirectory', $extDirPath);
-       }
-
-       /**
-        * @test
         * @return void
         */
        public function unpackExtensionFromExtensionDataArrayCreatesTheExtensionDirectory() {