[TASK] FollowUp to "Include suggest info into package metadata" 38/30638/2
authorSteffen Ritter <info@rs-websystems.de>
Tue, 10 Jun 2014 10:12:14 +0000 (12:12 +0200)
committerSteffen Ritter <info@rs-websystems.de>
Tue, 10 Jun 2014 10:18:09 +0000 (12:18 +0200)
A small follow-up renaming the variable of the loop which
has not been renamed after copy and paste.

Resolves: #58701
Releases: 6.2
Change-Id: I70af6722200fda48b09734e21c6d90d3a4e9b868
Reviewed-on: https://review.typo3.org/30638
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
typo3/sysext/core/Classes/Package/Package.php

index 3fcb646..a1ff6cc 100644 (file)
@@ -182,9 +182,9 @@ class Package extends \TYPO3\Flow\Package\Package implements PackageInterface {
                        }
                        if (isset($extensionManagerConfiguration['constraints']['suggests']) && is_array($extensionManagerConfiguration['constraints']['conflicts'])) {
                                $composerManifest->suggest = new \stdClass();
-                               foreach ($extensionManagerConfiguration['constraints']['suggests'] as $conflictingPackageKey => $conflictingPackageVersion) {
-                                       if (!empty($conflictingPackageKey)) {
-                                               $composerManifest->suggest->$conflictingPackageKey = $conflictingPackageVersion;
+                               foreach ($extensionManagerConfiguration['constraints']['suggests'] as $suggestedPackageKey => $suggestedPackageVersion) {
+                                       if (!empty($suggestedPackageKey)) {
+                                               $composerManifest->suggest->$suggestedPackageKey = $suggestedPackageVersion;
                                        } else {
                                                // TODO: throw meaningful exception or fail silently?
                                        }