[TASK] Replace $TYPO3_CONF_VARS mentions EXT:install 89/39289/3
authorAndreas Fernandez <a.fernandez@scripting-base.de>
Wed, 6 May 2015 07:22:24 +0000 (09:22 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 6 May 2015 08:02:12 +0000 (10:02 +0200)
The usage of $TYPO3_CONF_VARS is highly discouraged, replace the
mentions in the Install Tool with $GLOBALS['TYPO3_CONF_VARS'].

Resolves: #66812
Releases: master
Change-Id: I9e250e6c38d83e1adf21d7bdc2db17463ead5ee6
Reviewed-on: http://review.typo3.org/39289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan GroƟberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/install/Classes/Controller/Action/Tool/AllConfiguration.php
typo3/sysext/install/Classes/SystemEnvironment/Check.php
typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/Mail.html

index 88c63aa..be6135e 100644 (file)
@@ -164,7 +164,7 @@ class AllConfiguration extends Action\AbstractAction {
                                                                $configurationPathValuePairs[$section . '/' . $valueKey] = $value;
                                                                /** @var $message \TYPO3\CMS\Install\Status\StatusInterface */
                                                                $status = $this->objectManager->get(\TYPO3\CMS\Install\Status\OkStatus::class);
-                                                               $status->setTitle('$TYPO3_CONF_VARS[\'' . $section . '\'][\'' . $valueKey . '\']');
+                                                               $status->setTitle('$GLOBALS[\'TYPO3_CONF_VARS\'][\'' . $section . '\'][\'' . $valueKey . '\']');
                                                                $status->setMessage('New value = ' . $value);
                                                                $statusObjects[] = $status;
                                                        }
index 23ffc65..3d6f6b7 100644 (file)
@@ -162,7 +162,7 @@ class Check {
                                ' the server - ALL content in the forms are discarded and therefore' .
                                ' nothing at all will be editable if you don\'t set this flag!' .
                                ' However if you cannot enable fileupload for some reason in PHP, alternatively' .
-                               ' change the default form encoding value with \\$TYPO3_CONF_VARS[SYS][form_enctype].'
+                               ' change the default form encoding value with $GLOBALS[\'TYPO3_CONF_VARS\'][\'SYS\'][\'form_enctype\'].'
                        );
                } else {
                        $status = new Status\OkStatus();
index b54379c..dbe2981 100644 (file)
@@ -9,12 +9,12 @@
        If no email is received, your setup might be broken. Check the following:
        <ul>
                <li>
-                       If $TYPO3_CONF_VARS['MAIL']['transport'] is set to mail or sendmail, TYPO3 tries to use PHPs internal
+                       If <code>$GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport']</code> is set to mail or sendmail, TYPO3 tries to use PHPs internal
                        mail() function. There might be no such program installed.
                </li>
                <li>
-                       If $TYPO3_CONF_VARS['MAIL']['transport'] is set to smtp, check if the data given in
-                       $TYPO3_CONF_VARS['MAIL'][transport_smtp_*] is valid. Wrong data here results in faulty requests to the
+                       If <code>$GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport']</code> is set to smtp, check if the data given in
+                       <code>$GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport_smtp_*']</code> is valid. Wrong data here results in faulty requests to the
                        mail server. You can find the resulting messages in the mail server log.
                </li>
        </ul>