[BUGFIX] TceformsUpdateWizard shows up too often 33/29033/2
authorMarkus Klein <klein.t3@mfc-linz.at>
Tue, 1 Apr 2014 15:04:11 +0000 (17:04 +0200)
committerStefan Neufeind <typo3.neufeind@speedpartner.de>
Tue, 15 Apr 2014 16:39:31 +0000 (18:39 +0200)
After successfully migrating a field, the field is not added to the list
of finished fields, due to a superfluous check.

Running wizard again finally adds the field to the finished list as the
condition is fulfilled, but the additional run does not
do any useful work anymore.

Fix this by adjusting the condition to safe the extra run.

Resolves: #57497
Releases: 6.2
Change-Id: I6bc15de6f5dbeb58151a1745a849e1b0581b2fbe
Reviewed-on: https://review.typo3.org/29033
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
typo3/sysext/install/Classes/Updates/TceformsUpdateWizard.php

index 338955e..5f25d6e 100644 (file)
@@ -192,9 +192,8 @@ class TceformsUpdateWizard extends AbstractUpdate {
                                        }
                                } while (count($records) === self::RECORDS_PER_QUERY);
 
-                               // add the field to the "finished fields"
-                               // this can only be done
-                               if (is_array($records) && count($records) === 0) {
+                               // add the field to the "finished fields" if things didn't fail above
+                               if (is_array($records)) {
                                        $finishedFields[] = $fieldKey;
                                }
                        }